Re: [PATCH 13/14] mfd: remove unused menelaus driver

["Arnd Bergmann" <arnd@kernel.org>]

On Wed, Sep 9, 2026, at 15:49, sashiko-bot@kernel.org wrote:
> [Severity: Low]
> Is the omap24xx platform completely removed?
>
> It looks like arch/arm/mach-omap2/board-n8x0.c and 
> arch/arm/mach-omap2/common-board-devices.h still exist and unconditionally
> include the deleted header, which breaks the build for OMAP2 configurations:
>
> arch/arm/mach-omap2/board-n8x0.c:
>     #include <linux/mfd/menelaus.h>
>
> arch/arm/mach-omap2/common-board-devices.h:
>     #include <linux/mfd/menelaus.h>
>     extern struct menelaus_platform_data n8x0_menelaus_platform_data;

As mentioned in the cover letter, this is one of the four drivers
that are only orphaned after the series I sent yesterday to remove
omap2 and other platforms.

>> diff --git a/drivers/mfd/menelaus.c b/drivers/mfd/menelaus.c
>> deleted file mode 100644
>> index a125d40fa121b..0000000000000
>> --- a/drivers/mfd/menelaus.c
>> +++ /dev/null
>> @@ -1,1251 +0,0 @@
>
> [Severity: Low]
> Should the reference to this file in MAINTAINERS also be removed?
>
> MAINTAINERS:
>     F: drivers/mfd/menelaus.c

This was accidentally removed in the omap2 patch, moving it to this
patch now.

> [ ... ]
>
>> diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
>> index ec73533703f72..9dfe1ea08c250 100644
>> --- a/drivers/rtc/Kconfig
>> +++ b/drivers/rtc/Kconfig
>> @@ -570,15 +570,6 @@ config RTC_DRV_BQ32K
>>  	  This driver can also be built as a module. If so, the module
>>  	  will be called rtc-bq32k.
>>  
>> -config RTC_DRV_TWL92330
>> -	bool "TI TWL92330/Menelaus"
>
> [Severity: Low]
> Does this leave an orphaned defconfig entry?
>
> arch/arm/configs/omap2plus_defconfig still references the removed config:
>
> arch/arm/configs/omap2plus_defconfig:
>     CONFIG_RTC_DRV_TWL92330=y

This is now removed in the omap2 removal patch as well.

      Arnd