From: Johan Jonker <jbx6244@gmail.com>
To: robh+dt@kernel.org
Cc: hjc@rock-chips.com, heiko@sntech.de, andy.yan@rock-chips.com,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
airlied@gmail.com, daniel@ffwll.ch,
maarten.lankhorst@linux.intel.com, tzimmermann@suse.de,
mripard@kernel.org, markyao0591@gmail.com,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 2/6] dt-bindings: display: rockchip,dw-hdmi: add power-domains property
Date: Wed, 31 Jan 2024 22:16:24 +0100 [thread overview]
Message-ID: <5c45527a-e218-40a3-8e71-a5815417e5f7@gmail.com> (raw)
In-Reply-To: <a493c65e-7cf9-455f-95d5-8c98cad35710@gmail.com>
Most Rockchip hdmi nodes are part of a power domain.
Add a power-domains property and include it to the example
with some reordering to align with the (new) documentation
about property ordering.
Signed-off-by: Johan Jonker <jbx6244@gmail.com>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
---
Changed V2:
keep reg-io-width together with reg
explain reordering
---
.../bindings/display/rockchip/rockchip,dw-hdmi.yaml | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml
index 391c2a7e79de..af638b6c0d21 100644
--- a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml
+++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml
@@ -94,6 +94,9 @@ properties:
- const: default
- const: unwedge
+ power-domains:
+ maxItems: 1
+
ports:
$ref: /schemas/graph.yaml#/properties/ports
@@ -138,16 +141,18 @@ examples:
#include <dt-bindings/clock/rk3288-cru.h>
#include <dt-bindings/interrupt-controller/arm-gic.h>
#include <dt-bindings/interrupt-controller/irq.h>
+ #include <dt-bindings/power/rk3288-power.h>
hdmi: hdmi@ff980000 {
compatible = "rockchip,rk3288-dw-hdmi";
reg = <0xff980000 0x20000>;
reg-io-width = <4>;
- ddc-i2c-bus = <&i2c5>;
- rockchip,grf = <&grf>;
interrupts = <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&cru PCLK_HDMI_CTRL>, <&cru SCLK_HDMI_HDCP>;
clock-names = "iahb", "isfr";
+ ddc-i2c-bus = <&i2c5>;
+ power-domains = <&power RK3288_PD_VIO>;
+ rockchip,grf = <&grf>;
ports {
#address-cells = <1>;
--
2.39.2
next prev parent reply other threads:[~2024-01-31 21:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 21:14 [PATCH v2 1/6] dt-bindings: display: rockchip: rockchip,dw-hdmi: remove port property Johan Jonker
2024-01-31 21:16 ` Johan Jonker [this message]
2024-01-31 21:16 ` [PATCH v2 3/6] ARM: dts: rockchip: fix rk3288 hdmi ports node Johan Jonker
2024-01-31 21:16 ` [PATCH v2 4/6] ARM: dts: rockchip: fix rk322x " Johan Jonker
2024-01-31 21:17 ` [PATCH v2 5/6] arm64: dts: rockchip: fix rk3328 " Johan Jonker
2024-01-31 21:17 ` [PATCH v2 6/6] arm64: dts: rockchip: fix rk3399 " Johan Jonker
2024-02-01 19:47 ` [PATCH v2 1/6] dt-bindings: display: rockchip: rockchip,dw-hdmi: remove port property Conor Dooley
2024-02-01 22:58 ` Rob Herring
2024-02-13 19:20 ` (subset) " Heiko Stuebner
2024-02-13 19:37 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c45527a-e218-40a3-8e71-a5815417e5f7@gmail.com \
--to=jbx6244@gmail.com \
--cc=airlied@gmail.com \
--cc=andy.yan@rock-chips.com \
--cc=conor+dt@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=markyao0591@gmail.com \
--cc=mripard@kernel.org \
--cc=robh+dt@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).