From: Florian Fainelli <f.fainelli@gmail.com>
To: Mike Looijmans <mike.looijmans@topic.nl>, devicetree@vger.kernel.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
davem@davemloft.net, robh+dt@kernel.org, mark.rutland@arm.com,
andrew@lunn.ch
Subject: Re: [PATCH] devicetree: net: micrel-ksz90x1.txt: Properly explain skew settings
Date: Thu, 6 Oct 2016 04:04:26 -0700 [thread overview]
Message-ID: <5c48a89f-3f2e-a74a-8e7b-a4b7397c2408@gmail.com> (raw)
In-Reply-To: <1475676188-10639-1-git-send-email-mike.looijmans@topic.nl>
On 10/05/2016 07:03 AM, Mike Looijmans wrote:
> The KSZ9031 skew registers contain an offset, the chip's default value
> is "neutral" which does not add any skew. Programming a 0 into a skew
> property will actually set it the maximal negative adjustment and not
> to a neutral position as one would expect.
>
> Explain this situation in the devicetree binding documentation and list
> the settings that the chip considers neutral.
>
> Changing the implementation to accept negative values would have been
> a better solution, but would break existing configurations.
>
> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Thanks!
--
Florian
next prev parent reply other threads:[~2016-10-06 11:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-05 14:03 [PATCH] devicetree: net: micrel-ksz90x1.txt: Properly explain skew settings Mike Looijmans
2016-10-06 11:04 ` Florian Fainelli [this message]
[not found] ` <1475676188-10639-1-git-send-email-mike.looijmans-Oq418RWZeHk@public.gmane.org>
2016-10-07 0:49 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c48a89f-3f2e-a74a-8e7b-a4b7397c2408@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mike.looijmans@topic.nl \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).