From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C60871CC163 for ; Fri, 6 Sep 2024 12:19:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725625149; cv=none; b=e54xwSLXZEO7/RHH9dcQd+gbJZCV0icZWN7aJSbKRpUpdqLj/k2jK5zxoz/stejYEvVbpwZ+043A2ghUQQUcM0cfSEELvXUnfkaa5fq6mP1POxSbceacfxoLuYx+p1Tf8SCTC0RgsKNu09pzeGu8HSeG+O+uWyzJBMgj+ibY448= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725625149; c=relaxed/simple; bh=HqOSDRzaUnhGRLIxiVCdBa6LDvnvu4v5GyRQUYJsm/U=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LoXtVoyfYZGvfXphqFEVHWQqVWiNtWAdHu18IkDuG9OdFg7MxpJrMTVBR/Dsm1AtIdPVVQjDf7xdW/hpj1QO2bJaxu48KwamPzI7l6FrZiJznyZP+UyQHbXCdeZ7NodvjgQCmpoz+mJ0tjEz5+hNgQ43daSQO1xJj4IVR8lwnT4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=vs9z3/VQ; arc=none smtp.client-ip=209.85.167.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="vs9z3/VQ" Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-53659867cbdso862013e87.3 for ; Fri, 06 Sep 2024 05:19:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1725625146; x=1726229946; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=qZnagyoqEY/AkJWYldk9pxOfEXujNgZibP5iAapvYX0=; b=vs9z3/VQWSG+WBTY9jfLRmKAy1vxB3i/pq/dugye5DTrHoHdP8afzUbnF/7nVdGPtG 4FQT6T4TQ+U7cXqUalUxnk0K5u63OWwvIH9eTjxteO9O059pGtfCae0iG3P9M6KCb2EH LBdhxyPkxRmcK3aak/g3Sxu9yGuSiJQN9Kgo1EwMuD+Lu+FoZDBp58q4u/p2fqgRGTCK vBTyUaiWP6X804KARU8LiOpw4GFnb61ikgVK1FDT7w/JHviwDktHCiLjOVpv2TrIo0aa PfgUWc99xTIo/ffMZbdCpu6Ry49ouGD9hinnG9Xj2Ia4DoBLtQuo366Tkg1tFxwIM1ma 22sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725625146; x=1726229946; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qZnagyoqEY/AkJWYldk9pxOfEXujNgZibP5iAapvYX0=; b=baquz1Op0Aa+xtdMa9kW0FT25IGIJWrcIp6Cvjfu/1Y+2aDG1Gd3/xoGmhApJeAtRv dnWMhFN8ISQObt9I9lXI09G7wfYvxpZTugmiylpRdAGnphPxAspfwS4B1C+ijloCuyYa xtIWezCPcqdcgvKbZKzEWSO+bL/uR8Hu8Q7vJ1Soc1gh2v3D4xppe8s6s7crLgJ42uG0 gK/Ekb716lgrwMDq8NCRwnOcf+3bWsBB8284BmY3/Xu9FoaClnCpr3/UL9cUzvDDQ1Lk FAEKzJaJ2SN9jXBHuGwwIwXRyYPLCR4Ww3K6FKgQ61A4zjdvkJ9vqrq10FMOatGmHzc4 VoBg== X-Forwarded-Encrypted: i=1; AJvYcCVfnR3GYIy9AaxDcuUiv47c916VO6/WglTLCTCOj0sRWT+KnzvPlhzAUNALSQqGN6dEzPKjodSutOT3@vger.kernel.org X-Gm-Message-State: AOJu0YwVPoHNGE2LaJhbTYTsgr0zGacmA8hEjvdAc/UUiCQvw04bYvDz T3B+3Q/S4TRg0zlgEulxxOuB5NKnNYbd9yHEOLK1BZSyrCuznQLS0/bdlJgB/Uk= X-Google-Smtp-Source: AGHT+IG74zIVOWX6bQluN94U4nrkIyRLMi3pWfBQY/TtSYoHYIc0SP1Bhu1/uDRSooGa/P5qsj690Q== X-Received: by 2002:a05:6512:3e02:b0:52e:9921:6dff with SMTP id 2adb3069b0e04-536587b54efmr2266960e87.26.1725625145620; Fri, 06 Sep 2024 05:19:05 -0700 (PDT) Received: from [192.168.0.25] ([176.61.106.227]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a8a83ed05c9sm117085866b.114.2024.09.06.05.19.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Sep 2024 05:19:05 -0700 (PDT) Message-ID: <5c58b41a-7fc7-456d-979c-edb8dbe4305d@linaro.org> Date: Fri, 6 Sep 2024 13:19:03 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 0/7] Add SDM670 camera subsystem To: Richard Acayan , Andi Shyti Cc: Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Loic Poulain , Robert Foss , Todor Tomov , Bryan O'Donoghue , Mauro Carvalho Chehab , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-i2c@vger.kernel.org, linux-media@vger.kernel.org, Vladimir Zapolskiy References: <20240904020448.52035-9-mailingradian@gmail.com> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 06/09/2024 03:36, Richard Acayan wrote: > On Thu, Sep 05, 2024 at 10:09:34PM +0200, Andi Shyti wrote: >> Hi Richard, >> >> On Tue, Sep 03, 2024 at 10:04:49PM GMT, Richard Acayan wrote: >>> This adds support for the camera subsystem on the Snapdragon 670. >>> >>> As of next-20240902, camss seems to be a bit broken, but the same series >>> works on stable (although it is much less reliable now that the CCI clock >>> frequency is not being assigned). >> >> I am not understanding this bit: is this series making it better >> or not? Can you please clarify what is broken, what is less >> reliable and what works? > > When applying this camss series and some camera sensor patches on > linux-next, the Pixel 3a seems to hang when camera capture starts. > > When applying the same patches on stable, the camera does not cause the > Pixel 3a to hang. Right so -next isn't stable that's not exactly a revelation. > When these device tree properties from the previous series were removed: > > assigned-clocks = <&camcc CAM_CC_CCI_CLK>; > assigned-clock-rates = <37500000>; > > the CCI would sometimes fail to probe with the error: Right, we don't have clk_set_rate in the cci driver. Maybe just leave the assigned clock for this submission and we can do a sweep of fixes to CCI at a later stage including setting the clock instead of having it be assigned. > > [ 51.572732] i2c-qcom-cci ac4a000.cci: deferred probe timeout, ignoring dependency > [ 51.572769] i2c-qcom-cci ac4a000.cci: probe with driver i2c-qcom-cci failed with error -110 > > On further testing, the rate can be set to 19.2 MHz, and there would be > no failure (or rather, it wouldn't happen often enough for me to witness > it). That's expected 19.2 and 37.5 MHz are supported by CAMCC for your part. --- bod