From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Tomer Maimon <tmaimon77@gmail.com>
Cc: avifishman70@gmail.com, tali.perry1@gmail.com, joel@jms.id.au,
venture@google.com, yuenn@google.com, benjaminfair@google.com,
arnd@arndb.de, hasegawa-hitomi@fujitsu.com, marcan@marcan.st,
nicolas.ferre@microchip.com, conor.dooley@microchip.com,
heiko@sntech.de, sven@svenpeter.dev, briannorris@chromium.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v1 1/2] dt-binding: soc: nuvoton: Add NPCM BPC LPC documentation
Date: Thu, 24 Nov 2022 17:18:31 +0100 [thread overview]
Message-ID: <5c7a06bf-94e3-5c65-f202-105f74a41d29@linaro.org> (raw)
In-Reply-To: <CAP6Zq1iGwqOVOnhmF0ijYw=KoTRJj5CUpFv6WDouZmjVxXhQ-g@mail.gmail.com>
On 24/11/2022 16:38, Tomer Maimon wrote:
> Hi Krzysztof,
>
> Thanks a lot for your comments.
>
> On Wed, 23 Nov 2022 at 12:03, Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> On 22/11/2022 21:12, Tomer Maimon wrote:
>>
>> 1. Subject: drop second, redundant "documentation" (dt-bindings are
>> documentation).
> O.K.
>>
>> 2. Use subject prefixes matching the subsystem (git log --oneline -- ...).
> this is what I did dt-binding: soc: nuvoton... do you mean dt-binding: nuvoton.
You didn't run the command, did you?
>>
>>> Added device tree binding documentation for Nuvoton BMC NPCM BIOS Post
>>> Code (BPC).
>>>
(...)
>>
>> No, only bus schemas could have it. Here additionalProperties: false.
>>
>> It seems there are already few LPC controllers and all are put in
>> different places:
>> Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml
>> Documentation/devicetree/bindings/arm/hisilicon/low-pin-count.yaml
>>
>> Maybe Rob why this was made not really as two bindings - for bus
>> controller and devices?
> As mention above, next patch I will describe only the BPC device.
>>
>> Best regards,
>> Krzysztof
>>
>
> In general, I waiting for Arnd approval for adding the NPCM BPC driver to SoC.
> After Arnd approval, I will send a new patch revision.
To be clear - bindings must be accepted (Reviewed or Acked) before
driver is.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-11-24 16:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-22 20:12 [PATCH v1 0/2] soc: add NPCM LPC BPC driver support Tomer Maimon
2022-11-22 20:12 ` [PATCH v1 1/2] dt-binding: soc: nuvoton: Add NPCM BPC LPC documentation Tomer Maimon
2022-11-23 10:03 ` Krzysztof Kozlowski
2022-11-24 15:38 ` Tomer Maimon
2022-11-24 16:18 ` Krzysztof Kozlowski [this message]
2022-11-29 16:44 ` Tomer Maimon
2022-11-30 8:27 ` Krzysztof Kozlowski
2022-11-30 10:31 ` Tomer Maimon
2022-11-30 19:30 ` Rob Herring
2022-11-22 20:12 ` [PATCH v1 2/2] soc: nuvoton: add NPCM LPC BPC driver Tomer Maimon
2022-11-23 10:57 ` Arnd Bergmann
2022-11-23 18:01 ` Tomer Maimon
2022-11-25 10:25 ` Arnd Bergmann
2022-11-29 18:20 ` Tomer Maimon
2022-11-25 2:27 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c7a06bf-94e3-5c65-f202-105f74a41d29@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=arnd@arndb.de \
--cc=avifishman70@gmail.com \
--cc=benjaminfair@google.com \
--cc=briannorris@chromium.org \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=hasegawa-hitomi@fujitsu.com \
--cc=heiko@sntech.de \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=nicolas.ferre@microchip.com \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
--cc=sven@svenpeter.dev \
--cc=tali.perry1@gmail.com \
--cc=tmaimon77@gmail.com \
--cc=venture@google.com \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).