From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Chunfeng Yun" <chunfeng.yun@mediatek.com>,
"Nícolas F. R. A. Prado" <nfraprado@collabora.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Matthias Brugger" <matthias.bgg@gmail.com>
Cc: AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
kernel@collabora.com,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: usb: mtk-xhci: Allow middle optional clocks to be missing
Date: Sun, 19 Jun 2022 13:49:04 +0200 [thread overview]
Message-ID: <5c7a1763-01fb-249d-a301-9164e2139ac6@linaro.org> (raw)
In-Reply-To: <d95e046262751a7f746fabc5f1d9a39e675730b3.camel@mediatek.com>
On 19/06/2022 09:40, Chunfeng Yun wrote:
> On Fri, 2022-06-17 at 18:29 -0400, Nícolas F. R. A. Prado wrote:
>> The current clock list in the binding doesn't allow for one of the
>> optional clocks to be missing and a subsequent clock to be present.
>> An
>> example where this is an issue is in mt8192.dtsi, which has "sys_ck",
>> "ref_ck", "xhci_ck" and would cause dtbs_check warnings.
> How about using fixed clock instead to fix the check warning?
> Using enum way seems make it more complex.
>
That would mean the clock is not actually optional. The DTS should
reflect the hardware so either you have the clock there or not. Either
it is an input or not. Of course there are some exceptions (like
non-controllable clock or regulator which not always has to be modeled).
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-06-19 11:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-17 22:29 [PATCH 0/3] Fixes for dtbs_check warnings on Mediatek XHCI nodes Nícolas F. R. A. Prado
2022-06-17 22:29 ` [PATCH 1/3] dt-bindings: usb: mtk-xhci: Allow wakeup interrupt-names to be optional Nícolas F. R. A. Prado
2022-06-18 1:30 ` Krzysztof Kozlowski
2022-06-19 7:47 ` Chunfeng Yun
2022-06-17 22:29 ` [PATCH 2/3] dt-bindings: usb: mtk-xhci: Allow middle optional clocks to be missing Nícolas F. R. A. Prado
2022-06-18 1:25 ` Krzysztof Kozlowski
2022-06-19 7:46 ` Chunfeng Yun
2022-06-19 12:05 ` Krzysztof Kozlowski
2022-06-20 6:59 ` Chunfeng Yun
2022-06-20 8:50 ` Krzysztof Kozlowski
2022-06-20 15:50 ` Nícolas F. R. A. Prado
2022-06-21 7:14 ` Krzysztof Kozlowski
2022-06-22 1:57 ` Chunfeng Yun
2022-06-22 6:10 ` Wenbin Mei
2022-06-22 13:22 ` Nícolas F. R. A. Prado
2022-06-19 7:40 ` Chunfeng Yun
2022-06-19 11:49 ` Krzysztof Kozlowski [this message]
2022-06-17 22:29 ` [PATCH 3/3] arm64: dts: mt8192: Follow clock order for XHCI Nícolas F. R. A. Prado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c7a1763-01fb-249d-a301-9164e2139ac6@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunfeng.yun@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=nfraprado@collabora.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).