From: Rob Herring <robh@kernel.org>
To: Chunfeng Yun <chunfeng.yun@mediatek.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Mark Rutland <mark.rutland@arm.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Adam Thomson <Adam.Thomson.Opensource@diasemi.com>,
Li Jun <jun.li@nxp.com>,
Badhri Jagan Sridharan <badhri@google.com>,
Hans de Goede <hdegoede@redhat.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Min Guo <min.guo@mediatek.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v2 1/6] dt-bindings: connector: add optional properties for Type-B
Date: Sun, 31 Mar 2019 01:40:28 -0500 [thread overview]
Message-ID: <5ca060de.1c69fb81.12138.c73c@mx.google.com> (raw)
In-Reply-To: <1552635513-2378-2-git-send-email-chunfeng.yun@mediatek.com>
On Fri, Mar 15, 2019 at 03:38:28PM +0800, Chunfeng Yun wrote:
> Add id-gpios, vbus-gpios, vbus-supply and pinctrl properties for
> usb-b-connector
>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> ---
> v2 changes:
> 1. describe more clear for vbus-gpios and vbus-supply suggested by Hans
> ---
> .../devicetree/bindings/connector/usb-connector.txt | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/connector/usb-connector.txt b/Documentation/devicetree/bindings/connector/usb-connector.txt
> index a9a2f2fc44f2..1c4ed6c9afa8 100644
> --- a/Documentation/devicetree/bindings/connector/usb-connector.txt
> +++ b/Documentation/devicetree/bindings/connector/usb-connector.txt
> @@ -17,6 +17,15 @@ Optional properties:
> - self-powered: Set this property if the usb device that has its own power
> source.
>
> +Optional properties for usb-b-connector:
> +- id-gpios: gpio for USB ID pin.
> +- vbus-gpios: gpio for USB VBUS pin, used to detect presence of VBUS 5V.
> + see gpio/gpio.txt.
Please make it explicit that this is an input gpio. An output GPIO
controlling a Vbus regulator should be modelled as a regulator.
> +- vbus-supply: a phandle to the regulator for USB VBUS if needed.
> +- pinctrl-names : a pinctrl state named "default" is optional
> +- pinctrl-0 : pin control group
> + see pinctrl/pinctrl-bindings.txt
> +
> Optional properties for usb-c-connector:
> - power-role: should be one of "source", "sink" or "dual"(DRP) if typec
> connector has power support.
> --
> 2.20.1
>
next prev parent reply other threads:[~2019-03-31 6:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-15 7:38 [PATCH v2 0/6] add USB Type-B GPIO based role switch driver Chunfeng Yun
2019-03-15 7:38 ` [PATCH v2 1/6] dt-bindings: connector: add optional properties for Type-B Chunfeng Yun
2019-03-31 6:40 ` Rob Herring [this message]
2019-03-31 12:45 ` Chunfeng Yun
2019-03-15 7:38 ` [PATCH v2 2/6] dt-bindings: usb: add binding for Type-B dual role switch by GPIO Chunfeng Yun
2019-03-15 7:52 ` Chunfeng Yun
2019-03-15 7:38 ` [PATCH v2 3/6] dt-bindings: usb: mtu3: add properties about USB Role Switch Chunfeng Yun
2019-03-15 7:38 ` [PATCH v2 4/6] usb: roles: add API to get usb_role_switch by node Chunfeng Yun
2019-03-15 8:18 ` Heikki Krogerus
2019-03-15 9:11 ` Heikki Krogerus
2019-03-15 9:14 ` Chunfeng Yun
2019-03-15 9:13 ` Chunfeng Yun
2019-03-15 9:26 ` Heikki Krogerus
2019-03-15 9:32 ` Chunfeng Yun
2019-03-15 10:34 ` Heikki Krogerus
2019-03-15 11:58 ` Heikki Krogerus
2019-03-15 7:38 ` [PATCH v2 5/6] usb: roles: add driver of USB Type-B role switch by GPIO Chunfeng Yun
2019-03-15 7:38 ` [PATCH v2 6/6] usb: mtu3: register a USB Role Switch for dual role mode Chunfeng Yun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ca060de.1c69fb81.12138.c73c@mx.google.com \
--to=robh@kernel.org \
--cc=Adam.Thomson.Opensource@diasemi.com \
--cc=andy.shevchenko@gmail.com \
--cc=badhri@google.com \
--cc=chunfeng.yun@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=jun.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=min.guo@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).