From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73648C77B75 for ; Wed, 17 May 2023 11:35:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229485AbjEQLfx (ORCPT ); Wed, 17 May 2023 07:35:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54844 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229484AbjEQLfx (ORCPT ); Wed, 17 May 2023 07:35:53 -0400 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B1F059D3; Wed, 17 May 2023 04:35:28 -0700 (PDT) Received: from kwepemm600004.china.huawei.com (unknown [172.30.72.53]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4QLrXB2BPkz18LWR; Wed, 17 May 2023 19:31:06 +0800 (CST) Received: from [10.67.103.231] (10.67.103.231) by kwepemm600004.china.huawei.com (7.193.23.242) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 17 May 2023 19:35:25 +0800 Message-ID: <5ca49494-5a0c-4dc8-9cf5-fc4bc3b8e1b2@huawei.com> Date: Wed, 17 May 2023 19:35:25 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH] soc: hisilicon: Support HCCS driver on Kunpeng SoC To: Sudeep Holla CC: Arnd Bergmann , Bjorn Andersson , Matthias Brugger , AngeloGioacchino Del Regno , Shawn Guo , , , , , , , , Len Brown , "Rafael J. Wysocki" , , Rob Herring , Frank Rowand , Krzysztof Kozlowski References: <20230425103040.znv66k364ant6klq@bogus> <20230425131918.5tf5vot4h7jf54xk@bogus> <20230515130807.pdvx7bxwjkfdsmsr@bogus> <20230516122931.il4ai7fyxdo5gsff@bogus> <20230516143530.venhj4gax6stinah@bogus> <20230517093033.4jvwjxuoeic46a24@bogus> From: "lihuisong (C)" In-Reply-To: <20230517093033.4jvwjxuoeic46a24@bogus> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.231] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemm600004.china.huawei.com (7.193.23.242) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org 在 2023/5/17 17:30, Sudeep Holla 写道: > On Wed, May 17, 2023 at 03:16:12PM +0800, lihuisong (C) wrote: > > [...] > >> No. I want to use this flag to make compability between different platforms. >> This driver only use PCC OpRegion to access to the channel if platform >> support use PCC OpRegion. > What do you mean by that ? It is not correct. If there is a PCC Opregion, > then you need to make it work with drivers/acpi/acpi_pcc.c > > You need to have all the other details in the firmware(ASL). By looking > at the driver, it has no connection to PCC Opregion IMO unless I am missing > something. Driver just needs to call these APIs, such as acpi_evaluate_integer(), if want to use PCC OpRegion. I know that. I have tested PCC OpRegion before. You've completely misunderstood what I said.😅 I mean that this driver plans to support both PCC and PCC OpRegion. For example, Platform A: this driver use PCC (as the current implementation) Platform B: this driver use PCC OpRegion (Currently, this patch does not implement it, but it may be available in the future.) Note: This driver selects only one of them (PCC and PCC OpRegion) to communicate with firmware on one platform. We use one bit in device-flags to know which one this driver will use. I'm not sure if you can understand what I mean by saing that. If you're not confused about this now, can you reply to my last email again?😁 >