From: Rob Herring <robh@kernel.org>
To: shubhrajyoti.datta@gmail.com
Cc: devicetree@vger.kernel.org, michal.simek@xilinx.com,
gregkh@linuxfoundation.org, jslaby@suse.com,
linux-serial@vger.kernel.org,
Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
Subject: Re: [PATCHv2 1/2] dt-bindings: xilinx-uartps: Add support for noctsrts
Date: Sat, 06 Apr 2019 01:06:26 -0500 [thread overview]
Message-ID: <5ca841e5.1c69fb81.87c5.289f@mx.google.com> (raw)
In-Reply-To: <1554181578-13362-2-git-send-email-shubhrajyoti.datta@gmail.com>
On Tue, Apr 02, 2019 at 10:36:17AM +0530, shubhrajyoti.datta@gmail.com wrote:
> From: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
>
> Vivado has a configurationo for selecting the flow control.
Vivado is ?
> Add a dt binding to check for the same.
>
> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
> ---
> Documentation/devicetree/bindings/serial/cdns,uart.txt | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/serial/cdns,uart.txt b/Documentation/devicetree/bindings/serial/cdns,uart.txt
> index 227bb77..5161a05 100644
> --- a/Documentation/devicetree/bindings/serial/cdns,uart.txt
> +++ b/Documentation/devicetree/bindings/serial/cdns,uart.txt
> @@ -12,6 +12,10 @@ Required properties:
> See ../clocks/clock-bindings.txt for details.
>
>
> +Optional properties:
> +- xlnx,nortscts: The presence of this property indicates that the
> + UART does not support modem lines for RTS/CTS hardware flow control.
We already have 'uart-has-rtscts'. Please use that. Maybe you need a new
compatible as I'd guess current users assume RTS/CTS is present.
> +
> Example:
> uart@e0000000 {
> compatible = "cdns,uart-r1p8";
> --
> 2.1.1
>
next prev parent reply other threads:[~2019-04-06 6:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-02 5:06 [PATCHv2 0/2] serial: uartps: Make flowcontrol configurable shubhrajyoti.datta
2019-04-02 5:06 ` [PATCHv2 1/2] dt-bindings: xilinx-uartps: Add support for noctsrts shubhrajyoti.datta
2019-04-06 6:06 ` Rob Herring [this message]
2019-04-08 3:26 ` Shubhrajyoti Datta
2019-04-08 18:36 ` Rob Herring
2020-09-10 5:56 ` Shubhrajyoti Datta
2019-04-02 5:06 ` [PATCHv2 2/2] serial: uartps: Add support for nortscts shubhrajyoti.datta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ca841e5.1c69fb81.87c5.289f@mx.google.com \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-serial@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=shubhrajyoti.datta@gmail.com \
--cc=shubhrajyoti.datta@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).