From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F910C83F11 for ; Mon, 28 Aug 2023 10:30:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231336AbjH1KaP (ORCPT ); Mon, 28 Aug 2023 06:30:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46268 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231415AbjH1K3z (ORCPT ); Mon, 28 Aug 2023 06:29:55 -0400 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1DE2712F for ; Mon, 28 Aug 2023 03:29:51 -0700 (PDT) Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-99cdb0fd093so391046966b.1 for ; Mon, 28 Aug 2023 03:29:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693218589; x=1693823389; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xgWbl8lPDl41Al6QpsrWevt2TQ1ACauu918bY4j1z+s=; b=bb/1I8Sm+ca97kh3b6g55IZcyB3k/N69Wdcm6OZ5O2Yp8H5f9FhmL3lg+5jbnGhVbl /aTvMBwbieOYKlVj7VqcD2DYvC/Sb2uwGOy52Nm81n7mWyAGe8wXxPHQY9cU7hRPbIgZ IpSm/Fi+TSeUmBhFZyp6CFHKrjsAFb2MENhkXo9LmULlSXI5J7+G+/sCvPC5ghCRTq49 5w1GsbIl2CSHsNuFWTlUHtPXfRQMtfWXjbtOaG+rurF3wcLeDJkr8L8/hNiF7qn6jLGU UVguUParRgO9JTc5Q9oAlvTZABJDhe+0Zu7M99q2cf4ckB/byeUUkDUQc4R8SQ8TUlaL u/xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693218589; x=1693823389; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xgWbl8lPDl41Al6QpsrWevt2TQ1ACauu918bY4j1z+s=; b=DHNgDlRJ6eKoVTUIwxdPEIFV17Uc+iECtx66rjRlejhPC1DNaXBUtHIskAwHB40m+G 0cmpzJ7/DnOOeZP5jgUC/HZXoZ9es/JnQyElKA2H3ccIZ1GjhJpDpho1Wzc5UIxYqXUs BZnbHpOVEIshyV2yxoXmx6ORI0CSxSaC7U04Q+fht/DicB/Ousi3oTu39j7kP1CnaDoj rNisJWV30HxT2eO+o86AGnIExbZJg8oiOG6sK7bgiEGlCMTSQXOBNT9VL3+lRjvN4Lrm nT0f30qOc/PqvZhnSz+HFGjjIU5ro8HMY9908SieHK1KxOJwVXAfIp+K/R4wKAw9pQ1W vVvQ== X-Gm-Message-State: AOJu0YybHL32RtSjMbbpH7+fDVnPQ4Q7kQ4jnViETSb0XCQUYIHwq3+2 AZy9Ur6nfLd+iggLyEsHq1wvAQ== X-Google-Smtp-Source: AGHT+IEvflAPEhQk9eVSwuVE3hLZKV3uv9/1Nn0BRVXbRA8n/i3Y6qZDfP5ehGeIoJ4+m69+C2I4Ug== X-Received: by 2002:a17:907:7897:b0:993:f15f:efb7 with SMTP id ku23-20020a170907789700b00993f15fefb7mr19814166ejc.8.1693218589623; Mon, 28 Aug 2023 03:29:49 -0700 (PDT) Received: from [192.168.0.22] ([77.252.47.225]) by smtp.gmail.com with ESMTPSA id e5-20020a170906044500b0099b8234a9fesm4462264eja.1.2023.08.28.03.29.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Aug 2023 03:29:49 -0700 (PDT) Message-ID: <5cb45ff4-a279-f47e-8d2f-700856cdff0f@linaro.org> Date: Mon, 28 Aug 2023 12:29:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH 1/2] ARM: dts: qcom: sdx65: correct PCIe EP phy-names Content-Language: en-US To: Konrad Dybcio , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230827114519.48797-1-krzysztof.kozlowski@linaro.org> <1c2faca3-d10c-429e-961d-447ae076d319@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <1c2faca3-d10c-429e-961d-447ae076d319@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 28/08/2023 11:53, Konrad Dybcio wrote: > On 27.08.2023 13:45, Krzysztof Kozlowski wrote: >> Qualcomm PCIe endpoint bindings expect phy-names to be "pciephy": >> >> arch/arm/boot/dts/qcom/qcom-sdx65-mtp.dtb: pcie-ep@1c00000: phy-names:0: 'pciephy' was expected >> >> Signed-off-by: Krzysztof Kozlowski >> --- > drivers/pci/controller/dwc/pcie-qcom-ep.c > 549: pcie_ep->phy = devm_phy_optional_get(dev, "pciephy"); > > welp looks like this never worked.. And if only it could have been spotted with some automated tooling, before posting to LKML... > > > Fixes: 9c0bb38414a4 ("ARM: dts: qcom: sdx65: Add support for PCIe EP") > Reviewed-by: Konrad Dybcio Thanks Best regards, Krzysztof