From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Raymond Hackley <raymondhackley@protonmail.com>,
open list <linux-kernel@vger.kernel.org>
Cc: Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Luca Weiss <luca@z3ntu.xyz>,
"open list : LED SUBSYSTEM" <linux-leds@vger.kernel.org>,
"open list : OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [RESEND PATCH 1/2] dt-bindings: leds: sgm3140: Document richtek,rt5033 compatible
Date: Sun, 4 Jun 2023 12:43:09 +0200 [thread overview]
Message-ID: <5cb59a5e-0ce5-7215-a14a-2ca2c1505b53@linaro.org> (raw)
In-Reply-To: <20230602133714.260556-1-raymondhackley@protonmail.com>
On 02/06/2023 15:38, Raymond Hackley wrote:
> Add devicetree binding for Richtek RT5033 Flash LED charge pump used for
> camera flash LEDs.
What are the similarities? Same register interface? Same pins? It's not
obvious and your commit should clear explain this. It will be also
justification why you did not make devices compatible.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-06-04 10:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-02 13:36 [RESEND PATCH 0/2] leds: sgm3140: Add richtek,rt5033-led compatible Raymond Hackley
2023-06-02 13:38 ` [RESEND PATCH 1/2] dt-bindings: leds: sgm3140: Document richtek,rt5033 compatible Raymond Hackley
2023-06-04 10:43 ` Krzysztof Kozlowski [this message]
2023-06-21 17:56 ` Raymond Hackley
2023-06-08 12:46 ` Lee Jones
2023-06-02 13:38 ` [RESEND PATCH 2/2] leds: sgm3140: Add richtek,rt5033-led compatible Raymond Hackley
2023-06-03 8:25 ` [RESEND PATCH 0/2] " Luca Weiss
[not found] <20230602130644.259933-1-raymondhackley@protonmail.com>
2023-06-02 13:11 ` [PATCH 1/2] dt-bindings: leds: sgm3140: Document richtek,rt5033 compatible Raymond Hackley
2023-06-21 15:01 ` Lee Jones
2023-06-21 17:56 ` [RESEND PATCH " Raymond Hackley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5cb59a5e-0ce5-7215-a14a-2ca2c1505b53@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=luca@z3ntu.xyz \
--cc=pavel@ucw.cz \
--cc=raymondhackley@protonmail.com \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).