Re: [PATCH v5 1/4] dt-bindings: rtc: Document NVIDIA VRS RTC

[Shubhi Garg <shgarg@nvidia.com>]

On 25/07/25 7:09 pm, Shubhi Garg wrote:
> 
> On 24/07/25 4:20 pm, Jon Hunter wrote:
>>
>> On 24/07/2025 11:06, Krzysztof Kozlowski wrote:
>>> On 24/07/2025 11:41, Jon Hunter wrote:
>>>>
>>>> On 24/07/2025 08:59, Krzysztof Kozlowski wrote:
>>>>> On Wed, Jul 23, 2025 at 01:03:40PM +0000, Shubhi Garg wrote:
>>>>>> +description:
>>>>>> +  NVIDIA VRS (Voltage Regulator Specification) RTC provides 32kHz 
>>>>>> RTC clock
>>>>>> +  support with backup battery for system timing. It provides 
>>>>>> alarm functionality
>>>>>> +  to wake system from suspend and shutdown state. The device also 
>>>>>> acts as an
>>>>>> +  interrupt controller for managing interrupts from the VRS.
>>>>>> +
>>>>>> +properties:
>>>>>> +  compatible:
>>>>>> +    const: nvidia,vrs10-rtc
>>>>>
>>>>> Nothing improved. You never replied to comments and then replaced one
>>>>> redundant word into other redundant word.
>>>>>
>>>>> Respond to review or implement it fully, not partially.
>>>>>
>>>>> Or add COMPLETE bindings, not partial ones. See writing bindings doc.
>>>>
>>>> OK, right so the DT binding should describe the overall PMIC device,
>>>> even though the driver needs to support the RTC.
> VRS-10 is the device name. VRS-10 has an I2C interface and implements a 
> Power Sequencer,
> RTC , 32kHZ clock output. From software perspective, we are handling 
> VRS-10 interrupts and
> providing RTC driver support. I will add complete VRS-10 information in 
> bindings.

VRS-10 hardware specifications are completely designed by NVIDIA.
NVIDIA is getting chip manufactured by multiple vendors.
Therefore, part number and vendor ID varies on each NVIDIA platform 
revisions.
But, our software is independent of vendor details.
So, is it okay to keep compatible string as "nvidia, vrs-10" in VRS-10 
RTC driver ?


-- 
Regards,
Shubhi