[PATCH 0/5] dt-bindings: arm: rockchip: Improve descriptions of Radxa boards

[PATCH 0/5] dt-bindings: arm: rockchip: Improve descriptions of Radxa boards

[FUKAUMI Naoki]

This patch series provides the following improvements:

- Fix board names.
- Reorder descriptions into a (mostly) alphanumeric order.

It also adds descriptions for the following board:

- Radxa ROCK 5 ITX+

FUKAUMI Naoki (5):
  dt-bindings: arm: rockchip: Fix description for Radxa Rock2 Square
  dt-bindings: arm: rockchip: Fix description for Radxa ZERO 3E/3W
  dt-bindings: arm: rockchip: Fix description for Radxa CM3I
  dt-bindings: arm: rockchip: Reorder the Radxa board entries
  dt-bindings: arm: rockchip: Add Radxa ROCK 5 ITX+

 .../devicetree/bindings/arm/rockchip.yaml     | 118 +++++++++---------
 1 file changed, 59 insertions(+), 59 deletions(-)

-- 
2.43.0

[PATCH 1/5] dt-bindings: arm: rockchip: Fix description for Radxa Rock2 Square

[FUKAUMI Naoki]

The name 'Rock 2' is incorrect; 'Rock2' is correct. Fix this.

Fixes: d78084cdb5a95 ("dt-bindings: arm: rockchip: Correct the descriptions for Radxa boards")
Link: https://wiki.radxa.com/Rock2
Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
---
 Documentation/devicetree/bindings/arm/rockchip.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
index ba61ea7436132..6ef377e66b1fb 100644
--- a/Documentation/devicetree/bindings/arm/rockchip.yaml
+++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
@@ -973,7 +973,7 @@ properties:
           - const: radxa,rockpis
           - const: rockchip,rk3308
 
-      - description: Radxa Rock 2 Square
+      - description: Radxa Rock2 Square
         items:
           - const: radxa,rock2-square
           - const: rockchip,rk3288
-- 
2.43.0

[PATCH 2/5] dt-bindings: arm: rockchip: Fix description for Radxa ZERO 3E/3W

[FUKAUMI Naoki]

"3E" precedes "3W" in alphanumeric order. Fix this.

Fixes: ad986e45ada99 ("dt-bindings: arm: rockchip: Add Radxa ZERO 3W/3E")
Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
---
 Documentation/devicetree/bindings/arm/rockchip.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
index 6ef377e66b1fb..15153e08d3881 100644
--- a/Documentation/devicetree/bindings/arm/rockchip.yaml
+++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
@@ -1028,7 +1028,7 @@ properties:
           - const: radxa,rock-5t
           - const: rockchip,rk3588
 
-      - description: Radxa ZERO 3W/3E
+      - description: Radxa ZERO 3E/3W
         items:
           - enum:
               - radxa,zero-3e
-- 
2.43.0

[PATCH 3/5] dt-bindings: arm: rockchip: Fix description for Radxa CM3I

[FUKAUMI Naoki]

"CM3I" is the preferred name.

Fixes: ae9fbe0b1f965 ("dt-bindings: arm: rockchip: add Radxa CM3I E25")
Link: https://dl.radxa.com/cm3i/docs/hw/radxa_cm3i_product_brief.pdf
Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
---
 Documentation/devicetree/bindings/arm/rockchip.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
index 15153e08d3881..70be7966f4d3e 100644
--- a/Documentation/devicetree/bindings/arm/rockchip.yaml
+++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
@@ -895,7 +895,7 @@ properties:
           - const: radxa,cm3
           - const: rockchip,rk3566
 
-      - description: Radxa CM3 Industrial
+      - description: Radxa CM3I
         items:
           - enum:
               - radxa,e25
-- 
2.43.0

[PATCH 4/5] dt-bindings: arm: rockchip: Reorder the Radxa board entries

[FUKAUMI Naoki]

Reorder the Radxa board entries alphanumerically, with the following
exceptions:

- Place "Rock2 Square" immediately after "Rock".
- Place "ROCK Pi N10" immediately after "ROCK Pi N8".
- Treat "Compute Module 3" as "CM3" for sorting purposes.

Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
---
 .../devicetree/bindings/arm/rockchip.yaml     | 112 +++++++++---------
 1 file changed, 56 insertions(+), 56 deletions(-)

diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
index 70be7966f4d3e..eef2b8061101b 100644
--- a/Documentation/devicetree/bindings/arm/rockchip.yaml
+++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
@@ -918,6 +918,11 @@ properties:
           - const: radxa,rock
           - const: rockchip,rk3188
 
+      - description: Radxa Rock2 Square
+        items:
+          - const: radxa,rock2-square
+          - const: rockchip,rk3288
+
       - description: Radxa ROCK 2A/2F
         items:
           - enum:
@@ -925,16 +930,20 @@ properties:
               - radxa,rock-2f
           - const: rockchip,rk3528
 
-      - description: Radxa ROCK Pi 4A/A+/B/B+/C
+      - description: Radxa ROCK 3A
         items:
-          - enum:
-              - radxa,rockpi4a
-              - radxa,rockpi4a-plus
-              - radxa,rockpi4b
-              - radxa,rockpi4b-plus
-              - radxa,rockpi4c
-          - const: radxa,rockpi4
-          - const: rockchip,rk3399
+          - const: radxa,rock3a
+          - const: rockchip,rk3568
+
+      - description: Radxa ROCK 3B
+        items:
+          - const: radxa,rock-3b
+          - const: rockchip,rk3568
+
+      - description: Radxa ROCK 3C
+        items:
+          - const: radxa,rock-3c
+          - const: rockchip,rk3566
 
       - description: Radxa ROCK 4C+
         items:
@@ -951,48 +960,6 @@ properties:
           - const: radxa,rock-4se
           - const: rockchip,rk3399
 
-      - description: Radxa ROCK Pi E
-        items:
-          - const: radxa,rockpi-e
-          - const: rockchip,rk3328
-
-      - description: Radxa ROCK Pi N8
-        items:
-          - const: radxa,rockpi-n8
-          - const: vamrs,rk3288-vmarc-som
-          - const: rockchip,rk3288
-
-      - description: Radxa ROCK Pi N10
-        items:
-          - const: radxa,rockpi-n10
-          - const: vamrs,rk3399pro-vmarc-som
-          - const: rockchip,rk3399pro
-
-      - description: Radxa ROCK Pi S
-        items:
-          - const: radxa,rockpis
-          - const: rockchip,rk3308
-
-      - description: Radxa Rock2 Square
-        items:
-          - const: radxa,rock2-square
-          - const: rockchip,rk3288
-
-      - description: Radxa ROCK 3A
-        items:
-          - const: radxa,rock3a
-          - const: rockchip,rk3568
-
-      - description: Radxa ROCK 3B
-        items:
-          - const: radxa,rock-3b
-          - const: rockchip,rk3568
-
-      - description: Radxa ROCK 3C
-        items:
-          - const: radxa,rock-3c
-          - const: rockchip,rk3566
-
       - description: Radxa ROCK 5 ITX
         items:
           - const: radxa,rock-5-itx
@@ -1018,16 +985,49 @@ properties:
           - const: radxa,rock-5c
           - const: rockchip,rk3588s
 
-      - description: Radxa ROCK S0
-        items:
-          - const: radxa,rock-s0
-          - const: rockchip,rk3308
-
       - description: Radxa ROCK 5T
         items:
           - const: radxa,rock-5t
           - const: rockchip,rk3588
 
+      - description: Radxa ROCK Pi 4A/A+/B/B+/C
+        items:
+          - enum:
+              - radxa,rockpi4a
+              - radxa,rockpi4a-plus
+              - radxa,rockpi4b
+              - radxa,rockpi4b-plus
+              - radxa,rockpi4c
+          - const: radxa,rockpi4
+          - const: rockchip,rk3399
+
+      - description: Radxa ROCK Pi E
+        items:
+          - const: radxa,rockpi-e
+          - const: rockchip,rk3328
+
+      - description: Radxa ROCK Pi N8
+        items:
+          - const: radxa,rockpi-n8
+          - const: vamrs,rk3288-vmarc-som
+          - const: rockchip,rk3288
+
+      - description: Radxa ROCK Pi N10
+        items:
+          - const: radxa,rockpi-n10
+          - const: vamrs,rk3399pro-vmarc-som
+          - const: rockchip,rk3399pro
+
+      - description: Radxa ROCK Pi S
+        items:
+          - const: radxa,rockpis
+          - const: rockchip,rk3308
+
+      - description: Radxa ROCK S0
+        items:
+          - const: radxa,rock-s0
+          - const: rockchip,rk3308
+
       - description: Radxa ZERO 3E/3W
         items:
           - enum:
-- 
2.43.0

[PATCH 5/5] dt-bindings: arm: rockchip: Add Radxa ROCK 5 ITX+

[FUKAUMI Naoki]

The Radxa ROCK 5 ITX+ is equivalent to the Radxa ROCK 5 ITX at the DTS
level. Therefore, we'll simply append the "ITX+" to the existing entry
for the Radxa ROCK 5 ITX.

Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
---
 Documentation/devicetree/bindings/arm/rockchip.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
index eef2b8061101b..c51399470abea 100644
--- a/Documentation/devicetree/bindings/arm/rockchip.yaml
+++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
@@ -960,7 +960,7 @@ properties:
           - const: radxa,rock-4se
           - const: rockchip,rk3399
 
-      - description: Radxa ROCK 5 ITX
+      - description: Radxa ROCK 5 ITX/ITX+
         items:
           - const: radxa,rock-5-itx
           - const: rockchip,rk3588
-- 
2.43.0

Re: [PATCH 1/5] dt-bindings: arm: rockchip: Fix description for Radxa Rock2 Square

[Krzysztof Kozlowski]

On 27/10/2025 13:26, FUKAUMI Naoki wrote:
> The name 'Rock 2' is incorrect; 'Rock2' is correct. Fix this.
> 
> Fixes: d78084cdb5a95 ("dt-bindings: arm: rockchip: Correct the descriptions for Radxa boards")

That's not a bug, really. Please squash all the patches. These are
unimportant trivialities.


Best regards,
Krzysztof

Re: [PATCH 2/5] dt-bindings: arm: rockchip: Fix description for Radxa ZERO 3E/3W

[Krzysztof Kozlowski]

On 27/10/2025 13:26, FUKAUMI Naoki wrote:
> "3E" precedes "3W" in alphanumeric order. Fix this.
> 
> Fixes: ad986e45ada99 ("dt-bindings: arm: rockchip: Add Radxa ZERO 3W/3E")

Nothing to fix. Please invent some sort of bugs according to
non-existing rules.

Best regards,
Krzysztof

Re: [PATCH 3/5] dt-bindings: arm: rockchip: Fix description for Radxa CM3I

[Krzysztof Kozlowski]

On 27/10/2025 13:26, FUKAUMI Naoki wrote:
> "CM3I" is the preferred name.

According to whom? I would prefer previous, so for sure:

> 
> Fixes: ae9fbe0b1f965 ("dt-bindings: arm: rockchip: add Radxa CM3I E25")

is not true.


Best regards,
Krzysztof

Re: [PATCH 4/5] dt-bindings: arm: rockchip: Reorder the Radxa board entries

[Krzysztof Kozlowski]

On 27/10/2025 13:26, FUKAUMI Naoki wrote:
> Reorder the Radxa board entries alphanumerically, with the following
> exceptions:


Why? You must explain that in the commit. What sorting is being used by
this file? Why do you think your re-order matches that sorting rule?

Best regards,
Krzysztof

Re: [PATCH 5/5] dt-bindings: arm: rockchip: Add Radxa ROCK 5 ITX+

[Krzysztof Kozlowski]

On 27/10/2025 13:26, FUKAUMI Naoki wrote:
> The Radxa ROCK 5 ITX+ is equivalent to the Radxa ROCK 5 ITX at the DTS

No clue what you want to say here. Same board? Different board but
compatible (then patch is wrong)?

> level. Therefore, we'll simply append the "ITX+" to the existing entry
> for the Radxa ROCK 5 ITX.

Best regards,
Krzysztof

Re: [PATCH 3/5] dt-bindings: arm: rockchip: Fix description for Radxa CM3I

[FUKAUMI Naoki]

Hi Krzysztof,

On 10/28/25 04:07, Krzysztof Kozlowski wrote:
> On 27/10/2025 13:26, FUKAUMI Naoki wrote:
>> "CM3I" is the preferred name.
> 
> According to whom? I would prefer previous, so for sure:

Sorry, it should be:

"CM3I" is the correct name.

Link: https://dl.radxa.com/cm3i/docs/hw/radxa_cm3i_product_brief.pdf

Best regards,

--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.

>> Fixes: ae9fbe0b1f965 ("dt-bindings: arm: rockchip: add Radxa CM3I E25")
> 
> is not true.
> 
> 
> Best regards,
> Krzysztof
> 

Re: [PATCH 4/5] dt-bindings: arm: rockchip: Reorder the Radxa board entries

[FUKAUMI Naoki]

Hi Krzysztof,

On 10/28/25 04:08, Krzysztof Kozlowski wrote:
> On 27/10/2025 13:26, FUKAUMI Naoki wrote:
>> Reorder the Radxa board entries alphanumerically, with the following
>> exceptions:
> 
> 
> Why? You must explain that in the commit. What sorting is being used by
> this file? Why do you think your re-order matches that sorting rule?

I understand there is no rule, only your preference. Thanks.

Best regards,

--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.

> Best regards,
> Krzysztof
> 

Re: [PATCH 5/5] dt-bindings: arm: rockchip: Add Radxa ROCK 5 ITX+

[FUKAUMI Naoki]

Hi Krzysztof,

Thank you very much for your review.

On 10/28/25 04:09, Krzysztof Kozlowski wrote:
> On 27/10/2025 13:26, FUKAUMI Naoki wrote:
>> The Radxa ROCK 5 ITX+ is equivalent to the Radxa ROCK 5 ITX at the DTS
> 
> No clue what you want to say here. Same board? Different board but
> compatible (then patch is wrong)?

The ROCK 5 ITX+ is the ROCK 5 ITX rev.1.2. However, I noticed missing 
documentation regarding the ROCK 5 ITX+. Since I don't have evidence, 
I'm dropping this patch. (It's not an issue as it works without this patch.)

I found issues with this entire patch series, so I'm dropping the whole 
patch series.

Thanks.

Best regards,

--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.

>> level. Therefore, we'll simply append the "ITX+" to the existing entry
>> for the Radxa ROCK 5 ITX.
> 
> Best regards,
> Krzysztof
> 

Re: [PATCH 4/5] dt-bindings: arm: rockchip: Reorder the Radxa board entries

[Krzysztof Kozlowski]

On 27/10/2025 23:30, FUKAUMI Naoki wrote:
> Hi Krzysztof,
> 
> On 10/28/25 04:08, Krzysztof Kozlowski wrote:
>> On 27/10/2025 13:26, FUKAUMI Naoki wrote:
>>> Reorder the Radxa board entries alphanumerically, with the following
>>> exceptions:
>>
>>
>> Why? You must explain that in the commit. What sorting is being used by
>> this file? Why do you think your re-order matches that sorting rule?
> 
> I understand there is no rule, only your preference. Thanks.


Really there is no? Are you sure?

Best regards,
Krzysztof

Re: [PATCH 4/5] dt-bindings: arm: rockchip: Reorder the Radxa board entries

[FUKAUMI Naoki]

Hi Krzysztof,

On 10/28/25 16:26, Krzysztof Kozlowski wrote:
> On 27/10/2025 23:30, FUKAUMI Naoki wrote:
>> Hi Krzysztof,
>>
>> On 10/28/25 04:08, Krzysztof Kozlowski wrote:
>>> On 27/10/2025 13:26, FUKAUMI Naoki wrote:
>>>> Reorder the Radxa board entries alphanumerically, with the following
>>>> exceptions:
>>>
>>>
>>> Why? You must explain that in the commit. What sorting is being used by
>>> this file? Why do you think your re-order matches that sorting rule?
>>
>> I understand there is no rule, only your preference. Thanks.
> 
> 
> Really there is no? Are you sure?

Could you please tell me what sort of sorting is being used for this file?

Best regards,

--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.

> Best regards,
> Krzysztof
> 

Re: [PATCH 4/5] dt-bindings: arm: rockchip: Reorder the Radxa board entries

[Krzysztof Kozlowski]

On Tue, Oct 28, 2025 at 04:29:41PM +0900, FUKAUMI Naoki wrote:
> Hi Krzysztof,
> 
> On 10/28/25 16:26, Krzysztof Kozlowski wrote:
> > On 27/10/2025 23:30, FUKAUMI Naoki wrote:
> > > Hi Krzysztof,
> > > 
> > > On 10/28/25 04:08, Krzysztof Kozlowski wrote:
> > > > On 27/10/2025 13:26, FUKAUMI Naoki wrote:
> > > > > Reorder the Radxa board entries alphanumerically, with the following
> > > > > exceptions:
> > > > 
> > > > 
> > > > Why? You must explain that in the commit. What sorting is being used by
> > > > this file? Why do you think your re-order matches that sorting rule?
> > > 
> > > I understand there is no rule, only your preference. Thanks.
> > 
> > 
> > Really there is no? Are you sure?
> 
> Could you please tell me what sort of sorting is being used for this file?

I don't know. I am asking you, because if you re-sort something you
clearly must have know the sorting rule. Otherwise without knowing what
is current sorting rule, how can you be sure that you sort it correctly
instead of just making a mess more messy?

Best regards,
Krzysztof

Re: [PATCH 4/5] dt-bindings: arm: rockchip: Reorder the Radxa board entries

[FUKAUMI Naoki]

Hi Krzysztof,

On 10/28/25 17:57, Krzysztof Kozlowski wrote:
> On Tue, Oct 28, 2025 at 04:29:41PM +0900, FUKAUMI Naoki wrote:
>> Hi Krzysztof,
>>
>> On 10/28/25 16:26, Krzysztof Kozlowski wrote:
>>> On 27/10/2025 23:30, FUKAUMI Naoki wrote:
>>>> Hi Krzysztof,
>>>>
>>>> On 10/28/25 04:08, Krzysztof Kozlowski wrote:
>>>>> On 27/10/2025 13:26, FUKAUMI Naoki wrote:
>>>>>> Reorder the Radxa board entries alphanumerically, with the following
>>>>>> exceptions:
>>>>>
>>>>>
>>>>> Why? You must explain that in the commit. What sorting is being used by
>>>>> this file? Why do you think your re-order matches that sorting rule?
>>>>
>>>> I understand there is no rule, only your preference. Thanks.
>>>
>>>
>>> Really there is no? Are you sure?
>>
>> Could you please tell me what sort of sorting is being used for this file?
> 
> I don't know. I am asking you, because if you re-sort something you
> clearly must have know the sorting rule. Otherwise without knowing what
> is current sorting rule, how can you be sure that you sort it correctly
> instead of just making a mess more messy?

If you don't know, how can you be sure my sorting is just making a mess 
more messy?

I'm going to add a new board (Radxa CM5) to this file. First, could you 
tell me where I should add it? Second, could you please tell me why 
that's the correct place?

Best regards,

--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.

> Best regards,
> Krzysztof
> 
>