From: Judith Mendez <jm@ti.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jirislaby@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Nishanth Menon <nm@ti.com>,
Santosh Shilimkar <ssantosh@kernel.org>,
Vignesh Raghavendra <vigneshr@ti.com>,
Tero Kristo <kristo@kernel.org>, Bin Liu <b-liu@ti.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Andrew Davis <afd@ti.com>, <linux-kernel@vger.kernel.org>,
<linux-serial@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 3/7] serial: 8250: Add PRUSS UART driver
Date: Fri, 16 May 2025 17:36:02 -0500 [thread overview]
Message-ID: <5cede33c-664c-488a-aef7-4619368c24d6@ti.com> (raw)
In-Reply-To: <2025051408-discolor-backwash-5574@gregkh>
Hi Greg,
On 5/14/25 2:36 AM, Greg Kroah-Hartman wrote:
> On Tue, May 13, 2025 at 04:59:30PM -0500, Judith Mendez wrote:
>> From: Bin Liu <b-liu@ti.com>
>>
>> This adds a new serial 8250 driver that supports the UART in PRUSS or
>> PRU_ICSS*.
>>
>> The UART sub-module is based on the industry standard TL16C550 UART
>> controller, which has 16-bytes FIFO and supports 16x and 13x over
>> samplings.
>
> If it is based on an existing controller, why do we need a new driver
> for this? Please explain in detail why this code is needed at all, and
> not just a new "quirk" for the existing driver?
This was explained in RFC [0] but the patch description can be improved
so will fix for v2.
[0] https://lore.kernel.org/all/ba88a5c0-a8b8-4e48-9752-76881fa8e94e@ti.com/
Thanks
~ Judith
next prev parent reply other threads:[~2025-05-16 22:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-13 21:59 [PATCH 0/7] Introduce PRU UART driver Judith Mendez
2025-05-13 21:59 ` [PATCH 1/7] dt-bindings: serial: add binding documentation for TI PRUSS UART Judith Mendez
2025-05-14 12:33 ` Krzysztof Kozlowski
2025-05-13 21:59 ` [PATCH 2/7] dt-bindings: soc: ti: pruss: Add documentation for PRU UART support Judith Mendez
2025-05-14 12:35 ` Krzysztof Kozlowski
2025-05-16 22:33 ` Judith Mendez
2025-05-13 21:59 ` [PATCH 3/7] serial: 8250: Add PRUSS UART driver Judith Mendez
2025-05-14 7:36 ` Greg Kroah-Hartman
2025-05-16 22:36 ` Judith Mendez [this message]
2025-05-14 12:21 ` Andy Shevchenko
2025-05-13 21:59 ` [PATCH 4/7] DONOTMERGE: arm64: dts: ti: k3-am64-main: Add PRU UART nodes Judith Mendez
2025-05-13 21:59 ` [PATCH 5/7] DONOTMERGE: arm64: dts: ti: k3-am642-sk: Enable PRU UART Judith Mendez
2025-05-13 21:59 ` [PATCH 6/7] DONOTMERGE: arm64: dts: ti: k3-am62-main: Add PRU UART node Judith Mendez
2025-05-13 21:59 ` [PATCH 7/7] DONOTMERGE: arm64: dts: ti: k3-am62x-sk: Enable PRU UART Judith Mendez
2025-05-14 7:35 ` [PATCH 0/7] Introduce PRU UART driver Greg Kroah-Hartman
2025-05-14 12:30 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5cede33c-664c-488a-aef7-4619368c24d6@ti.com \
--to=jm@ti.com \
--cc=afd@ti.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=b-liu@ti.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=kristo@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh@kernel.org \
--cc=ssantosh@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).