From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 86CB52BE641 for ; Mon, 24 Nov 2025 17:08:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764004097; cv=none; b=hE3DWelC+CZIPE98xA7M2MCGYyi4XTdAmCthN0veyMAaz5m/cwVZE+rAjGdFwQMl6IaZk4EdZ4LqAjo3rmexPOYpfmOzbqG036JFEnhWr7Jp9VivGnl4QFy/1BdU/DVqaix91kiid7wfjlQ9VRC9uw0w8TjQEBARj23I6MqS1jQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764004097; c=relaxed/simple; bh=U6A+dJ20pXp86qjZBRsjEm03OXYUbqKULhGIn2BanqU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iwYo5jiXFeIztm5PxcnWCJ4qyVWdJk+2vepg3dtjh/j+KeDf0Hh96tRS8PVILkvI7mbbTmzDK/2TaGSyN2SnW8to0OtGfk3PbZz708AJlhEVHL1ShwupfsW+sVftgkUhHaJtB70gCpPJlgjCTkxJXMGshF52b0HuKdEKRzhzKsc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Q7/gZ4Bj; arc=none smtp.client-ip=209.85.218.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Q7/gZ4Bj" Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-b739ef3f739so281561966b.1 for ; Mon, 24 Nov 2025 09:08:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764004094; x=1764608894; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gMEOFKOu3v4GJbo9FdKNZBfHGx8q7d1+trMyWhqy/A8=; b=Q7/gZ4BjvyjEip0iDrgEG8xaI4vE+sedpVMKPWOyxA+U24xaz1SLA6bkgUEThE8Kzi yia9JIs6KLI614C+CoJRN3LDLRNdLa44mKgFy8yBpKroAYSC+9/61TDEsWzCqtpycpsD 4apPqpLTZKVuRYGEHF/zA/l/oisYI8lMVZrvezuAmF4BCqDHC9kJCPoPPQQ4IdvyZL3g m8+LFxYNHPiIayNJVcjcnMqc5/6wSag2Q/J5aLyVAyU2h/hFZxYMiVNJM9v+3o0nYhp0 aqqfH21PfE+L5bPlX63L5InbY4Q+W+x9TmcvEsrtioP0P3pKFnWnYRf0l3APMEFz1NWn /2eA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764004094; x=1764608894; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gMEOFKOu3v4GJbo9FdKNZBfHGx8q7d1+trMyWhqy/A8=; b=md5G0cIgQeq+e5BqO/VxfpnKna+EPzcSGpS2EdehemIs2R5rtGxA8WyDqxzIjo/rDl OT7t4ovr5FiN8jVFH9eo9v86c8Cjh8zM1mF3M3dFY8qxME+rjrkfPy8KjWumFENLHL3S NU1Rfg4tvS4U0mPnRm0XtJgKma5YGY/ua8bo7n2JQuNhuIZe9zRRZxDmKWTtFeBur/S1 L+ThV697Xpp44hXTY80NOPCvMx8jxavNfDRro3i8/oUVCAmREDjOEfugrwatr96agqJP T/n5vnZY8FhoeQdnwQYyQCX/zzi8w/BZ6k20A0afUocpeDqKlUViXz949m8KPjreZCG5 fC2g== X-Forwarded-Encrypted: i=1; AJvYcCXPMD3iBTU8mUrYNf2ahMBh1XSTRu26snYy2OkvbfOjk04le8xjXMTdiqb6yk02tc6OVjK1SbWTHtfi@vger.kernel.org X-Gm-Message-State: AOJu0Yzay+VDiQS8lrpg+KFl+2H10BpiL/wE9B1VTWUK9wD9i3iPyBit rWvkTxEvL7kxHZuuu0KpukEfssOQohxnh1bQfuvp4+CCQ42AaHOuEjO9Akx8FvEj X-Gm-Gg: ASbGncvASfZQQMdg0H9ZqN6ls0Hegt8huKYLbMSJB57KCswYpVMROriL4BZBWBhyO6v soOQKoAJ4JIs+dJcKuPopGFzCqhyGi+l6t5aQvZDNAJUVcIon2QuUdrz4ARyqOb2AbgoH7xYyZo Fhfuo9QxeHzy2IMMUeV6yWvy46I8JuFPHkkevFhJXhF7nDNjqvLgpC51j5sb7KhtuKv6FXBCh/Y ezZnqx5KBWalCZUCHnTwxrO3y10NXr1Upa0aMAgbKBZ65M0I3d/qX5v75v6mo3Yis8gxKBaiY2q j5lshJulf8NZXVLx1AQ958Ub/te+Vf2C755kY6q75pCO579A0JUVxeue8KFgqGWdwDmpJvo0E+W XM48AwEMGGwsGOA+bXgRM+ADGkvuWlxBB6koKGWgeDhe4Ghh9nUyOMlf9aBv3WZbOlWtev3LrZ8 fbuwT3HBG3j6JlUK0D0/u8jvR/doAtaKgY8jQVAEeZGp9Kkr/c+tYB4SY+CVbD3H4= X-Google-Smtp-Source: AGHT+IG13tPufOeCe62IkziqEjMKy77jRIw/n2p1+sO/PACFs+P5/tLtartbx+qzXMxnMkmQoCTh7g== X-Received: by 2002:a05:6512:39d5:b0:595:9152:b921 with SMTP id 2adb3069b0e04-596a3ea79camr4199632e87.7.1763996851410; Mon, 24 Nov 2025 07:07:31 -0800 (PST) Received: from ?IPV6:2001:14ba:437:c00::190? (2001-14ba-437-c00--190.rev.dnainternet.fi. [2001:14ba:437:c00::190]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-596a0d1493bsm3863273e87.73.2025.11.24.07.07.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Nov 2025 07:07:30 -0800 (PST) Message-ID: <5cf2a12a-7c66-4622-b4a9-14896c6df005@gmail.com> Date: Mon, 24 Nov 2025 17:07:28 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 01/29] Revert "treewide: Fix probing of devices in DT overlays" To: Rob Herring Cc: Herve Codina , Andrew Lunn , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Michael Turquette , Stephen Boyd , Andi Shyti , Wolfram Sang , Peter Rosin , Arnd Bergmann , Saravana Kannan , Bjorn Helgaas , Charles Keepax , Richard Fitzgerald , David Rhodes , Linus Walleij , Ulf Hansson , Mark Brown , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , Len Brown , Davidlohr Bueso , Jonathan Cameron , Dave Jiang , Alison Schofield , Vishal Verma , Ira Weiny , Dan Williams , Geert Uytterhoeven , Wolfram Sang , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-i2c@vger.kernel.org, linux-pci@vger.kernel.org, linux-sound@vger.kernel.org, patches@opensource.cirrus.com, linux-gpio@vger.kernel.org, linux-pm@vger.kernel.org, linux-spi@vger.kernel.org, linux-acpi@vger.kernel.org, linux-cxl@vger.kernel.org, Allan Nielsen , Horatiu Vultur , Steen Hegelund , Luca Ceresoli , Thomas Petazzoni , mazziesaccount@gmail.com References: <20251015071420.1173068-1-herve.codina@bootlin.com> <20251015071420.1173068-2-herve.codina@bootlin.com> Content-Language: en-US From: Kalle Niemi In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 11/24/25 16:53, Rob Herring wrote: > On Mon, Nov 24, 2025 at 8:48 AM Kalle Niemi wrote: >> On 10/15/25 10:13, Herve Codina wrote: >>> From: Saravana Kannan >>> >>> This reverts commit 1a50d9403fb90cbe4dea0ec9fd0351d2ecbd8924. >>> >>> While the commit fixed fw_devlink overlay handling for one case, it >>> broke it for another case. So revert it and redo the fix in a separate >>> patch. >>> >>> Fixes: 1a50d9403fb9 ("treewide: Fix probing of devices in DT overlays") >>> Reported-by: Herve Codina >>> Closes: https://lore.kernel.org/lkml/CAMuHMdXEnSD4rRJ-o90x4OprUacN_rJgyo8x6=9F9rZ+-KzjOg@mail.gmail.com/ >>> Closes: https://lore.kernel.org/all/20240221095137.616d2aaa@bootlin.com/ >>> Closes: https://lore.kernel.org/lkml/20240312151835.29ef62a0@bootlin.com/ >>> Signed-off-by: Saravana Kannan >>> Link: https://lore.kernel.org/lkml/20240411235623.1260061-2-saravanak@google.com/ >>> Signed-off-by: Herve Codina >>> Acked-by: Mark Brown >>> --- >>> drivers/bus/imx-weim.c | 6 ------ >>> drivers/i2c/i2c-core-of.c | 5 ----- >>> drivers/of/dynamic.c | 1 - >>> drivers/of/platform.c | 5 ----- >>> drivers/spi/spi.c | 5 ----- >>> 5 files changed, 22 deletions(-) >>> >>> diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c >>> index 83d623d97f5f..87070155b057 100644 >>> --- a/drivers/bus/imx-weim.c >>> +++ b/drivers/bus/imx-weim.c >>> @@ -327,12 +327,6 @@ static int of_weim_notify(struct notifier_block *nb, unsigned long action, >>> "Failed to setup timing for '%pOF'\n", rd->dn); >>> >>> if (!of_node_check_flag(rd->dn, OF_POPULATED)) { >>> - /* >>> - * Clear the flag before adding the device so that >>> - * fw_devlink doesn't skip adding consumers to this >>> - * device. >>> - */ >>> - rd->dn->fwnode.flags &= ~FWNODE_FLAG_NOT_DEVICE; >>> if (!of_platform_device_create(rd->dn, NULL, &pdev->dev)) { >>> dev_err(&pdev->dev, >>> "Failed to create child device '%pOF'\n", >>> diff --git a/drivers/i2c/i2c-core-of.c b/drivers/i2c/i2c-core-of.c >>> index eb7fb202355f..30b48a428c0b 100644 >>> --- a/drivers/i2c/i2c-core-of.c >>> +++ b/drivers/i2c/i2c-core-of.c >>> @@ -176,11 +176,6 @@ static int of_i2c_notify(struct notifier_block *nb, unsigned long action, >>> return NOTIFY_OK; >>> } >>> >>> - /* >>> - * Clear the flag before adding the device so that fw_devlink >>> - * doesn't skip adding consumers to this device. >>> - */ >>> - rd->dn->fwnode.flags &= ~FWNODE_FLAG_NOT_DEVICE; >>> client = of_i2c_register_device(adap, rd->dn); >>> if (IS_ERR(client)) { >>> dev_err(&adap->dev, "failed to create client for '%pOF'\n", >>> diff --git a/drivers/of/dynamic.c b/drivers/of/dynamic.c >>> index 2eaaddcb0ec4..b5be7484fb36 100644 >>> --- a/drivers/of/dynamic.c >>> +++ b/drivers/of/dynamic.c >>> @@ -225,7 +225,6 @@ static void __of_attach_node(struct device_node *np) >>> np->sibling = np->parent->child; >>> np->parent->child = np; >>> of_node_clear_flag(np, OF_DETACHED); >>> - np->fwnode.flags |= FWNODE_FLAG_NOT_DEVICE; >>> >>> raw_spin_unlock_irqrestore(&devtree_lock, flags); >>> >>> diff --git a/drivers/of/platform.c b/drivers/of/platform.c >>> index f77cb19973a5..ef9445ba168b 100644 >>> --- a/drivers/of/platform.c >>> +++ b/drivers/of/platform.c >>> @@ -739,11 +739,6 @@ static int of_platform_notify(struct notifier_block *nb, >>> if (of_node_check_flag(rd->dn, OF_POPULATED)) >>> return NOTIFY_OK; >>> >>> - /* >>> - * Clear the flag before adding the device so that fw_devlink >>> - * doesn't skip adding consumers to this device. >>> - */ >>> - rd->dn->fwnode.flags &= ~FWNODE_FLAG_NOT_DEVICE; >>> /* pdev_parent may be NULL when no bus platform device */ >>> pdev_parent = of_find_device_by_node(parent); >>> pdev = of_platform_device_create(rd->dn, NULL, >>> diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c >>> index 2e0647a06890..b22944a207c9 100644 >>> --- a/drivers/spi/spi.c >>> +++ b/drivers/spi/spi.c >>> @@ -4791,11 +4791,6 @@ static int of_spi_notify(struct notifier_block *nb, unsigned long action, >>> return NOTIFY_OK; >>> } >>> >>> - /* >>> - * Clear the flag before adding the device so that fw_devlink >>> - * doesn't skip adding consumers to this device. >>> - */ >>> - rd->dn->fwnode.flags &= ~FWNODE_FLAG_NOT_DEVICE; >>> spi = of_register_spi_device(ctlr, rd->dn); >>> put_device(&ctlr->dev); >>> >> Sorry, some of you will receive this message now for second time. First >> message was sent to older series of patches. >> - >> >> Hello, >> >> Test system testing drivers for ROHM ICs bisected this commit to cause >> BD71847 drivers probe to not be called. > This driver (and overlay support) is in linux-next or something out of > tree on top of linux-next? > > Rob Yes the driver is in mainline linux: /drivers/mfd/rohm-bd718x7.c Kalle