From: Krzysztof Kozlowski <krzk@kernel.org>
To: Ayushi Makhija <quic_amakhija@quicinc.com>,
linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: robdclark@gmail.com, dmitry.baryshkov@linaro.org,
sean@poorly.run, marijn.suijten@somainline.org,
andersson@kernel.org, robh@kernel.org, robh+dt@kernel.org,
krzk+dt@kernel.org, konradybcio@kernel.org, conor+dt@kernel.org,
andrzej.hajda@intel.com, neil.armstrong@linaro.org,
rfoss@kernel.org, Laurent.pinchart@ideasonboard.com,
jonas@kwiboo.se, jernej.skrabec@gmail.com,
quic_abhinavk@quicinc.com, quic_rajeevny@quicinc.com,
quic_vproddut@quicinc.com, quic_jesszhan@quicinc.com
Subject: Re: [PATCH v3 03/10] dt-bindings: display: msm: document DSI controller and phy on SA8775P
Date: Sat, 5 Apr 2025 09:48:47 +0200 [thread overview]
Message-ID: <5cfdb91e-54d3-4871-a09c-5ece37099b6a@kernel.org> (raw)
In-Reply-To: <20250404115539.1151201-4-quic_amakhija@quicinc.com>
On 04/04/2025 13:55, Ayushi Makhija wrote:
> Document DSI controller and phy on SA8775P platform.
>
> Signed-off-by: Ayushi Makhija <quic_amakhija@quicinc.com>
> ---
> .../display/msm/qcom,sa8775p-mdss.yaml | 183 +++++++++++++++++-
> 1 file changed, 182 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml
> index 5fac3e266703..1be26137b7b6 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml
> @@ -52,12 +52,25 @@ patternProperties:
> items:
> - const: qcom,sa8775p-dp
>
> + "^dsi@[0-9a-f]+$":
> + type: object
> + additionalProperties: true
> + properties:
> + compatible:
> + contains:
> + enum:
huh?
> + - qcom,sa8775p-dsi-ctrl
> + - qcom,mdss-dsi-ctrl
This makes no sense and I am pretty sure it breaks everything and was
not tested.
All previous comments apply.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-04-05 7:48 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-04 11:55 [PATCH v3 00/10] Add DSI display support for SA8775P target Ayushi Makhija
2025-04-04 11:55 ` [PATCH v3 01/10] dt-bindings: display: msm-dsi-phy-7nm: document the SA8775P DSI PHY Ayushi Makhija
2025-04-04 11:55 ` [PATCH v3 02/10] dt-bindings: msm: dsi-controller-main: document the SA8775P DSI CTRL Ayushi Makhija
2025-04-06 12:36 ` Krzysztof Kozlowski
2025-04-04 11:55 ` [PATCH v3 03/10] dt-bindings: display: msm: document DSI controller and phy on SA8775P Ayushi Makhija
2025-04-05 7:48 ` Krzysztof Kozlowski [this message]
2025-04-04 11:55 ` [PATCH v3 04/10] drm/msm/dsi: add DSI PHY configuration " Ayushi Makhija
2025-04-04 11:55 ` [PATCH v3 05/10] drm/msm/dsi: add DSI support for SA8775P Ayushi Makhija
2025-04-04 11:55 ` [PATCH v3 06/10] arm64: dts: qcom: sa8775p: add Display Serial Interface device nodes Ayushi Makhija
2025-04-04 22:27 ` Konrad Dybcio
2025-04-04 11:55 ` [PATCH v3 07/10] arm64: dts: qcom: sa8775p-ride: add anx7625 DSI to DP bridge nodes Ayushi Makhija
2025-04-04 22:39 ` Konrad Dybcio
2025-04-06 20:12 ` Dmitry Baryshkov
2025-04-10 5:04 ` Ayushi Makhija
2025-04-10 13:07 ` Ayushi Makhija
2025-04-10 20:01 ` Dmitry Baryshkov
2025-04-14 9:56 ` Ayushi Makhija
2025-04-14 10:05 ` Konrad Dybcio
2025-04-14 10:07 ` Dmitry Baryshkov
2025-04-14 13:54 ` Ayushi Makhija
2025-04-15 9:30 ` Dmitry Baryshkov
2025-04-15 9:52 ` Ayushi Makhija
2025-04-04 11:55 ` [PATCH v3 08/10] drm/bridge: anx7625: enable HPD interrupts Ayushi Makhija
2025-04-06 20:26 ` Dmitry Baryshkov
2025-04-04 11:55 ` [PATCH v3 09/10] drm/bridge: anx7625: update bridge_ops and sink detect logic Ayushi Makhija
2025-04-06 20:14 ` Dmitry Baryshkov
2025-04-04 11:55 ` [PATCH v3 10/10] drm/bridge: anx7625: change the gpiod_set_value API Ayushi Makhija
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5cfdb91e-54d3-4871-a09c-5ece37099b6a@kernel.org \
--to=krzk@kernel.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=andersson@kernel.org \
--cc=andrzej.hajda@intel.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_amakhija@quicinc.com \
--cc=quic_jesszhan@quicinc.com \
--cc=quic_rajeevny@quicinc.com \
--cc=quic_vproddut@quicinc.com \
--cc=rfoss@kernel.org \
--cc=robdclark@gmail.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox