* [PATCH v4] dt-bindings: iio: pressure: add invensense,icp10100
@ 2025-08-01 22:10 Rodrigo Gobbi
2025-08-02 8:25 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: Rodrigo Gobbi @ 2025-08-01 22:10 UTC (permalink / raw)
To: jic23, dlechner, nuno.sa, andy, conor+dt, krzk+dt,
jean-baptiste.maneyrol, robh
Cc: ~lkcamp/patches, linux-iio, linux-kernel, devicetree
There is no txt file for it, add yaml for invensense,icp10100
which is already used in the driver. Also, document other compatibles
for ICP-101xx family and add invensense,icp10100 as a fallback.
Acked-by: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com>
Signed-off-by: Rodrigo Gobbi <rodrigo.gobbi.7@gmail.com>
---
On 7/28/25 02:19, Krzysztof Kozlowski wrote:
> On Sun, Jul 27, 2025 at 09:32:02PM -0300, Rodrigo Gobbi wrote:
>> +properties:
>> + compatible:
>> + items:
>> + - enum:
>> + - invensense,icp10101
>> + - invensense,icp10110
>> + - invensense,icp10111
>> + - const: invensense,icp10100
>
> This does not allow using invensense,icp10100 alone. Try it yourself on
> DTS - you will see warnings.
>
> You need oneOf, just takek a peak at some random bindings.
>
> Best regards,
> Krzysztof
Tested against a dummy dtb/dtbs_check and with dt_binding_check,
looks ok now.
Tks and regards.
Changelog:
v4: allow the fallback to be used alone
v3: https://lore.kernel.org/all/20250728004039.8634-1-rodrigo.gobbi.7@gmail.com/
v2: https://lore.kernel.org/linux-devicetree/20250701221700.34921-1-rodrigo.gobbi.7@gmail.com/
v1: https://lore.kernel.org/all/20250626212742.7986-1-rodrigo.gobbi.7@gmail.com/
---
.../iio/pressure/invensense,icp10100.yaml | 52 +++++++++++++++++++
1 file changed, 52 insertions(+)
create mode 100644 Documentation/devicetree/bindings/iio/pressure/invensense,icp10100.yaml
diff --git a/Documentation/devicetree/bindings/iio/pressure/invensense,icp10100.yaml b/Documentation/devicetree/bindings/iio/pressure/invensense,icp10100.yaml
new file mode 100644
index 000000000000..5d980aa04bb3
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/pressure/invensense,icp10100.yaml
@@ -0,0 +1,52 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/pressure/invensense,icp10100.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: InvenSense ICP-101xx Barometric Pressure Sensors
+
+maintainers:
+ - Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com>
+
+description: |
+ Support for ICP-101xx family: ICP-10100, ICP-10101, ICP-10110, ICP-10111.
+ Those devices uses a simple I2C communication bus, measuring the pressure
+ in a ultra-low noise at the lowest power.
+ Datasheet: https://product.tdk.com/system/files/dam/doc/product/sensor/pressure/capacitive-pressure/data_sheet/ds-000186-icp-101xx.pdf
+
+properties:
+ compatible:
+ oneOf:
+ - items:
+ - enum:
+ - invensense,icp10101
+ - invensense,icp10110
+ - invensense,icp10111
+ - const: invensense,icp10100
+ - const: invensense,icp10100
+
+ reg:
+ maxItems: 1
+
+ vdd-supply: true
+
+required:
+ - compatible
+ - reg
+ - vdd-supply
+
+additionalProperties: false
+
+examples:
+ - |
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ pressure@63 {
+ compatible = "invensense,icp10101", "invensense,icp10100";
+ reg = <0x63>;
+ vdd-supply = <&vdd_1v8>;
+ };
+ };
+...
--
2.48.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v4] dt-bindings: iio: pressure: add invensense,icp10100
2025-08-01 22:10 [PATCH v4] dt-bindings: iio: pressure: add invensense,icp10100 Rodrigo Gobbi
@ 2025-08-02 8:25 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2025-08-02 8:25 UTC (permalink / raw)
To: Rodrigo Gobbi, jic23, dlechner, nuno.sa, andy, conor+dt, krzk+dt,
jean-baptiste.maneyrol, robh
Cc: ~lkcamp/patches, linux-iio, linux-kernel, devicetree
On 02/08/2025 00:10, Rodrigo Gobbi wrote:
> There is no txt file for it, add yaml for invensense,icp10100
> which is already used in the driver. Also, document other compatibles
> for ICP-101xx family and add invensense,icp10100 as a fallback.
>
> Acked-by: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com>
> Signed-off-by: Rodrigo Gobbi <rodrigo.gobbi.7@gmail.com>
> ---
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-08-02 8:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-01 22:10 [PATCH v4] dt-bindings: iio: pressure: add invensense,icp10100 Rodrigo Gobbi
2025-08-02 8:25 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).