From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99781C352A1 for ; Wed, 30 Nov 2022 11:41:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233626AbiK3Lli (ORCPT ); Wed, 30 Nov 2022 06:41:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34756 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235105AbiK3LlZ (ORCPT ); Wed, 30 Nov 2022 06:41:25 -0500 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4528445A3C for ; Wed, 30 Nov 2022 03:41:24 -0800 (PST) Received: by mail-lf1-x130.google.com with SMTP id f13so26488993lfa.6 for ; Wed, 30 Nov 2022 03:41:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=W6U4jWl0YX+0wZ2tHeX0Zdfl9CbnGOHdgFH3EJM7rvE=; b=VlImjinigFrpzpISnF2fFZhGjZfORwYmBSPGrKG8Iyq/GYCNHiT2/pDsj0vSKJSp6V yaFqXu3OfHPcv+gZw/obLuDGfRKhPBBPLs+XgaXaGhnmZassT2SrD/r8eaf0ulEYDyFA i04RjqnIiC69WjEjBxFITm9BFRpzERhzv8LTST+S5KAoOP2hPnqV6SBhNUySDKykgeUQ KywrvWOqeCm2oAME74l+9r0HFgB1e1WH2k9k4L2d3iT/uEO9mfbxbj9MV+f2C4xs+i/m MLv4qw8tNCxSJ/8YQXmwnmiN8luAmHVQZkvoWcCOVINe6BOL1Ti5p1JVXLQw0j6szXKz K/XQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=W6U4jWl0YX+0wZ2tHeX0Zdfl9CbnGOHdgFH3EJM7rvE=; b=nnwTvhRp7DOawoh5RqCMzLpJiyaXrsuNwq68vNUBVLmZg8SO8+3hsMeozg3QgGim1h ytT8rQ+vHUChjKmbJUitmT4XiZ0BdqvdyfsAwnWAMjsW7Ms/C1GS91gmqggi6hFn03/9 uOos5BPVLTbmdOZU2QOy03MvEbT+1C88wKqV9Er5n8jqED/Rw6C7R0EF7+tcaX/LZQOI R+BYiyw4E+J7QjWops75J14Gih0YiXIhtzOx6CkwWMaqcVEBaDZjTwILzqTCIAQ2hBvF QsJ4ddl8vLuJfqH/rgFf68tOhRAOILZ8E9DljfYHsZmTYG55A+9cuE99KLKxOF+ZIm2g Vv4Q== X-Gm-Message-State: ANoB5pnujN9qbhyocZ/9FolzAUD1nbGR+4f0M163PGWo9hCfFH1kw5OW BH9i8iYKx20BzYo3VEjJIXX0+A== X-Google-Smtp-Source: AA0mqf6vI7368+n4pMvnxi95VA1iyP5io7fGxgExwiA82zCaQaCmxm8ukx9e+6+7K5FUfEXl2FApkg== X-Received: by 2002:a05:6512:47c:b0:48a:e80f:4b3a with SMTP id x28-20020a056512047c00b0048ae80f4b3amr15533040lfd.575.1669808482638; Wed, 30 Nov 2022 03:41:22 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id be11-20020a05651c170b00b002799b5aa42esm111713ljb.55.2022.11.30.03.41.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Nov 2022 03:41:22 -0800 (PST) Message-ID: <5d3ff57a-cb51-5dbf-7d38-7cc40aeea59c@linaro.org> Date: Wed, 30 Nov 2022 12:41:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 2/2] dt-bindings: interconnect: Add SM6115 DT bindings Content-Language: en-US To: Bhupesh Sharma , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org Cc: agross@kernel.org, bhupesh.linux@gmail.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, djakov@kernel.org, konrad.dybcio@linaro.org, a39.skl@gmail.com, andersson@kernel.org References: <20221130103841.2266464-1-bhupesh.sharma@linaro.org> <20221130103841.2266464-3-bhupesh.sharma@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <20221130103841.2266464-3-bhupesh.sharma@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 30/11/2022 11:38, Bhupesh Sharma wrote: > The Qualcomm SM6115 SoC has several bus fabrics that could be > controlled and tuned dynamically according to the bandwidth demand. > > Add the support for the same. > > Cc: Bjorn Andersson > Signed-off-by: Bhupesh Sharma > --- Thank you for your patch. There is something to discuss/improve. We could create common properties for these bindings, but it's fine now. > + > +additionalProperties: false > + > +examples: > + - | > + #include > + > + snoc: interconnect@1880000 { > + compatible = "qcom,sm6115-snoc"; > + reg = <0x01880000 0x60200>; > + #interconnect-cells = <1>; > + clock-names = "bus", "bus_a"; > + clocks = <&rpmcc RPM_SMD_SNOC_CLK>, > + <&rpmcc RPM_SMD_SNOC_A_CLK>; > + > + clk_virt: interconnect-clk { > + compatible = "qcom,sm6115-clk-virt"; > + #interconnect-cells = <1>; > + clock-names = "bus", "bus_a"; > + clocks = <&rpmcc RPM_SMD_QUP_CLK>, > + <&rpmcc RPM_SMD_QUP_A_CLK>; > + }; > + > + mmnrt_virt: interconnect-mmnrt { > + compatible = "qcom,sm6115-mmnrt-virt"; > + #interconnect-cells = <1>; > + clock-names = "bus", "bus_a"; > + clocks = <&rpmcc RPM_SMD_MMNRT_CLK>, > + <&rpmcc RPM_SMD_MMNRT_A_CLK>; > + }; > + > + mmrt_virt: interconnect-mmrt { > + compatible = "qcom,sm6115-mmrt-virt"; > + #interconnect-cells = <1>; > + clock-names = "bus", "bus_a"; > + clocks = <&rpmcc RPM_SMD_MMRT_CLK>, > + <&rpmcc RPM_SMD_MMRT_A_CLK>; > + }; Drop last two nodes - they are the same as first. > + }; > + > + cnoc: interconnect@1900000 { > + compatible = "qcom,sm6115-cnoc"; > + reg = <0x01900000 0x8200>; > + #interconnect-cells = <1>; > + clock-names = "bus", "bus_a"; > + clocks = <&rpmcc RPM_SMD_CNOC_CLK>, > + <&rpmcc RPM_SMD_CNOC_A_CLK>; > + }; > + > + bimc: interconnect@4480000 { > + compatible = "qcom,sm6115-bimc"; > + reg = <0x04480000 0x80000>; > + #interconnect-cells = <1>; > + clock-names = "bus", "bus_a"; > + clocks = <&rpmcc RPM_SMD_BIMC_CLK>, > + <&rpmcc RPM_SMD_BIMC_A_CLK>; > + }; Drop these two as well, they do not bring anything new here. > diff --git a/include/dt-bindings/interconnect/qcom,sm6115.h b/include/dt-bindings/interconnect/qcom,sm6115.h > new file mode 100644 > index 000000000000..2997106a661e > --- /dev/null > +++ b/include/dt-bindings/interconnect/qcom,sm6115.h > @@ -0,0 +1,115 @@ > +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ > +/* > + * Qualcomm SM6115 interconnect IDs > + * > + * Copyright (c) 2022, The Linux Foundation. All rights reserved. > + * Copyright (c) 2022, Linaro Limited Best regards, Krzysztof