From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64A31C352A1 for ; Wed, 7 Dec 2022 10:05:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229523AbiLGKFj (ORCPT ); Wed, 7 Dec 2022 05:05:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36190 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229480AbiLGKFi (ORCPT ); Wed, 7 Dec 2022 05:05:38 -0500 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 79AE53FBB0 for ; Wed, 7 Dec 2022 02:05:35 -0800 (PST) Received: by mail-lf1-x12e.google.com with SMTP id cf42so22116593lfb.1 for ; Wed, 07 Dec 2022 02:05:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=DpHjjkWBrFWRiuz7Mk0spdGCtOSkBPp4W0Exn6CPYEg=; b=RaL2APKN9cTXuETvRIe3OCMqPWldGnqETHkNwl0aOQGEKV4qlst4tgJdOXqe8llOOU K96M0wshlPdRlVvifKVtNNiUthkRjc2HdmjhwfiCyGN/mNB0oRF+rsm0DFTl4mUx0FR1 inzhaVdi54nqS/RyzXBOl5PB/Rfq2KqgImcjYHTNE1TIxAsN+Bpmh79f92H5VT5+2zna zoRrNkznl/tTehMdh9B4pA99pBm6iYHwjVdhSCw04sOoLT8PA0LWcNkZWBSgIRJELF5g DACW+6vrR1YmCRIuJVKlKqdSHeyR1+tlBbFtq/aZBF0xvM//dX4ATS/zrRy4dOxstLLF +Ktg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DpHjjkWBrFWRiuz7Mk0spdGCtOSkBPp4W0Exn6CPYEg=; b=kQHwLQmARxlJZ1BLKK5saBPykdxTAgX/rsb+uQpXk/7J1yOP8D1Am+iWci9/UKH5z4 RmeEDZpPw3cNbRlHzzpALfw5zgMw6Vq2VIrcwXU5Ig5HsOpCg/D9XQ5+/kqD9TYGDlfr GKD2Jf2qHrj+AahMuDDl6/E30Q6y72gQPmm9rfk54yuYHkzhEQ4GhVgFpIxEB0j8DAxK lFawgi8FPU90bz60GgK7k6i5VApJWeFH37D4DwjTyIi8Yw+/B7IG5ZEtV8L4Qzl8JlsJ o6bYw+ZDMeuAcus7R139X4f8OA1KgwmKumCByy31LOctsj4WIjwIKiAeZgkMHJdbQvYo +cVQ== X-Gm-Message-State: ANoB5pkGY9p5Afi3cY6ovoNqkKXgO74hzCWMUfg2MvIL8TlrfcO/P1oK 1dpLPKNBiauztWP2XQVf8L46pw== X-Google-Smtp-Source: AA0mqf4uYDpZazDOatn5v5ERm6hu2aHyPoDOMnOzspbjmNwgh4nNhc+0dqfy6arwv/HFRl6RuYsXvw== X-Received: by 2002:ac2:4acc:0:b0:4b4:10ca:5240 with SMTP id m12-20020ac24acc000000b004b410ca5240mr33061634lfp.482.1670407533711; Wed, 07 Dec 2022 02:05:33 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id u23-20020a2e2e17000000b00278e9c0d3a2sm1914034lju.33.2022.12.07.02.05.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Dec 2022 02:05:33 -0800 (PST) Message-ID: <5d430795-f8c4-bb5c-ebe9-f3c3fdf4985d@linaro.org> Date: Wed, 7 Dec 2022 11:05:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH 2/5] staging: dt-bindings: mfd: adi,max77541.yaml Add MAX77541 bindings Content-Language: en-US To: Okan Sahin , outreachy@lists.linux.dev Cc: Lee Jones , Rob Herring , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Jonathan Cameron , Lars-Peter Clausen , Andy Shevchenko , Geert Uytterhoeven , Manish Narani , Marcelo Schmitt , Caleb Connolly , Marcus Folkesson , ChiYuan Huang , Anand Ashok Dumbre , Ramona Bolboaca , William Breathitt Gray , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-iio@vger.kernel.org References: <20221207090906.5896-1-okan.sahin@analog.com> <20221207090906.5896-3-okan.sahin@analog.com> From: Krzysztof Kozlowski In-Reply-To: <20221207090906.5896-3-okan.sahin@analog.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 07/12/2022 10:08, Okan Sahin wrote: > This patch adds document the bindings for MAX77541 MFD driver. It also Do not use "This commit/patch". https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 > includes MAX77540 driver whose regmap is covered by MAX77541. > > Signed-off-by: Okan Sahin > --- > .../devicetree/bindings/mfd/adi,max77541.yaml | 134 ++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 135 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/adi,max77541.yaml > > diff --git a/Documentation/devicetree/bindings/mfd/adi,max77541.yaml b/Documentation/devicetree/bindings/mfd/adi,max77541.yaml > new file mode 100644 > index 000000000000..205953e6dd15 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/adi,max77541.yaml > @@ -0,0 +1,134 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mfd/adi,max77541.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MAX77540/MAX77541 PMIC from ADI. Drop trailing space. > + > +maintainers: > + - Okan Sahin > + > +description: | > + MAX77540 is a Power Management IC with 2 buck regulators. > + > + MAX77541 is a Power Management IC with 2 buck regulators and 1 ADC. > + > +properties: > + compatible: > + enum: > + - adi,max77540 > + - adi,max77541 > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + regulators: > + $ref: /schemas/regulator/adi,max77541.yaml# I don't think you tested this patch. There is no such file. > + > + adc: > + type: object > + additionalProperties: false > + properties: > + compatible: > + const: adi,max77541-adc Why having a child without any resources? It does not look like needed and instead your parent driver should instantiate the child device. > + required: > + -compatible > + > +required: > + - compatible > + - reg > + - interrupts > + > +allOf: > + - if: > + properties: > + compatible: > + contains: > + const: adi,max77540 > + then: > + properties: > + regulator: > + properties: > + compatible: > + const: adi,max77540-regulator > + else: > + properties: > + regulator: > + properties: > + compatible: > + const: adi,max77541-regulator > + adc: > + properties: > + compatible: > + const: adi,max77541-adc The adc part is not needed anyway - duplicating what's in top-level properties. > + > +additionalProperties: false > + > +examples: > + - | > + #include > + > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + pmic@69 { > + compatible = "adi,max77540"; > + reg = <0x69>; > + interrupt-parent = <&gpio>; > + interrupts = <16 IRQ_TYPE_EDGE_FALLING>; > + > + regulators { > + buck1 { > + regulator-min-microvolt = <500000>; > + regulator-max-microvolt = <5200000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + buck2 { > + regulator-min-microvolt = <500000>; > + regulator-max-microvolt = <5200000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + }; > + }; > + }; > + > + - | > + #include > + > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + pmic@69 { > + compatible = "adi,max77541"; Keep only one example (more complex one) - they are almost the same. > + reg = <0x63>; > + interrupt-parent = <&gpio>; > + interrupts = <16 IRQ_TYPE_EDGE_FALLING>; > + > + regulators { > + buck1 { > + regulator-min-microvolt = <500000>; > + regulator-max-microvolt = <5200000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + buck2 { > + regulator-min-microvolt = <500000>; > + regulator-max-microvolt = <5200000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + }; > + > + adc { > + compatible = "adi,max77541-adc"; > + } > + }; > + }; > \ No newline at end of file Error here. > diff --git a/MAINTAINERS b/MAINTAINERS > index af94d06bb9f0..22f5a9c490e3 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -12501,6 +12501,7 @@ MAXIM MAX77541 PMIC MFD DRIVER > M: Okan Sahin > L: linux-kernel@vger.kernel.org > S: Maintained > +F: Documentation/devicetree/bindings/mfd/adi,max77541.yaml > F: drivers/mfd/max77541.c > F: include/linux/mfd/max77541.h > Best regards, Krzysztof