From: "Matti Lehtimäki" <matti.lehtimaki@gmail.com>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: linux-arm-msm@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Olof Johansson <olof@lixom.net>,
soc@kernel.org, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/3] ARM: dts: qcom: Add support for Samsung Galaxy Tab 4 10.1 (SM-T530)
Date: Sun, 24 Jul 2022 23:43:01 +0300 [thread overview]
Message-ID: <5d500d42-3926-20f1-a677-3b77c4b2e8ca@gmail.com> (raw)
In-Reply-To: <CAA8EJpqUH_v1GXEYF62Z3DBtFu_305_h4D36aCnBr38bo5HoJw@mail.gmail.com>
On 24.7.2022 21.55, Dmitry Baryshkov wrote:
> On Sun, 24 Jul 2022 at 20:25, Matti Lehtimäki <matti.lehtimaki@gmail.com> wrote:
>> +/delete-node/ &smem_region;
>
> Please move this to the /reserved-memory node. having it there would
> help understanding that we are just changing the address.
I can move this to /reserved-memory node in next version. Other option
would be to have a comment here, it seems both ways are used.
>> + i2c-muic {
>> + compatible = "i2c-gpio";
>
> Is there any reason for using i2c-gpio rather than blsp_i2c4?
> According to the pinctrl-msm8226, gpio14/15 can be mapped to the blsp.
The reason to use i2c-gpio for this was using the other devices with
similar node as an example. I tested and having the muic node in
blsp_i2c4 worked the same.
-Matti
prev parent reply other threads:[~2022-07-24 20:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-24 17:24 [PATCH v3 0/3] Initial Samsung Galaxy Tab 4 10.1 (SM-T530) support Matti Lehtimäki
2022-07-24 17:24 ` [PATCH v3 1/3] ARM: dts: qcom: pm8226: Add node for the GPIOs Matti Lehtimäki
2022-07-24 18:44 ` Dmitry Baryshkov
2022-07-26 11:14 ` Krzysztof Kozlowski
2022-07-24 17:24 ` [PATCH v3 2/3] dt-bindings: arm: qcom: Document samsung,matisse-wifi device Matti Lehtimäki
2022-07-24 17:24 ` [PATCH v3 3/3] ARM: dts: qcom: Add support for Samsung Galaxy Tab 4 10.1 (SM-T530) Matti Lehtimäki
2022-07-24 18:55 ` Dmitry Baryshkov
2022-07-24 20:43 ` Matti Lehtimäki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d500d42-3926-20f1-a677-3b77c4b2e8ca@gmail.com \
--to=matti.lehtimaki@gmail.com \
--cc=agross@kernel.org \
--cc=arnd@arndb.de \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=soc@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).