From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 593B33EDAD7; Thu, 2 Jul 2026 11:28:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782991725; cv=none; b=oZsr+GjHXqsHYOLrxgZS3PsFgxJzco4SbEyks5J2YWy65h5W23jij8Z5E85wPJQ8vxc2Zml5gCUtLZLwxztETDY0ha1GikhZmIYdq0tc3YU5pHPqAq0LNgx6+4OK3fBSQyktEbtl6tzYK6wdnkmGie5sVFmaL1QCk+xplbnB2uI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782991725; c=relaxed/simple; bh=1nALJb+YA7y5h8aPBgSeA8j2VmbMtrXkD/kdNDKRMkk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sFf1rTyEYECxZ6igpqZ8VoSJlYkiADkwG9BrfXtZwFpqbpdhfvRRAlcxcAT/3wwIkPOjKkSnXGzttwAFVElm2YWuM7qbCvV4GacVgC2Sj+xegC4MVEl7GKkVEhEYSzCYpps4iiT4NIyW0cgVCgS9QXq/zs4Oj9SDJS77Ulg1xAw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=EvTdZVOG; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="EvTdZVOG" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 151691F000E9; Thu, 2 Jul 2026 11:28:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782991724; bh=j+2496+EdZL1GqvlfPj2h34a+6w39M+uQkYKjHLslWY=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=EvTdZVOGcpfVSh7Dgurtt83ghAxAI83lL+mOJlhatiiCZvGl2cWNag8tAyn/Pslen 5jkNEgzssFxl4rJfxBfJzjOPOyFMCW795DYy6c0Gt2db+2ce5qhaSO6V7uRWT+cy2L zYIw8pJ2hu5s3lfgY4FByH/12vnUvuXNbJ+orjjCujzNpWHisr3mxQvwcQWpkvISKc Ft3avPhW0R2YhTkzP+Y/5lHmO3rJEQpzNWA/fB4T/DD7aq+yY1FTqye6HoDnd83rWN vcq1Ado2XtV62z9AUxYCSwPeWldZ98OllaFGlOMd6AR6KUYAoTpNXJjstEPJWmryIY Hp0scf2/Im6tg== Message-ID: <5d5c693b-bd07-40a4-aea5-d9e1884aac50@kernel.org> Date: Thu, 2 Jul 2026 13:28:35 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/2] qcom_battmgr: Add batteryless DC-adapter MAINS support To: Rakesh Kota , Konrad Dybcio Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sebastian Reichel , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, jishnu.prakash@oss.qualcomm.com, kamal.wadhwa@oss.qualcomm.com References: <20260518-add_dc_in_support-v1-0-31fbaa329879@oss.qualcomm.com> <56a54a34-1040-44ae-92e2-ce65a3d3acb5@oss.qualcomm.com> <20260519065938.4i5wot72pfxy4m3d@hu-kotarake-hyd.qualcomm.com> <20260702111737.2qtjcfskulav4usd@hu-kotarake-hyd.qualcomm.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGPBBMBCgA5AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJp2mE8AAoJEBuTQ307QWKbeaIP /ihHTkTW4KsN/DQ945JJbyu5tI0J80Wue7QyyLPglyKfhgb5cLLNPpOC8cCIJsc7+W3i2P38 s2c1cOH6CYGE7E9ur3Vfme8NW2S2I/Z8VC7bZnzyS23wT17LrsdS/qCpx4o8U+pt/xdXDKph EGRYrIEmMpUWvyYzyYKGIe25FtaayIIKpq8eZYyFcp2f/sG5IkOW5uZzHPMPdcm87jU7fyuQ rAU2vx9r+ulUfQ/q9Z2roC/ode3l7t2pN7BCBCsUDp6JCrUyZrtT1e7EbA0ZRP3aOBNk2P2E DQOgJGjGdO5Yx2Y9LFtltu6JbsBJHi1syGRX3AtQYOMc4Y1WGoeZJmMlvKj2ZqqXNkcWi2DS IQEWB0uW6CqFsBBIMGDa+6OzdaVO/uAVXWDWml02Men3CILdI1MbVjoh8ECqYUY7OQ+JJvNN vnliuq5WM3Ghd3jg/LZZrxXjdIginRHFQCjIJYLKpLZWm1/iDFedcfzqRNYmTtqscdCNHW41 oT3Z7BmO9xwdjuwBS6nmS6JJwkbf5Ot2QR4pB/DRU7ZwjT1qHe+9r9gF32wXVQatHNGK/VVu sfwOnkdxCWkp/qb2gdQRmZh+SedStWshigH6sNfuHBloF/q+hjMRc8b2m326OZdrbSHwY1Sz vti8Hn7n8NjdHO9LKB7BIdjkA9DA5WsqOuVCzsFNBFVDXDQBEADNkrQYSREUL4D3Gws46JEo Z9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLueMNsWLJBv BaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6eiOMheesVS 5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wAGldWsRxb f3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA6z6lBZn0 WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9YegxWKvX XHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt91pFzBSO IpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gUBLHFTg2h YnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/JoFzZ4B0 p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu4vXVFBYI GmpyNPYzRm0QPwARAQABwsF2BBgBCgAgAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmna YUkACgkQG5NDfTtBYptX+BAApg32CkxwNucNEi8WfWA8oKkW0y8YDuY6ORMo9FWNGiT/OTy0 vyJrLocrpn86zwfjVp+eCrssPYh8eqJfnWqmYv6ACQtHPYzPZQ3mSo8H97Z01oUxITzCxpXm ZkLgPIqtDPcC2E3dPM/fVxcyowM8XsaMA9wcsaUYrta8toOq2b9tKcjleKMfMrm0gQ9u7wUc QbLkwj6TCLOwucb07GXzLTNF9PZmaDUpKAZjMjmrW+le+SFvQbhamx0rxLWPR0NWntXpbCn+ +ACch03p/JyTBVktxFsFyCt7pTPE1kEaeuXBTe/a2D9iQvRxRW19LvuO2e59/u1wYUiH/orz wbIC2S4dBsPAPihL3ztOU1yE86GPyQtSE0kU+/7snnLt4QGi6PChf3t5gnNjAzjUUovO8rgI c+5yN5heq5loYHgK6OQ9OlHzsPHO9e9MOQcKlFycs1pyijFGzDwdNUm/SchK8iWT2QApTx4A K9bCVaboTA2T77QYkRcRJYSsO1alGX0ome/hMLD1daXlkrNUp1HWa3K4iytLRXjCSIorWiGs n+q3krnpXu3TFkA8qtOFZMdnIiFuiq1yLT8hptsV5xh1TA2nsVvSYiaCr3q4s4BKjS/KrLDb qoxzw8ISjdUp4pA85vb6YLCmb39NgidD+7PmAr65lBNveIFynTgsja1rRQ4= In-Reply-To: <20260702111737.2qtjcfskulav4usd@hu-kotarake-hyd.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 02/07/2026 13:17, Rakesh Kota wrote: > On Tue, Jun 30, 2026 at 04:16:13PM +0200, Konrad Dybcio wrote: >> On 5/22/26 12:56 AM, Bjorn Andersson wrote: >>> On Tue, May 19, 2026 at 12:29:38PM +0530, Rakesh Kota wrote: >>>> On Mon, May 18, 2026 at 04:36:32PM +0200, Konrad Dybcio wrote: >>>>> On 5/18/26 3:49 PM, Rakesh Kota wrote: >>>>>> On batteryless boards powered by 12V DC adapters, registering the >>>>>> power supply as BATTERY causes userspace to incorrectly trigger >>>>>> battery power-saving sequences. >>>>> >>>>> Does battman really offer no way of differentiating whether a battery >>>>> is *actually* present in such cases? >>>>> >>>>> What boards are affected? >>>>> >>>> Currently, batteryless support is only implemented for the >>>> qcs6490-rb3gen2(Kodiak) board. >>>> >>> >>> What do you mean? >>> >>> Are you saying that the pmic_glink firmware in Kodiak has a one-off hack >>> that no other implementation of this firmware has? >>> >>> My Lenovo IdeaCentre (hamoa) doesn't have battery, what should I do now? >> >> I was going through my inbox. >> This remains unanswered, and I don't see the discussion progressing >> without resolving this. >> > To clarify — there is no platform-side hack involved. The Kodiak board > has a batteryless variant, but the pmic_glink firmware provides no way > to distinguish whether a battery is physically present or not. Since > this can't be determined from firmware, we introduced a DT-based > property to describe the hardware configuration explicitly. > > This is not Kodiak-specific — any batteryless board, including hamoa, > can use the same DT property to avoid incorrect BATTERY registration Unfortunately the answer might be: fix your firmware. Since your firmware is the interface and we do not expose battery in DT, then you do not get additional properties. You made conscious design choice of abstracting some things in the firmware, so you do control that part of the software stack. If you make one choice, it might lead to other, like rejecting such properties. Best regards, Krzysztof