From: Stefan Wahren <stefan.wahren@i2se.com>
To: Maxime Ripard <maxime@cerno.tech>, Rob Herring <robh+dt@kernel.org>
Cc: devicetree@vger.kernel.org, David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org, Eric Anholt <eric@anholt.net>,
linux-arm-kernel@lists.infradead.org,
Daniel Vetter <daniel@ffwll.ch>,
Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Subject: Re: [PATCH V3] dt-bindings: gpu: Convert v3d to json-schema
Date: Wed, 13 Jan 2021 13:53:38 +0100 [thread overview]
Message-ID: <5d6daa40-9b30-5d8d-d363-fa44af21e81a@i2se.com> (raw)
In-Reply-To: <20210113091520.btk53z5mrhmaqd6h@gilmour>
Hi Maxime,
Am 13.01.21 um 10:15 schrieb Maxime Ripard:
> Hi,
>
> On Sat, Jan 09, 2021 at 11:50:32AM +0100, Stefan Wahren wrote:
>> This converts the v3d bindings to yaml format.
>>
>> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
>> ---
...
>> diff --git a/Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml b/Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml
>> new file mode 100644
>> index 0000000..3b543d4
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml
>> @@ -0,0 +1,72 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/gpu/brcm,bcm-v3d.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Broadcom V3D GPU Bindings
>> +
>> +maintainers:
>> + - Eric Anholt <eric@anholt.net>
>> + - Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
>> +
>> +properties:
>> + $nodename:
>> + pattern: '^gpu@[a-f0-9]+$'
>> +
>> + compatible:
>> + enum:
>> + - brcm,7268-v3d
>> + - brcm,7278-v3d
>> +
>> + reg:
>> + items:
>> + - description: hub register (required)
>> + - description: core0 register (required)
>> + - description: GCA cache controller register (if GCA controller present)
>> + - description: bridge register (if no external reset controller)
>> + minItems: 2
> maxItems will be set to 2 in this case, while it would be 4 I guess?
This confuses me. Based on this patch [1] by Rob, i would assume that
maxItems is derived from item list length.
[1] -
https://lists.freedesktop.org/archives/dri-devel/2020-December/292309.html
>
> Looks fine otherwise
>
> Maxime
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-01-13 12:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-09 10:50 [PATCH V3] dt-bindings: gpu: Convert v3d to json-schema Stefan Wahren
2021-01-13 9:15 ` Maxime Ripard
2021-01-13 12:53 ` Stefan Wahren [this message]
2021-01-13 15:48 ` Maxime Ripard
2021-01-13 15:37 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d6daa40-9b30-5d8d-d363-fa44af21e81a@i2se.com \
--to=stefan.wahren@i2se.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=eric@anholt.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=maxime@cerno.tech \
--cc=nsaenzjulienne@suse.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox