* [PATCH 1/2] input: adc-keys: add DT binding documentation
@ 2016-07-01 21:30 Alexandre Belloni
2016-07-03 13:43 ` Jonathan Cameron
0 siblings, 1 reply; 4+ messages in thread
From: Alexandre Belloni @ 2016-07-01 21:30 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Jonathan Cameron, Maxime Ripard, linux-input, linux-iio,
linux-kernel, Alexandre Belloni, Rob Herring, devicetree
Add documentation for ADC keys
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
Cc: Rob Herring <robh+dt@kernel.org>
Cc: devicetree@vger.kernel.org
.../devicetree/bindings/input/adc-keys.txt | 45 ++++++++++++++++++++++
1 file changed, 45 insertions(+)
create mode 100644 Documentation/devicetree/bindings/input/adc-keys.txt
diff --git a/Documentation/devicetree/bindings/input/adc-keys.txt b/Documentation/devicetree/bindings/input/adc-keys.txt
new file mode 100644
index 000000000000..873476bb4eab
--- /dev/null
+++ b/Documentation/devicetree/bindings/input/adc-keys.txt
@@ -0,0 +1,45 @@
+Allwinner sun4i low res adc attached tablet keys
+------------------------------------------------
+
+Required properties:
+ - compatible: "adc-keys"
+ - io-channels: Phandle to an ADC channel
+ - io-channel-names = "buttons";
+ - voltage-keyup-mvolt: Voltage at which all the keys are considered up.
+
+Each key is represented as a sub-node of "adc-keys":
+
+Required subnode-properties:
+ - label: Descriptive name of the key.
+ - linux,code: Keycode to emit.
+ - voltage-mvolt: Voltage adc input when this key is pressed.
+
+Example:
+
+#include <dt-bindings/input/input.h>
+
+ adc-keys {
+ compatible = "adc-keys";
+ io-channels = <&lradc 0>;
+ io-channel-names = "buttons";
+ voltage-keyup-mvolt = <2000>;
+
+ button@1500 {
+ label = "Volume Up";
+ linux,code = <KEY_VOLUMEUP>;
+ voltage-mvolt = <1500>;
+ };
+
+ button@1000 {
+ label = "Volume Down";
+ linux,code = <KEY_VOLUMEDOWN>;
+ voltage-mvolt = <1000>;
+ };
+
+ button@500 {
+ label = "Enter";
+ linux,code = <KEY_ENTER>;
+ voltage-mvolt = <500>;
+ };
+ };
+
--
2.8.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] input: adc-keys: add DT binding documentation
2016-07-01 21:30 [PATCH 1/2] input: adc-keys: add DT binding documentation Alexandre Belloni
@ 2016-07-03 13:43 ` Jonathan Cameron
[not found] ` <5d71d3a2-4d51-8dd5-0e4a-638ec1b5035a-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2016-07-05 14:53 ` Rob Herring
0 siblings, 2 replies; 4+ messages in thread
From: Jonathan Cameron @ 2016-07-03 13:43 UTC (permalink / raw)
To: Alexandre Belloni, Dmitry Torokhov
Cc: Maxime Ripard, linux-input, linux-iio, linux-kernel, Rob Herring,
devicetree
On 01/07/16 22:30, Alexandre Belloni wrote:
> Add documentation for ADC keys
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Clean looking binding to me - one comment inline.
Jonathan
> ---
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: devicetree@vger.kernel.org
>
> .../devicetree/bindings/input/adc-keys.txt | 45 ++++++++++++++++++++++
> 1 file changed, 45 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/input/adc-keys.txt
>
> diff --git a/Documentation/devicetree/bindings/input/adc-keys.txt b/Documentation/devicetree/bindings/input/adc-keys.txt
> new file mode 100644
> index 000000000000..873476bb4eab
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/adc-keys.txt
> @@ -0,0 +1,45 @@
> +Allwinner sun4i low res adc attached tablet keys
What is allwinner specific in here? Looks pretty general purpose to me!
> +------------------------------------------------
> +
> +Required properties:
> + - compatible: "adc-keys"
> + - io-channels: Phandle to an ADC channel
> + - io-channel-names = "buttons";
> + - voltage-keyup-mvolt: Voltage at which all the keys are considered up.
> +
> +Each key is represented as a sub-node of "adc-keys":
> +
> +Required subnode-properties:
> + - label: Descriptive name of the key.
> + - linux,code: Keycode to emit.
> + - voltage-mvolt: Voltage adc input when this key is pressed.
> +
> +Example:
> +
> +#include <dt-bindings/input/input.h>
> +
> + adc-keys {
> + compatible = "adc-keys";
> + io-channels = <&lradc 0>;
> + io-channel-names = "buttons";
> + voltage-keyup-mvolt = <2000>;
> +
> + button@1500 {
> + label = "Volume Up";
> + linux,code = <KEY_VOLUMEUP>;
> + voltage-mvolt = <1500>;
> + };
> +
> + button@1000 {
> + label = "Volume Down";
> + linux,code = <KEY_VOLUMEDOWN>;
> + voltage-mvolt = <1000>;
> + };
> +
> + button@500 {
> + label = "Enter";
> + linux,code = <KEY_ENTER>;
> + voltage-mvolt = <500>;
> + };
> + };
> +
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] input: adc-keys: add DT binding documentation
[not found] ` <5d71d3a2-4d51-8dd5-0e4a-638ec1b5035a-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
@ 2016-07-04 16:29 ` Alexandre Belloni
0 siblings, 0 replies; 4+ messages in thread
From: Alexandre Belloni @ 2016-07-04 16:29 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Dmitry Torokhov, Maxime Ripard,
linux-input-u79uwXL29TY76Z2rM5mHXA,
linux-iio-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Rob Herring,
devicetree-u79uwXL29TY76Z2rM5mHXA
On 03/07/2016 at 14:43:56 +0100, Jonathan Cameron wrote :
> On 01/07/16 22:30, Alexandre Belloni wrote:
> > Add documentation for ADC keys
> >
> > Signed-off-by: Alexandre Belloni <alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
> Clean looking binding to me - one comment inline.
>
> Jonathan
> > ---
> > Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> > Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> >
> > .../devicetree/bindings/input/adc-keys.txt | 45 ++++++++++++++++++++++
> > 1 file changed, 45 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/input/adc-keys.txt
> >
> > diff --git a/Documentation/devicetree/bindings/input/adc-keys.txt b/Documentation/devicetree/bindings/input/adc-keys.txt
> > new file mode 100644
> > index 000000000000..873476bb4eab
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/input/adc-keys.txt
> > @@ -0,0 +1,45 @@
> > +Allwinner sun4i low res adc attached tablet keys
> What is allwinner specific in here? Looks pretty general purpose to me!
That's true, I forgot to change that after shamelessly copy pasting...
I was planning to use something like ADC attached resistor ladder
buttons, unless you have a better way to describe that.
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] input: adc-keys: add DT binding documentation
2016-07-03 13:43 ` Jonathan Cameron
[not found] ` <5d71d3a2-4d51-8dd5-0e4a-638ec1b5035a-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
@ 2016-07-05 14:53 ` Rob Herring
1 sibling, 0 replies; 4+ messages in thread
From: Rob Herring @ 2016-07-05 14:53 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Alexandre Belloni, Dmitry Torokhov, Maxime Ripard, linux-input,
linux-iio, linux-kernel, devicetree
On Sun, Jul 03, 2016 at 02:43:56PM +0100, Jonathan Cameron wrote:
> On 01/07/16 22:30, Alexandre Belloni wrote:
> > Add documentation for ADC keys
> >
> > Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> Clean looking binding to me - one comment inline.
>
> Jonathan
> > ---
> > Cc: Rob Herring <robh+dt@kernel.org>
> > Cc: devicetree@vger.kernel.org
> >
> > .../devicetree/bindings/input/adc-keys.txt | 45 ++++++++++++++++++++++
> > 1 file changed, 45 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/input/adc-keys.txt
> >
> > diff --git a/Documentation/devicetree/bindings/input/adc-keys.txt b/Documentation/devicetree/bindings/input/adc-keys.txt
> > new file mode 100644
> > index 000000000000..873476bb4eab
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/input/adc-keys.txt
> > @@ -0,0 +1,45 @@
> > +Allwinner sun4i low res adc attached tablet keys
> What is allwinner specific in here? Looks pretty general purpose to me!
> > +------------------------------------------------
> > +
> > +Required properties:
> > + - compatible: "adc-keys"
> > + - io-channels: Phandle to an ADC channel
> > + - io-channel-names = "buttons";
> > + - voltage-keyup-mvolt: Voltage at which all the keys are considered up.
> > +
> > +Each key is represented as a sub-node of "adc-keys":
> > +
> > +Required subnode-properties:
> > + - label: Descriptive name of the key.
> > + - linux,code: Keycode to emit.
> > + - voltage-mvolt: Voltage adc input when this key is pressed.
voltage-mcvoltface?
"voltage" is redundant and use standard units. How about
{press,up}-threshold-microvolt?
Rob
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-07-05 14:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-01 21:30 [PATCH 1/2] input: adc-keys: add DT binding documentation Alexandre Belloni
2016-07-03 13:43 ` Jonathan Cameron
[not found] ` <5d71d3a2-4d51-8dd5-0e4a-638ec1b5035a-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2016-07-04 16:29 ` Alexandre Belloni
2016-07-05 14:53 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).