From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79D2BFA3744 for ; Sat, 29 Oct 2022 21:56:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229576AbiJ2V40 (ORCPT ); Sat, 29 Oct 2022 17:56:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42750 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229544AbiJ2V4T (ORCPT ); Sat, 29 Oct 2022 17:56:19 -0400 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC0C627FD8 for ; Sat, 29 Oct 2022 14:56:18 -0700 (PDT) Received: by mail-lf1-x12a.google.com with SMTP id bp15so13616534lfb.13 for ; Sat, 29 Oct 2022 14:56:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=cZpw4f7LAUGvF4cSAbPz5CyMSMlcyLXGFUZk34oAqwk=; b=e3gHyWh79z0KE5mRU/J/MMBAmTjW8qWmUrc2++BjK4YxMq4J8S64pZFPL6Po2IR6Pp VT2hrOHKcu4Pn/jYo4Jotb0roRp0orFbcVErMa5hph1ZeGed2CUVzG4FyqeOtzvzCwCq jnpp7jrqEHpWNGcAb/jn0pG6vn2rYNOmHg/EScAm9VMAEQjRpQPdkYMO+rnnMZCbDo9r mBaNvA2sn9AaP9J40dXrI9YOzinvXWooAocFXvMVmLZ5lnvNwd5zE65fy5niewhS7riH 15veiAGwLSIWaL3NnWlpBSi3CDelcpfd5OHeQsAWFC309+rAbC4mKHMVSi+YrybO8d++ D0Pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cZpw4f7LAUGvF4cSAbPz5CyMSMlcyLXGFUZk34oAqwk=; b=2JtzQUl+6JL8NALBWdC9A8nlSW2f8m6ygS+mvjYQnKrZYt7pCothPDbXrlQPE9YbeV 8timRSc0xy286o5HTOZg9TXwJPhlRBXA7ETqOjYmhpCdUfs1pXGYc6AZHnyi40dZfml9 wTJaFvv5MoyXIJx/kAoTRbU9Meao1zNb3V328DFdTBqgZt9wxcZyX0RbIv0FDLiomNDf wAfHTzojhDKgpL84ihBQ7zbxhyf+mSyuh04di8GIbfD7qA6IiI2xsEvK2FgWOF+tEZWb IUUr3WN4nZ7y/dVoxDQG8jG5DluEa1kmluN7DGLuVYGMjrocuvNA7q0I0yb0VXdaQ2TG b8ng== X-Gm-Message-State: ACrzQf0iXX3G3djdoVD9FWsXvvFLPKUr0ziPRr8Ih9xvpVoz4khK2wEi 0G4TfQQymwPPdLyblVliXJgdBfoX/UK71A== X-Google-Smtp-Source: AMsMyM50A4M6LSsxWacFB2rvuxaNawYjAGDccOogtj9cOVnciCpBaYi/aDIG05dElT3EALIbP3fkTg== X-Received: by 2002:a05:6512:2c88:b0:4a9:4051:79a1 with SMTP id dw8-20020a0565122c8800b004a9405179a1mr2131082lfb.331.1667080577306; Sat, 29 Oct 2022 14:56:17 -0700 (PDT) Received: from [10.27.10.248] ([195.165.23.90]) by smtp.gmail.com with ESMTPSA id 5-20020ac25f45000000b004a03fd4476esm443654lfz.287.2022.10.29.14.56.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 29 Oct 2022 14:56:17 -0700 (PDT) Message-ID: <5d846ed8-e1c3-701f-6b92-a0bd2a9670cb@linaro.org> Date: Sun, 30 Oct 2022 00:56:15 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: Re: [PATCH 08/15] scsi: ufs: ufs-qcom: Remove un-necessary goto statements Content-Language: en-GB To: Manivannan Sadhasivam , martin.petersen@oracle.com, jejb@linux.ibm.com, andersson@kernel.org, vkoul@kernel.org, krzysztof.kozlowski+dt@linaro.org Cc: konrad.dybcio@somainline.org, robh+dt@kernel.org, quic_cang@quicinc.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-scsi@vger.kernel.org References: <20221029141633.295650-1-manivannan.sadhasivam@linaro.org> <20221029141633.295650-9-manivannan.sadhasivam@linaro.org> From: Dmitry Baryshkov In-Reply-To: <20221029141633.295650-9-manivannan.sadhasivam@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 29/10/2022 17:16, Manivannan Sadhasivam wrote: > goto in error path is useful if the function needs to do cleanup other > than returning the error code. But in this driver, goto statements are > used for just returning the error code in many places. This really > makes it hard to read the code. > > So let's get rid of those goto statements and just return the error code > directly. > > Signed-off-by: Manivannan Sadhasivam > --- > drivers/ufs/host/ufs-qcom.c | 100 +++++++++++++++--------------------- > 1 file changed, 41 insertions(+), 59 deletions(-) Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry