From: Rob Herring <robh@kernel.org>
To: Martin Kaiser <martin@kaiser.cx>
Cc: Shawn Guo <shawnguo@kernel.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
NXP Linux Team <linux-imx@nxp.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: display: imx: fix native-mode setting
Date: Tue, 01 Oct 2019 17:09:04 -0500 [thread overview]
Message-ID: <5d93ce82.1c69fb81.fe9a0.e3e6@mx.google.com> (raw)
In-Reply-To: <20190918193853.25689-1-martin@kaiser.cx>
On Wed, Sep 18, 2019 at 09:38:53PM +0200, Martin Kaiser wrote:
> According to
> Documentation/devicetree/bindings/display/panel/display-timing.txt,
> native-mode is a property of the display-timings node.
>
> If it's located outside of display-timings, the native-mode setting is
> ignored and the first display timing is used.
>
> We've already fixed the board definitions which got this wrong. Fix the
> example in the imx framebuffer bindings as well.
>
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> ---
> Documentation/devicetree/bindings/display/imx/fsl,imx-fb.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Please also fix
Documentation/devicetree/bindings/display/cirrus,clps711x-fb.txt
>
> diff --git a/Documentation/devicetree/bindings/display/imx/fsl,imx-fb.txt b/Documentation/devicetree/bindings/display/imx/fsl,imx-fb.txt
> index e5a8b363d829..f4df9e83bcd2 100644
> --- a/Documentation/devicetree/bindings/display/imx/fsl,imx-fb.txt
> +++ b/Documentation/devicetree/bindings/display/imx/fsl,imx-fb.txt
> @@ -38,10 +38,10 @@ Example:
>
> display0: display0 {
> model = "Primeview-PD050VL1";
> - native-mode = <&timing_disp0>;
> bits-per-pixel = <16>;
> fsl,pcr = <0xf0c88080>; /* non-standard but required */
> display-timings {
> + native-mode = <&timing_disp0>;
> timing_disp0: 640x480 {
> hactive = <640>;
> vactive = <480>;
> --
> 2.11.0
>
next prev parent reply other threads:[~2019-10-01 22:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-18 19:38 [PATCH] dt-bindings: display: imx: fix native-mode setting Martin Kaiser
2019-10-01 22:09 ` Rob Herring [this message]
2019-10-05 13:09 ` [PATCH v2 0/2] dt-bindings: display: " Martin Kaiser
2019-10-05 13:09 ` [PATCH v2 1/2] dt-bindings: display: imx: " Martin Kaiser
2019-10-11 15:30 ` Rob Herring
2019-10-05 13:09 ` [PATCH v2 2/2] dt-bindings: display: clps711x-fb: " Martin Kaiser
2019-10-11 15:30 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d93ce82.1c69fb81.fe9a0.e3e6@mx.google.com \
--to=robh@kernel.org \
--cc=b.zolnierkie@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martin@kaiser.cx \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).