From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B6A0CA9ED4 for ; Mon, 4 Nov 2019 21:50:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 669FD2184C for ; Mon, 4 Nov 2019 21:50:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="VdrX4xLl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387590AbfKDVuH (ORCPT ); Mon, 4 Nov 2019 16:50:07 -0500 Received: from mail-pf1-f195.google.com ([209.85.210.195]:45434 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387607AbfKDVuG (ORCPT ); Mon, 4 Nov 2019 16:50:06 -0500 Received: by mail-pf1-f195.google.com with SMTP id z4so7384769pfn.12 for ; Mon, 04 Nov 2019 13:50:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=message-id:mime-version:content-transfer-encoding:in-reply-to :references:cc:subject:from:to:user-agent:date; bh=m7u6XnFno1niAn3g/GTTogmEyGnr2KDC1wpIxFpftd8=; b=VdrX4xLlj0CeahX2K+/3ygXshjkC6iCjHbrwZN381IqazQOUBvxNx+hjT2v21ouHZ1 k6jPHo8Sux1XBLg717ng17apSGAniOXPEWj5V1lO0i+wQqKKn9/jj7byg0bVgI64EJ9P OgCOnstMLPGEpA7ExFIGTmKBdTOmfwAL6YD2I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:mime-version :content-transfer-encoding:in-reply-to:references:cc:subject:from:to :user-agent:date; bh=m7u6XnFno1niAn3g/GTTogmEyGnr2KDC1wpIxFpftd8=; b=HB302pasLyGA2ODgmte9j2MBuXKRX52pVwx1f+O81UmvR0zLK7/r8tkQ9LvlddGfAa tGc/XOQiA5Vj1VUgJusWKWWaWcEJXnuqDaQiKgsX/XqHkZEid3+8TLHOV9meQjH1naAE FdXyWKMgcLsWOZJK/nlt9yxtNLVADrjtoauPFXBb2visa+oW6WCcnFWEriSuZIg/XfRh 6UW1l+Gu8FjiNy9dlA5x2Ow9MJB6n/xH2nvcuyIgzI0MFE03ajr+m/29OLK2/Aa+yH5z XBo3Q9Go+EB1xvj1mXVN5FKxDZ8tQ61A5lKGOJqex/pr6JNRAEeX7KVSCqR7tRvrlN5B p2cA== X-Gm-Message-State: APjAAAVN+XVJ+J9eo/ZidkqEE6PhKsNWhqY4ZXuGbRDwMHDNdSahHIvt anPILWKbDOaPFjOjT5HcGgiyMg== X-Google-Smtp-Source: APXvYqz6i6OlRVP/C1nZkPSqyVXpRcWXPfCHnElJZ53YJ41MFt/42z//JvyK3J+7s2m3NyiYTYlSVA== X-Received: by 2002:a63:595:: with SMTP id 143mr32676791pgf.45.1572904204940; Mon, 04 Nov 2019 13:50:04 -0800 (PST) Received: from chromium.org ([2620:15c:202:1:fa53:7765:582b:82b9]) by smtp.gmail.com with ESMTPSA id a25sm957354pff.50.2019.11.04.13.50.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Nov 2019 13:50:04 -0800 (PST) Message-ID: <5dc09d0c.1c69fb81.99b28.48eb@mx.google.com> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <1572500287-21353-3-git-send-email-sanm@codeaurora.org> References: <1572500287-21353-1-git-send-email-sanm@codeaurora.org> <1572500287-21353-3-git-send-email-sanm@codeaurora.org> Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Manu Gautam , Sandeep Maheswaram Subject: Re: [PATCH 2/2] dt-bindings: phy-qcom-qusb2: Add SC7180 QUSB2 phy support From: Stephen Boyd To: Andy Gross , Kishon Vijay Abraham I , Mark Rutland , Rob Herring , Sandeep Maheswaram User-Agent: alot/0.8.1 Date: Mon, 04 Nov 2019 13:50:03 -0800 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Quoting Sandeep Maheswaram (2019-10-30 22:38:07) > Add QUSB2 phy entries for SC7180 in device tree bindings. >=20 > Signed-off-by: Sandeep Maheswaram > --- > Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) Can you convert this binding to YAML? It may make it easier to understand what compatibles have certain properties. >=20 > diff --git a/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt b/D= ocumentation/devicetree/bindings/phy/qcom-qusb2-phy.txt > index fe29f9e..d46fca7 100644 > --- a/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt > +++ b/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt > @@ -8,6 +8,7 @@ Required properties: > "qcom,msm8996-qusb2-phy" for 14nm PHY on msm8996, > "qcom,msm8998-qusb2-phy" for 10nm PHY on msm8998, > "qcom,sdm845-qusb2-phy" for 10nm PHY on sdm845. > + "qcom,sc7180-qusb2-phy" for 8nm PHY on sc7180. Please sort compatible string here. > =20 > - reg: offset and length of the PHY register set. > - #phy-cells: must be 0. > @@ -31,23 +32,23 @@ Optional properties: > - qcom,imp-res-offset-value: It is a 6 bit value that specifies offset = to be > added to PHY refgen RESCODE via IMP_CTRL1 register. It is= a PHY > tuning parameter that may vary for different boards of sa= me SOC. > - This property is applicable to only QUSB2 v2 PHY (sdm845). > + This property is applicable to only QUSB2 v2 PHY (sdm845,= sc7180). Put a space after that comma please. > - qcom,hstx-trim-value: It is a 4 bit value that specifies tuning for H= STX > output current. > Possible range is - 15mA to 24mA (stepsize of 600 uA). > See dt-bindings/phy/phy-qcom-qusb2.h for applicable value= s. > - This property is applicable to only QUSB2 v2 PHY (sdm845). > + This property is applicable to only QUSB2 v2 PHY (sdm845,= sc7180). > Default value is 22.2mA for sdm845. > - qcom,preemphasis-level: It is a 2 bit value that specifies pre-emphas= is level. > Possible range is 0 to 15% (stepsize of 5%). > See dt-bindings/phy/phy-qcom-qusb2.h for applicable value= s. > - This property is applicable to only QUSB2 v2 PHY (sdm845). > + This property is applicable to only QUSB2 v2 PHY (sdm845,= sc7180). > Default value is 10% for sdm845. > - qcom,preemphasis-width: It is a 1 bit value that specifies how long th= e HSTX > pre-emphasis (specified using qcom,preemphasis-level) mus= t be in > effect. Duration could be half-bit of full-bit. > See dt-bindings/phy/phy-qcom-qusb2.h for applicable value= s. > - This property is applicable to only QUSB2 v2 PHY (sdm845). > + This property is applicable to only QUSB2 v2 PHY (sdm845,= sc7180). > Default value is full-bit width for sdm845. > =20 Same comment.