From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Stephen Boyd <sboyd@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Taniya Das <quic_tdas@quicinc.com>
Cc: Georgi Djakov <djakov@kernel.org>, Alex Elder <elder@linaro.org>,
Johan Hovold <johan@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 07/12] interconnect: qcom: sc8280xp: Drop IP0 interconnects
Date: Mon, 9 Jan 2023 14:48:12 +0100 [thread overview]
Message-ID: <5ddcd402-419c-cfc9-4b48-32186c3f18c2@linaro.org> (raw)
In-Reply-To: <20230109002935.244320-8-dmitry.baryshkov@linaro.org>
On 9.01.2023 01:29, Dmitry Baryshkov wrote:
> Similar to the sdx55 and sc7180, let's drop the MASTER_IPA_CORE and
> SLAVE_IPA_CORE interconnects for this platofm. There are no actual users
> of this intercoonect. The IP0 resource will be handled by clk-rpmh
> driver.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> drivers/interconnect/qcom/sc8280xp.c | 25 -------------------------
> drivers/interconnect/qcom/sc8280xp.h | 4 ++--
> 2 files changed, 2 insertions(+), 27 deletions(-)
>
> diff --git a/drivers/interconnect/qcom/sc8280xp.c b/drivers/interconnect/qcom/sc8280xp.c
> index 507fe5f89791..e56df893ec3e 100644
> --- a/drivers/interconnect/qcom/sc8280xp.c
> +++ b/drivers/interconnect/qcom/sc8280xp.c
> @@ -284,15 +284,6 @@ static struct qcom_icc_node xm_ufs_card = {
> .links = { SC8280XP_SLAVE_A2NOC_SNOC },
> };
>
> -static struct qcom_icc_node ipa_core_master = {
> - .name = "ipa_core_master",
> - .id = SC8280XP_MASTER_IPA_CORE,
> - .channels = 1,
> - .buswidth = 8,
> - .num_links = 1,
> - .links = { SC8280XP_SLAVE_IPA_CORE },
> -};
> -
> static struct qcom_icc_node qup0_core_master = {
> .name = "qup0_core_master",
> .id = SC8280XP_MASTER_QUP_CORE_0,
> @@ -882,13 +873,6 @@ static struct qcom_icc_node srvc_aggre2_noc = {
> .buswidth = 4,
> };
>
> -static struct qcom_icc_node ipa_core_slave = {
> - .name = "ipa_core_slave",
> - .id = SC8280XP_SLAVE_IPA_CORE,
> - .channels = 1,
> - .buswidth = 8,
> -};
> -
> static struct qcom_icc_node qup0_core_slave = {
> .name = "qup0_core_slave",
> .id = SC8280XP_SLAVE_QUP_CORE_0,
> @@ -1845,12 +1829,6 @@ static struct qcom_icc_bcm bcm_cn3 = {
> },
> };
>
> -static struct qcom_icc_bcm bcm_ip0 = {
> - .name = "IP0",
> - .num_nodes = 1,
> - .nodes = { &ipa_core_slave },
> -};
> -
> static struct qcom_icc_bcm bcm_mc0 = {
> .name = "MC0",
> .keepalive = true,
> @@ -2077,18 +2055,15 @@ static const struct qcom_icc_desc sc8280xp_aggre2_noc = {
> };
>
> static struct qcom_icc_bcm * const clk_virt_bcms[] = {
> - &bcm_ip0,
> &bcm_qup0,
> &bcm_qup1,
> &bcm_qup2,
> };
>
> static struct qcom_icc_node * const clk_virt_nodes[] = {
> - [MASTER_IPA_CORE] = &ipa_core_master,
Will the icc framework take a null entry gracefully?
Konrad
> [MASTER_QUP_CORE_0] = &qup0_core_master,
> [MASTER_QUP_CORE_1] = &qup1_core_master,
> [MASTER_QUP_CORE_2] = &qup2_core_master,
> - [SLAVE_IPA_CORE] = &ipa_core_slave,
> [SLAVE_QUP_CORE_0] = &qup0_core_slave,
> [SLAVE_QUP_CORE_1] = &qup1_core_slave,
> [SLAVE_QUP_CORE_2] = &qup2_core_slave,
> diff --git a/drivers/interconnect/qcom/sc8280xp.h b/drivers/interconnect/qcom/sc8280xp.h
> index 74d8fa412d65..c5c410fd5ec3 100644
> --- a/drivers/interconnect/qcom/sc8280xp.h
> +++ b/drivers/interconnect/qcom/sc8280xp.h
> @@ -10,7 +10,7 @@
> #define SC8280XP_MASTER_PCIE_TCU 1
> #define SC8280XP_MASTER_SYS_TCU 2
> #define SC8280XP_MASTER_APPSS_PROC 3
> -#define SC8280XP_MASTER_IPA_CORE 4
> +/* 4 was used by SLAVE_IPA_CORE, now represented as RPMh clock */
> #define SC8280XP_MASTER_LLCC 5
> #define SC8280XP_MASTER_CNOC_LPASS_AG_NOC 6
> #define SC8280XP_MASTER_CDSP_NOC_CFG 7
> @@ -84,7 +84,7 @@
> #define SC8280XP_MASTER_USB4_0 75
> #define SC8280XP_MASTER_USB4_1 76
> #define SC8280XP_SLAVE_EBI1 512
> -#define SC8280XP_SLAVE_IPA_CORE 513
> +/* 513 was used by SLAVE_IPA_CORE, now represented as RPMh clock */
> #define SC8280XP_SLAVE_AHB2PHY_0 514
> #define SC8280XP_SLAVE_AHB2PHY_1 515
> #define SC8280XP_SLAVE_AHB2PHY_2 516
next prev parent reply other threads:[~2023-01-09 13:49 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-09 0:29 [PATCH v3 00/12] clk/interconnect: qcom: finish migration of IP0 to clocks Dmitry Baryshkov
2023-01-09 0:29 ` [PATCH v3 01/12] interconnect: qcom: sdx55: drop IP0 remnants Dmitry Baryshkov
2023-01-09 13:43 ` Konrad Dybcio
2023-01-15 4:15 ` Manivannan Sadhasivam
2023-01-09 0:29 ` [PATCH v3 02/12] interconnect: qcom: sc7180: " Dmitry Baryshkov
2023-01-09 13:43 ` Konrad Dybcio
2023-01-09 0:29 ` [PATCH v3 03/12] interconnect: move ignore_list out of of_count_icc_providers() Dmitry Baryshkov
2023-01-09 13:44 ` Konrad Dybcio
2023-01-09 0:29 ` [PATCH v3 04/12] interconnect: qcom: sm8150: Drop IP0 interconnects Dmitry Baryshkov
2023-01-09 13:45 ` Konrad Dybcio
2023-01-09 0:29 ` [PATCH v3 05/12] interconnect: qcom: sm8250: " Dmitry Baryshkov
2023-01-09 13:45 ` Konrad Dybcio
2023-01-09 0:29 ` [PATCH v3 06/12] interconnect: qcom: sc8180x: " Dmitry Baryshkov
2023-01-09 13:46 ` Konrad Dybcio
2023-01-09 0:29 ` [PATCH v3 07/12] interconnect: qcom: sc8280xp: " Dmitry Baryshkov
2023-01-09 13:48 ` Konrad Dybcio [this message]
2023-01-09 0:29 ` [PATCH v3 08/12] dt-bindings: interconnect: qcom: Remove ipa-virt compatibles Dmitry Baryshkov
2023-01-09 0:29 ` [PATCH v3 09/12] dt-bindings: interconnect: qcom: drop IPA_CORE related defines Dmitry Baryshkov
2023-01-09 0:29 ` [PATCH v3 10/12] clk: qcom: rpmh: define IPA clocks where required Dmitry Baryshkov
2023-01-09 13:48 ` Konrad Dybcio
2023-01-09 0:29 ` [PATCH v3 11/12] arm64: dts: qcom: sm8150: drop the virtual ipa-virt device Dmitry Baryshkov
2023-01-09 13:49 ` Konrad Dybcio
2023-01-09 0:29 ` [PATCH v3 12/12] arm64: dts: qcom: sm8250: " Dmitry Baryshkov
2023-01-09 13:49 ` Konrad Dybcio
2023-01-12 16:12 ` (subset) [PATCH v3 00/12] clk/interconnect: qcom: finish migration of IP0 to clocks Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ddcd402-419c-cfc9-4b48-32186c3f18c2@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=elder@linaro.org \
--cc=johan@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_tdas@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).