From: Stephen Boyd <swboyd@chromium.org>
To: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Douglas Anderson <dianders@chromium.org>
Cc: Vinod Koul <vkoul@kernel.org>,
Kiran Gunda <kgunda@codeaurora.org>,
Rajendra Nayak <rnayak@codeaurora.org>,
mka@chromium.org, Sandeep Maheswaram <sanm@codeaurora.org>,
Amit Kucheria <amit.kucheria@linaro.org>,
Maulik Shah <mkshah@codeaurora.org>,
Douglas Anderson <dianders@chromium.org>,
Taniya Das <tdas@codeaurora.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH 7/7] arm64: dts: qcom: sc7180: Use 'ranges' in arm,armv7-timer-mem node
Date: Thu, 12 Dec 2019 13:55:29 -0800 [thread overview]
Message-ID: <5df2b752.1c69fb81.77c46.0f9a@mx.google.com> (raw)
In-Reply-To: <20191212113540.7.Ia9bd3fca24ad34a5faaf1c3e58095c74b38abca1@changeid>
Quoting Douglas Anderson (2019-12-12 11:35:43)
> Running `make dtbs_check` yells:
>
> arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml: timer@17c20000: #size-cells:0:0: 1 was expected
>
> It appears that someone was trying to assert the fact that sub-nodes
> describing frames would never have a size that's more than 32-bits
> big. That's certainly true in the case of sc7180.
>
> I guess this is a hint that it's time to do the thing that nobody
> seems to do but that "writing-bindings.txt" says we should all do.
> Specifically it says: "DO use non-empty 'ranges' to limit the size of
> child buses/devices". That means we should probably limit the
It got cut off here. I'm waiting to find out what it is!!
>
> I believe that this patch is the way to do it and there should be no
> bad side effects here. I believe that since we're far enough down
> (not trying to describe an actual device, just some sub-pieces) that
> this won't cause us to run into the problems that caused us to
> increase the soc-level #address-cells and #size-cells to 2 in sdm845
> in commit bede7d2dc8f3 ("arm64: dts: qcom: sdm845: Increase address
> and size cells for soc").
>
> I can at least confirm that "arch_mem_timer" seems to keep getting
> interrupts in "/proc/interrupts" after this change.
>
> Fixes: 90db71e48070 ("arm64: dts: sc7180: Add minimal dts/dtsi files for SC7180 soc")
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
This pattern exists in most of the qcom dts files. Can you fix all the
arm,armv7-timer-mem nodes. Maybe the binding has the same problem too in
the example.
>
> arch/arm64/boot/dts/qcom/sc7180.dtsi | 36 ++++++++++++++--------------
> 1 file changed, 18 insertions(+), 18 deletions(-)
>
next prev parent reply other threads:[~2019-12-12 21:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-12 19:35 [PATCH 0/7] arm64: dts: sc7180: Make dtbs_check mostly happy Douglas Anderson
2019-12-12 19:35 ` [PATCH 1/7] arm64: dts: qcom: sc7180: Add SoC name to compatible Douglas Anderson
2019-12-12 21:55 ` Stephen Boyd
2019-12-12 19:35 ` [PATCH 2/7] arm64: dts: qcom: sc7180: Rename gic-its node to msi-controller Douglas Anderson
2019-12-12 21:56 ` Stephen Boyd
2019-12-17 6:27 ` Doug Anderson
2019-12-12 19:35 ` [PATCH 3/7] arm64: dts: qcom: sc7180: Add "#clock-cells" property to usb_1_ssphy Douglas Anderson
2019-12-12 21:56 ` Stephen Boyd
2019-12-12 19:35 ` [PATCH 4/7] arm64: dts: qcom: pm6150: Remove macro from unit name of adc-chan Douglas Anderson
2019-12-12 21:56 ` Stephen Boyd
2019-12-12 19:35 ` [PATCH 5/7] arm64: dts: qcom: sc7180: Avoid "memory" for cmd-db reserved-memory node Douglas Anderson
2019-12-12 22:00 ` Stephen Boyd
2019-12-12 23:18 ` Bjorn Andersson
2019-12-12 19:35 ` [PATCH 6/7] arm64: dts: qcom: sc7180: Avoid "phy" for USB QMP PHY wrapper Douglas Anderson
2019-12-12 21:59 ` Stephen Boyd
2019-12-12 19:35 ` [PATCH 7/7] arm64: dts: qcom: sc7180: Use 'ranges' in arm,armv7-timer-mem node Douglas Anderson
2019-12-12 21:55 ` Stephen Boyd [this message]
2019-12-17 6:14 ` Doug Anderson
2019-12-12 23:21 ` [PATCH 0/7] arm64: dts: sc7180: Make dtbs_check mostly happy Bjorn Andersson
2019-12-13 4:06 ` Rajendra Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5df2b752.1c69fb81.77c46.0f9a@mx.google.com \
--to=swboyd@chromium.org \
--cc=agross@kernel.org \
--cc=amit.kucheria@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=kgunda@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mka@chromium.org \
--cc=mkshah@codeaurora.org \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=sanm@codeaurora.org \
--cc=tdas@codeaurora.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).