From: Stephen Boyd <swboyd@chromium.org>
To: Sibi Sankar <sibis@codeaurora.org>,
bjorn.andersson@linaro.org, rnayak@codeaurora.org,
robh+dt@kernel.org
Cc: agross@kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
mark.rutland@arm.com, dianders@chromium.org,
Sibi Sankar <sibis@codeaurora.org>
Subject: Re: [PATCH 1/2] dt-bindings: power: rpmpd: Convert rpmpd bindings to yaml
Date: Mon, 16 Dec 2019 11:35:18 -0800 [thread overview]
Message-ID: <5df7dc77.1c69fb81.9e37f.16a5@mx.google.com> (raw)
In-Reply-To: <20191216115531.17573-2-sibis@codeaurora.org>
Quoting Sibi Sankar (2019-12-16 03:55:30)
> Convert RPM/RPMH power-domain bindings to yaml.
>
> Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
One nitpick below!
> diff --git a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
> new file mode 100644
> index 0000000000000..4aebf024e4427
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
> @@ -0,0 +1,170 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/power/qcom,rpmpd.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm RPM/RPMh Power domains
> +
> +maintainers:
> + - Rajendra Nayak <rnayak@codeaurora.org>
> +
> +description:
> + For RPM/RPMh Power domains, we communicate a performance state to RPM/RPMh
> + which then translates it into a corresponding voltage on a rail
Add a full-stop here to make it a true sentence?
> +
> +properties:
> + compatible:
> + enum:
> + - qcom,msm8976-rpmpd
> + - qcom,msm8996-rpmpd
> + - qcom,msm8998-rpmpd
> + - qcom,qcs404-rpmpd
> + - qcom,sc7180-rpmhpd
> + - qcom,sdm845-rpmhpd
> + - qcom,sm8150-rpmhpd
> +
next prev parent reply other threads:[~2019-12-16 19:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 11:55 [PATCH 0/2] Add RPMH power-domain node for SC7180 SoCs Sibi Sankar
2019-12-16 11:55 ` [PATCH 1/2] dt-bindings: power: rpmpd: Convert rpmpd bindings to yaml Sibi Sankar
2019-12-16 19:35 ` Stephen Boyd [this message]
2019-12-17 10:11 ` Sibi Sankar
2019-12-17 10:31 ` Rajendra Nayak
2019-12-16 11:55 ` [PATCH 2/2] arm64: dts: qcom: sc7180: Add rpmh power-domain node Sibi Sankar
2019-12-16 19:36 ` Stephen Boyd
2019-12-17 10:31 ` Rajendra Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5df7dc77.1c69fb81.9e37f.16a5@mx.google.com \
--to=swboyd@chromium.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=sibis@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).