From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 436A419C546 for ; Mon, 30 Mar 2026 05:25:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774848315; cv=none; b=DMUf2x0OG4ITmlZBOqj1Kw9wSwGxclCgMNZXSwafUm3vFjssYGj2ZhWf/Y0s/woOFnefKgG6nFHE46sROxhAMFZWWy7pspItVZyw7QuzbrRhf5IRnkYV3N1uKCTi2nqCp8z84MoaXpne30bQe/savnYqlW6+TKTbl2iWTVUlXY8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774848315; c=relaxed/simple; bh=D3lO0lhg5hTvmGKJ2ae0KlsLLu8OpKls2Vh506RLu80=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JtccN5hrFrdI/N4yJFOII5gp/soqSJod2Q3XEYxra7+h3wDUeBY+9OE+f3onPeODd5sT5s/nVuNbiaNkdlksBZw9qJ/PpEGd5udGd2P4z0/J5AM+FP8nqnCCwAH6GnyyNiG2f6qiXcYmtzMBa7SgGM3lDmTyORAjcIkl5nGGzVg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=jk2MjDRJ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=CqOGOFr7; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="jk2MjDRJ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="CqOGOFr7" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62TNU1m22418508 for ; Mon, 30 Mar 2026 05:25:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= UmA43w79rLl8gL+6ejapyPIrbFnj/6/3VIIghM3uy5k=; b=jk2MjDRJU8RmKdg8 w/RB3dFeD7f0NRQSpbnWEdTb9j6GXYDMIc3qGNdzN1zA8OnLf59nAAmB1lOeU5B4 B9gsSdsj8soa1JH9pvVgGQ32Dc7eDyY99/uL5QryRwBGUxnwY0aMhXd0uqWuyLIA OYc4qzLzBgpkdKaCD/L5hQ+lMjeMQUG60ALhVbPW3SWoJQtsL8fFXhyfpIy6AEAu Tt/gOKaDOOFmjNrv3xVgLeuG1Dr8AjrP4Bsb6kJ47ibPsQo3oUKqsxZbQG+kgs2Z STMQkyQKYNrRATfYk9DOjG9nMWvvnZ+rfuSodfcKWmmwRrebaqAl4nJxNRzXQAzb b5TBRw== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d685hcetp-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 30 Mar 2026 05:25:13 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-3595485abbbso5405423a91.2 for ; Sun, 29 Mar 2026 22:25:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774848313; x=1775453113; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=UmA43w79rLl8gL+6ejapyPIrbFnj/6/3VIIghM3uy5k=; b=CqOGOFr7CLQohgEWMz7GFoCw+mFO+rATtzxbfPNE6vSeWSngULiUAQBLnxwpCNQQlk 68E2rKstMA1+RF3pWXHCo7cgKb4bY0JC2/pBTb3km8kCu27JvMguEXb6l8TW2b/3i1CI 84FbVOpZtRO0gzsScrDW/TgOOOujzM9PC+qIsQLCNL3hRtz5IU3oUTx9qEvisjDGA3vM 1retOuriDMTb3ubgCEp2PDcU7yJ2JLYyQNr9jmLdmmq9gOqO8ufD5vSg3/GItJqPCNvb LOxtGgHUuR6Q8NG+nJo4pEUcfqKOgJzqgqbVC8g3xBEZ6wNAcRk0CV2AYPMuxFKbkoKk 9CTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774848313; x=1775453113; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UmA43w79rLl8gL+6ejapyPIrbFnj/6/3VIIghM3uy5k=; b=bdR5AUhd6IIsf24Cnq1/b/frZU5kwQDMpgFTQu1FAHf3xC2JmNuHsGD0XRxdH2Sb9x KSVoJT6BxNMJC6ZuDL0vFUe5ZVnu4MYCykaR9Nuggq59bWIUx8WyQFRfr4y7i1xfWI7f xoi5/lKtETsTFGE2hocJny1QiR9fmsGSDVe7oayUFDp01XftVIHOR+Y3dwy53Hg6h0+Q Rohh8k7bzcqRs7ruBWT+4qLzhPbRRPTM7GYkh3/98fh2NbFhW345FMZt2w+TogNbFX1y iD3euHhXOilvXMWxKmccYB3Epe/C8qxgX7k8Nbb49xhCah7BDruzAvCmTYL4KPY8khZI 9dhQ== X-Forwarded-Encrypted: i=1; AJvYcCXr/vbQP+Ly7xtm2ORFPX4F/ERFH5hB+Txfb/WcQyuEPb8ltHwz9KDVVQTzsmwOApiYEinjV3ZrUscs@vger.kernel.org X-Gm-Message-State: AOJu0YzJG3ATzcTmOCLTA/an2qPRjTvXHu3i0GCbntYFI2vaFkbQNeYV /H32Q/JNXTP6ji9FyWL1NauxZWshuGfuaCbmTUSZTmSOChtHTDYZ7RR4JlM4ud1/4FfmNWKr7UN N1NpdbB3+8Ex5t49Okxx5h4JxHIngLLwiaJcsaS/Bd3Zqnc9OxSMgh6LSX0fklaoi X-Gm-Gg: ATEYQzzLqk/jp+Z/tfQinayjp0QIxtPsYXc7J8jGoaTZ6Nr+aIwJEF0j2vOERatQfTx mQh+1lW37ffgMXpjODCQnLKPNOTlPdQFqJjg6HV6gVSZqSXk0mR9xWzDj0AtYGLEkFYbNurmkMt SEhEHK9FXbYKNDO8PWOFTvpFoE+H9sHt2CU/AUQ8yzvd7d6c3XSvsEHk8MMmq1++4hB/Qjo23Ko QvresWOBd+24HF1hZvC7D2qMx4xsOxK5lr6BLEEBSpBl0S+xVmWN5fGhLUPb4p6WZH7nW9lDOlh ZCOJlWQJqi5HLbdLvUZrRjneXcBvvU863ZegBcKAHbJE4IlM0ShOWFVJ9VBIjQgKWP8/mIdVqFA fBlmKhqTWc3rUUEL0oqwvjQk8jY8aP8gNlNixxjsjO7SDOxvNMrbncA== X-Received: by 2002:a17:90b:3d86:b0:35d:b00a:3c54 with SMTP id 98e67ed59e1d1-35db00a416amr378962a91.22.1774848312866; Sun, 29 Mar 2026 22:25:12 -0700 (PDT) X-Received: by 2002:a17:90b:3d86:b0:35d:b00a:3c54 with SMTP id 98e67ed59e1d1-35db00a416amr378917a91.22.1774848312353; Sun, 29 Mar 2026 22:25:12 -0700 (PDT) Received: from [10.0.0.3] ([106.222.233.247]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35d950d9b12sm6892152a91.17.2026.03.29.22.25.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 29 Mar 2026 22:25:11 -0700 (PDT) Message-ID: <5e2635ac-35de-645b-b5e7-235923f844ce@oss.qualcomm.com> Date: Mon, 30 Mar 2026 10:55:02 +0530 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v5 2/5] media: iris: scale MMCX power domain on SM8250 Content-Language: en-US To: Dmitry Baryshkov , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Taniya Das , Jonathan Marek , Ulf Hansson , "Rafael J. Wysocki" , Bryan O'Donoghue , Vikash Garodia , Dikshita Agarwal , Mauro Carvalho Chehab , Stanimir Varbanov , Abhinav Kumar , Hans Verkuil , Stefan Schmidt , Konrad Dybcio , Bryan O'Donoghue , Dikshita Agarwal Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-media@vger.kernel.org, Mauro Carvalho Chehab References: <20260209-iris-venus-fix-sm8250-v5-0-0a22365d3585@oss.qualcomm.com> <20260209-iris-venus-fix-sm8250-v5-2-0a22365d3585@oss.qualcomm.com> From: Dikshita Agarwal In-Reply-To: <20260209-iris-venus-fix-sm8250-v5-2-0a22365d3585@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=csKWUl4i c=1 sm=1 tr=0 ts=69ca0939 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=5/Y9Gi2N1OwmQbPtUd2E/A==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=R0B0fMNruX7Akzlv-IwA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzMwMDAzOSBTYWx0ZWRfX0Noj+bXlereb 91VEEHD21GazwpLPRUjLFenv+WjbB0Wp37OqypZB+o3lL//rAZGcF6/7HGR8wrYZj1c/QIal1i+ ewTXZ4OOc3KFUjAC5/eXPoQ9TsZp1tfbFfQgVmn4bbO7KvigAwKQSyYv1Rcn1dXCeW1gkVE9apA 5Gn0slLuDKaVlgRnod6TDtAPAv5Yfn6nxywsyyFxOWIs8rcMhQ6aunryKkq+AocwCo1U3Yc/2gw H+ulyJlXdvcquylW0h1oQrYoxtV9gk8fuBuIm3i2Q/jgc8XjnpCfRufMDrC8jWXFr2M6lWNes+k DHVyTi13DrrTV5Z/YzRi66ZUH0kCMe2gXzl/Kyr9c1f9LhFpKluJUaCVm8XCY5Pt6gv6NmU0j51 BUO08Akif0q3JvBZMmO6JG4Dwj/FcGeBP/qFhl/QHXhCRv+n0NRHvwLbxnujaaYDws3keCRo4e7 RAN62ZF2biWmLwQq17g== X-Proofpoint-ORIG-GUID: mr-fvNXUhgtEALSo11RFkL0jGImSsAr9 X-Proofpoint-GUID: mr-fvNXUhgtEALSo11RFkL0jGImSsAr9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-29_05,2026-03-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 malwarescore=0 clxscore=1015 adultscore=0 impostorscore=0 priorityscore=1501 bulkscore=0 lowpriorityscore=0 suspectscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603300039 On 2/9/2026 7:02 AM, Dmitry Baryshkov wrote: > On SM8250 most of the video clocks are powered by the MMCX domain, while > the PLL is powered on by the MX domain. Extend the driver to support > scaling both power domains, while keeping compatibility with the > existing DTs, which define only the MX domain. > > Fixes: 79865252acb6 ("media: iris: enable video driver probe of SM8250 SoC") > Reviewed-by: Dikshita Agarwal > Signed-off-by: Dmitry Baryshkov > --- > drivers/media/platform/qcom/iris/iris_platform_gen1.c | 2 +- > drivers/media/platform/qcom/iris/iris_probe.c | 7 +++++++ > 2 files changed, 8 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/platform/qcom/iris/iris_platform_gen1.c b/drivers/media/platform/qcom/iris/iris_platform_gen1.c > index df8e6bf9430e..aa71f7f53ee3 100644 > --- a/drivers/media/platform/qcom/iris/iris_platform_gen1.c > +++ b/drivers/media/platform/qcom/iris/iris_platform_gen1.c > @@ -281,7 +281,7 @@ static const struct bw_info sm8250_bw_table_dec[] = { > > static const char * const sm8250_pmdomain_table[] = { "venus", "vcodec0" }; > > -static const char * const sm8250_opp_pd_table[] = { "mx" }; > +static const char * const sm8250_opp_pd_table[] = { "mx", "mmcx" }; > > static const struct platform_clk_data sm8250_clk_table[] = { > {IRIS_AXI_CLK, "iface" }, > diff --git a/drivers/media/platform/qcom/iris/iris_probe.c b/drivers/media/platform/qcom/iris/iris_probe.c > index 7b612ad37e4f..74ec81e3d622 100644 > --- a/drivers/media/platform/qcom/iris/iris_probe.c > +++ b/drivers/media/platform/qcom/iris/iris_probe.c > @@ -64,6 +64,13 @@ static int iris_init_power_domains(struct iris_core *core) > return ret; > > ret = devm_pm_domain_attach_list(core->dev, &iris_opp_pd_data, &core->opp_pmdomain_tbl); > + /* backwards compatibility for incomplete ABI SM8250 */ > + if (ret == -ENODEV && > + of_device_is_compatible(core->dev->of_node, "qcom,sm8250-venus")) { > + iris_opp_pd_data.num_pd_names--; > + ret = devm_pm_domain_attach_list(core->dev, &iris_opp_pd_data, > + &core->opp_pmdomain_tbl); > + } > if (ret < 0) > return ret; > > Hitting below compilation error on latest kernel drivers/media/platform/qcom/iris/iris_probe.c: In function ‘iris_init_power_domains’: drivers/media/platform/qcom/iris/iris_probe.c:71:46: error: decrement of read-only member ‘num_pd_names’ 71 | iris_opp_pd_data.num_pd_names--; Could you please check and fix. Thanks, Dikshita