From: Krzysztof Kozlowski <krzk@kernel.org>
To: Friday Yang <friday.yang@mediatek.com>,
Yong Wu <yong.wu@mediatek.com>, Rob Herring <robh@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Philipp Zabel <p.zabel@pengutronix.de>
Cc: linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH v11 1/2] dt-bindings: memory: mediatek: Add SMI reset and clamp for MT8188
Date: Sat, 18 Oct 2025 18:42:49 +0200 [thread overview]
Message-ID: <5e3a0317-31b2-43f1-9a4b-b66447a6044d@kernel.org> (raw)
In-Reply-To: <20250917120724.8650-2-friday.yang@mediatek.com>
On 17/09/2025 14:07, Friday Yang wrote:
> Add 'resets' and 'reset-names' properties for SMI LARBs to support
> SMI reset operations.
Not informative...
> diff --git a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml
> index 2e7fac4b5094..fc5feb2eac1f 100644
> --- a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml
> +++ b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml
> @@ -70,6 +70,12 @@ properties:
> description: the hardware id of this larb. It's only required when this
> hardware id is not consecutive from its M4U point of view.
>
> + resets:
> + maxItems: 1
> +
> + reset-names:
> + const: larb
Is the reset valid for all existing devices as well? Commit msg does not
explain that... it is pretty useless - you say what you did. We see that
from the diff. Explain something not obvious.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-10-18 16:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-17 12:07 [PATCH v11 0/2] Add SMI reset and clamp for MediaTek MT8188 SoC Friday Yang
2025-09-17 12:07 ` [PATCH v11 1/2] dt-bindings: memory: mediatek: Add SMI reset and clamp for MT8188 Friday Yang
2025-10-18 16:42 ` Krzysztof Kozlowski [this message]
2025-10-31 6:10 ` Friday Yang (杨阳)
2025-10-31 12:07 ` Krzysztof Kozlowski
2025-09-17 12:07 ` [PATCH v11 2/2] memory: mtk-smi: mt8188: Add SMI reset and clamp Friday Yang
2025-09-17 12:55 ` AngeloGioacchino Del Regno
2025-09-20 2:11 ` Yong Wu (吴勇)
2025-10-18 16:41 ` Krzysztof Kozlowski
2025-10-31 6:10 ` Friday Yang (杨阳)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e3a0317-31b2-43f1-9a4b-b66447a6044d@kernel.org \
--to=krzk@kernel.org \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=friday.yang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=yong.wu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).