From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17CBEC33CAC for ; Thu, 6 Feb 2020 19:08:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DF74420659 for ; Thu, 6 Feb 2020 19:08:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="VRaRJW1Y" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727938AbgBFTIG (ORCPT ); Thu, 6 Feb 2020 14:08:06 -0500 Received: from mail-pl1-f196.google.com ([209.85.214.196]:46522 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727906AbgBFTIG (ORCPT ); Thu, 6 Feb 2020 14:08:06 -0500 Received: by mail-pl1-f196.google.com with SMTP id y8so2696826pll.13 for ; Thu, 06 Feb 2020 11:08:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=message-id:mime-version:content-transfer-encoding:in-reply-to :references:subject:cc:to:from:user-agent:date; bh=Yu2QDav0lMyEABQNSAjZtJUdEYaLbzOvrURQHYilMW0=; b=VRaRJW1YHC6Yz1ba1KM+r2rAH78IAw4ECZ8uW10SXwNAHIWn7E+yTg0EHguOn/zRrt eMFPYSqUTeNMXsykpLoM4IV2tVHk0/uMr4OaXPJV8mcVbWOk0QE8XuGjrvBHau/XzuTz tHhIdvSd9A1QlCqSpwFwRf2PLIPuBTZQ+KwDc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:mime-version :content-transfer-encoding:in-reply-to:references:subject:cc:to:from :user-agent:date; bh=Yu2QDav0lMyEABQNSAjZtJUdEYaLbzOvrURQHYilMW0=; b=WFErOHfRsVdpg5ju+frI5JjVoFK91yuTtPutcgvpd8kMMDkPQAxDmJ4oG3qnEXyKGg MKKO3fLf37Ua0iswGFHBlDlO+cgTCxqZSFw/BkxC0CqE1FQbpAVif+Mbouy9y5MpsM2l tgC35JTcznZo3dh/xpune5QZQ1bzzdLfYgXswQovQpnFACXD7wDY3WXjZr9itsoX2PW6 U818DM4BaEXtOpQPN+kRa5alNUL0wzPLEVrOjXOWZyaM4Widx8VjMNf55NCuOtnO/WEx acHYmY+PkTOIFrRTuoO3E4lcTjobHY4ci8urWcbsUP+wff09LpKhrzEZ2h1GQL/ndGUq S4YQ== X-Gm-Message-State: APjAAAXpLQtU2a9jhsK6HTT8ijKDXmZc6pTylr1urLh5DKjBf3ZFiS06 8lDLZo1kaw3Vpq29JdjaA91sEw== X-Google-Smtp-Source: APXvYqw4FzuijgYSawjl5c7tObZjQNWODBQFdG4z93eiZtWw8Kfhehai1gG8W0VsIPSAuMTH3ojcqQ== X-Received: by 2002:a17:902:9691:: with SMTP id n17mr5606416plp.304.1581016085712; Thu, 06 Feb 2020 11:08:05 -0800 (PST) Received: from chromium.org ([2620:15c:202:1:fa53:7765:582b:82b9]) by smtp.gmail.com with ESMTPSA id q28sm145590pfl.153.2020.02.06.11.08.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Feb 2020 11:08:05 -0800 (PST) Message-ID: <5e3c6415.1c69fb81.11c79.08a6@mx.google.com> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <1580997328-16365-2-git-send-email-kgunda@codeaurora.org> References: <1580997328-16365-1-git-send-email-kgunda@codeaurora.org> <1580997328-16365-2-git-send-email-kgunda@codeaurora.org> Subject: Re: [PATCH V3 2/2] mfd: qcom-spmi-pmic: Add support for pm6150 and pm6150l Cc: rnayak@codeaurora.org, Kiran Gunda To: Andy Gross , Bjorn Andersson , Kiran Gunda , Lee Jones , Mark Rutland , Rob Herring , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org From: Stephen Boyd User-Agent: alot/0.8.1 Date: Thu, 06 Feb 2020 11:08:04 -0800 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Quoting Kiran Gunda (2020-02-06 05:55:27) > Add the compatibles and PMIC ids for pm6150 and pm6150l PMICs > found on SC7180 based platforms >=20 > Signed-off-by: Kiran Gunda > --- > Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 2 ++ > drivers/mfd/qcom-spmi-pmic.c | 4 ++++ > 2 files changed, 6 insertions(+) >=20 > diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/= Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml > index affc169..36f0795 100644 > --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml > +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml > @@ -46,6 +46,8 @@ properties: > - qcom,pm8998 > - qcom,pmi8998 > - qcom,pm8005 > + - qcom,pm6150 > + - qcom,pm6150l > - qcom,spmi-pmic Maybe the yaml binding needs to say this is sorted in subtype id in a comment. # Sorted based on subtype ID the device reports Or we should sort this list in the binding and sort the compatible string table in the driver with a comment that it's sorted based on subtype id. > =20 > reg: > diff --git a/drivers/mfd/qcom-spmi-pmic.c b/drivers/mfd/qcom-spmi-pmic.c > index 1df1a27..5bfeec8 100644 > --- a/drivers/mfd/qcom-spmi-pmic.c > +++ b/drivers/mfd/qcom-spmi-pmic.c > @@ -36,6 +36,8 @@ > #define PM8998_SUBTYPE 0x14 > #define PMI8998_SUBTYPE 0x15 > #define PM8005_SUBTYPE 0x18 > +#define PM6150L_SUBTYPE 0x1F > +#define PM6150_SUBTYPE 0x28 > =20 > static const struct of_device_id pmic_spmi_id_table[] =3D { > { .compatible =3D "qcom,spmi-pmic", .data =3D (void *)COMMON_SUBT= YPE }, > @@ -57,6 +59,8 @@ static const struct of_device_id pmic_spmi_id_table[] = =3D { > { .compatible =3D "qcom,pm8998", .data =3D (void *)PM8998_SUBT= YPE }, > { .compatible =3D "qcom,pmi8998", .data =3D (void *)PMI8998_SUB= TYPE }, > { .compatible =3D "qcom,pm8005", .data =3D (void *)PM8005_SUBT= YPE }, > + { .compatible =3D "qcom,pm6150l", .data =3D (void *)PM6150L_SUB= TYPE }, > + { .compatible =3D "qcom,pm6150", .data =3D (void *)PM6150_SUBT= YPE }, > { } > };