Re: [PATCH 2/2] arm64: tegra: Add thermal support for Tegra234

[Jon Hunter <jonathanh@nvidia.com>]

On 24/01/2023 11:51, Jon Hunter wrote:
> From: Yi-Wei Wang <yiweiw@nvidia.com>
> 
> Add the BPMP thermal device node and thermal-zones for Tegra234 and
> enable thermal support for the Tegra234 Jetson AGX Orin board.
> 
> Signed-off-by: Yi-Wei Wang <yiweiw@nvidia.com>
> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
> ---
>   .../boot/dts/nvidia/tegra234-p3701-0000.dtsi  | 276 ++++++++++++++++++
>   .../nvidia/tegra234-p3737-0000+p3701-0000.dts |  32 ++
>   arch/arm64/boot/dts/nvidia/tegra234.dtsi      |  59 ++++
>   3 files changed, 367 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/nvidia/tegra234-p3701-0000.dtsi b/arch/arm64/boot/dts/nvidia/tegra234-p3701-0000.dtsi
> index 2378da324273..7f798742df43 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra234-p3701-0000.dtsi
> +++ b/arch/arm64/boot/dts/nvidia/tegra234-p3701-0000.dtsi
> @@ -80,6 +80,22 @@ pmc@c360000 {
>   		};
>   	};
>   
> +	bpmp {
> +		i2c {
> +			tegra_tmp451: thermal-sensor@4c {
> +				compatible = "ti,tmp451";
> +				reg = <0x4c>;
> +				vcc-supply = <&vdd_1v8_ao>;
> +				#thermal-sensor-cells = <1>;
> +				status = "okay";
> +			};
> +		};
> +
> +		thermal {
> +			status = "okay";
> +		};
> +	};
> +
>   	vdd_5v0_sys: regulator-vdd-5v0-sys {
>   		compatible = "regulator-fixed";
>   		regulator-name = "VIN_SYS_5V0";
> @@ -139,4 +155,264 @@ vdd_12v_pcie: regulator-vdd-12v-pcie {
>   		gpio = <&gpio TEGRA234_MAIN_GPIO(A, 1) GPIO_ACTIVE_LOW>;
>   		regulator-boot-on;
>   	};
> +
> +	thermal-zones {
> +		cpu-thermal {
> +			polling-delay = <1000>;
> +			polling-delay-passive = <1000>;
> +			thermal-sensors = <&{/bpmp/thermal} TEGRA234_THERMAL_ZONE_CPU>;
> +			status = "okay";
> +
> +			trips {
> +				cpu_sw_shutdown: cpu-sw-shutdown {
> +					temperature = <104500>;
> +					hysteresis = <0>;
> +					type = "critical";
> +				};
> +
> +				cpu_sw_throttle: cpu-sw-throttle {
> +					temperature = <99000>;
> +					hysteresis = <0>;
> +					type = "passive";
> +				};
> +			};
> +
> +			cooling-maps {
> +				map0 {
> +					trip = <&cpu_sw_throttle>;
> +					cooling-device = <&cpu0_0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> +							 <&cpu1_0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> +							 <&cpu2_0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> +				};
> +			};
> +		};
> +
> +		gpu-thermal {
> +			polling-delay = <1000>;
> +			polling-delay-passive = <1000>;
> +			thermal-sensors = <&{/bpmp/thermal} TEGRA234_THERMAL_ZONE_GPU>;
> +			status = "okay";
> +			status = "disabled";

Looks like I messed this up. I will send a V2 to fix.

Jon

-- 
nvpublic