From: Paul Burton <paulburton@kernel.org>
To: "周琰杰 (Zhou Yanjie)" <zhouyanjie@wanyeetech.com>
Cc: linux-mips@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
paul@crapouillou.net, robh+dt@kernel.org, mark.rutland@arm.com,
ralf@linux-mips.org, paulburton@kernel.org,
sernia.zhou@foxmail.com, zhenwenjin@gmail.com,
dongsheng.qiu@ingenic.com
Cc: linux-mips@vger.kernel.org
Subject: Re: [PATCH] MIPS: X1000: Fix clock of watchdog node.
Date: Wed, 19 Feb 2020 11:01:56 -0800 [thread overview]
Message-ID: <5e4d862a.1c69fb81.5dc73.17b5@mx.google.com> (raw)
In-Reply-To: <1581855028-25552-3-git-send-email-zhouyanjie@wanyeetech.com>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1179 bytes --]
Hello,
周琰杰 (Zhou Yanjie) wrote:
> The devicetree ABI was broken on purpose by commit 6d532143c915
> ("watchdog: jz4740: Use regmap provided by TCU driver"), and
> commit 1d9c30745455 ("watchdog: jz4740: Use WDT clock provided
> by TCU driver"). The commit message of the latter explains why the ABI
> was broken.
>
> However, the current devicetree files were not updated to the new ABI
> described in Documentation/devicetree/bindings/timer/ingenic,tcu.txt,
> so the watchdog driver would not probe.
>
> Fix this problem by updating the clock of watchdog node from
> "&cgu X1000_CLK_RTCLK" to "&tcu TCU_CLK_WDT" to comply with the new
> ABI.
>
> Fixes: 7a16ccd300c2 ("[v8,1/4] MIPS: Ingenic: Add Ingenic X1000
> support.").
Applied to mips-fixes.
> commit eb41113870c9
> https://git.kernel.org/mips/c/eb41113870c9
>
> Fixes: 7a16ccd300c2 ("[v8,1/4] MIPS: Ingenic: Add Ingenic X1000 support.").
> Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>
> Signed-off-by: Paul Burton <paulburton@kernel.org>
Thanks,
Paul
[ This message was auto-generated; if you believe anything is incorrect
then please email paulburton@kernel.org to report it. ]
prev parent reply other threads:[~2020-02-19 19:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-16 12:10 Fix clock of X1000 watchdog node 周琰杰 (Zhou Yanjie)
2020-02-16 12:10 ` [PATCH] " 周琰杰 (Zhou Yanjie)
2020-02-16 12:10 ` [PATCH] MIPS: X1000: Fix clock of " 周琰杰 (Zhou Yanjie)
2020-02-19 19:01 ` Paul Burton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e4d862a.1c69fb81.5dc73.17b5@mx.google.com \
--to=paulburton@kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=zhouyanjie@wanyeetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).