From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37228C001B0 for ; Mon, 17 Jul 2023 06:36:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229588AbjGQGgF (ORCPT ); Mon, 17 Jul 2023 02:36:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37430 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229587AbjGQGgD (ORCPT ); Mon, 17 Jul 2023 02:36:03 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1EA23E9; Sun, 16 Jul 2023 23:36:02 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7FCED60F5D; Mon, 17 Jul 2023 06:36:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AF51BC433CA; Mon, 17 Jul 2023 06:35:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689575760; bh=CcL6kmNEqvVjt0DsY1Zq8glXhJJSkIlcA2Roz493NaA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=L67EcV+jfNrUWt4tNqqN0ZroKPdED1hism02sKPa831oaiwkrfHMlSIEWB7lYUEkm vAUFQX+v6zZ6O6GrlhJVkVzs8eaI3G0wSMjZl9r8XBZ0gPrgEd5tBftcQ1jdF3rNQI HaXC4oOC3YSzYmdt/oj2co2n314xC87yXIFO4hr/0DE6ca9reWmh5tAjCL8RwghCA7 5FBq+2TWmgnai2rFnMISYhkN/ZDq7kYWrrPcv/Y5V+R8Ih+hfMuK6ydFANAneCyeyg Azp+WFwN46cQcRQxA/kZZFAFPy9QtmVgZxZSgaOyhJ+chB7xXsgyt4fT0dkpPvVPYh cuquHQvdnKyWg== Message-ID: <5e5d1a1e-f106-9dd6-c19e-f933e8e70dd4@kernel.org> Date: Mon, 17 Jul 2023 08:35:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2 1/2] dt-bindings: iio: dac: add mcp4728.yaml Content-Language: en-US To: Andrea Collamati Cc: Jonathan Cameron , Rob Herring , Conor Dooley , William Breathitt Gray , Angelo Dureghello , Fabio Estevam , Lukas Bulwahn , "linux-iio@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 16/07/2023 23:26, Andrea Collamati wrote: > Add documentation for mcp4728 > > Signed-off-by: Andrea Collamati What changed? Where is the changelog? Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC (and consider --no-git-fallback argument). It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. > --- > .../bindings/iio/dac/microchip,mcp4728.yaml | 42 +++++++++++++++++++ > 1 file changed, 42 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/dac/microchip,mcp4728.yaml > > diff --git a/Documentation/devicetree/bindings/iio/dac/microchip,mcp4728.yaml b/Documentation/devicetree/bindings/iio/dac/microchip,mcp4728.yaml > new file mode 100644 > index 000000000000..c971d34794db > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/dac/microchip,mcp4728.yaml > @@ -0,0 +1,42 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/dac/microchip,mcp4728.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Microchip mcp4728 DAC > + > +maintainers: > + - Andrea Collamati > + > +properties: > + compatible: > + enum: > + - microchip,mcp4728 No improvements. > + reg: > + maxItems: 1 > + > + vdd-supply: > + description: | > + Provides both power and acts as the reference supply on the mcp4728 > + when Internal Vref is not selected. > + > +required: > + - compatible > + - reg > + - vdd-supply > + > +additionalProperties: false > + > +examples: > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + mcp4728@60 { This is a friendly reminder during the review process. It seems my previous comments were not fully addressed. Maybe my feedback got lost between the quotes, maybe you just forgot to apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them. All of the comments seem to be ignored. I don't understand why you decided not to respond to me. To clarify: there is already binding for it - mcp4725. Best regards, Krzysztof