Re: [PATCH v2] ARM: dts: aspeed: Enable networking for Asus Kommando IPMI Card

[Andrew Jeffery <andrew@codeconstruct.com.au>]

On Fri, 2026-05-22 at 14:05 +0200, Andrew Lunn wrote:
> On Thu, May 21, 2026 at 10:49:24PM -0500, Anirudh Srinivasan wrote:
> > Hi Andrew,
> > 
> > On Tue, Mar 31, 2026 at 9:18 AM Anirudh Srinivasan
> > <anirudhsriniv@gmail.com> wrote:
> > > 
> > > Adds the DT nodes needed for ethernet support for Asus Kommando, with
> > > phy mode set to rgmii-id.
> > > 
> > > When this DT was originally added, the phy mode was set to rgmii (which
> > > was incorrect). It was suggested to remove networking support from the
> > > DT till the Aspeed networking driver was patched so that the correct phy
> > > mode could be used.
> > > 
> > > The discussion in [1] mentions that u-boot was inserting clk delays that
> > > weren't needed, which resulted in needing to set the phy mode in linux
> > > to rgmii incorrectly. The solution suggested there was to patch u-boot to
> > > no longer insert these clk delays and use rgmii-id as the phy mode for
> > > any future DTs added to linux.
> > > 
> > > This DT was tested (on the OpenBMC u-boot fork [2]) with a u-boot DT
> > > modified to insert clk delays of 0 (instead of patching u-boot itself).
> > > [3] adds a u-boot DT for this device (without networking) and describes
> > > how to patch it to add networking support. If this patched DT is used,
> > > then networking works with rgmii-id phy mode in both u-boot and linux.
> > > 
> > > [1] https://lore.kernel.org/linux-aspeed/ef88bb50-9f2c-458d-a7e5-dc5ecb9c777a@lunn.ch/
> > > [2] https://github.com/openbmc/u-boot/tree/v2019.04-aspeed-openbmc
> > > [3] https://lore.kernel.org/openbmc/20260328-asus-kommando-v2-1-2a656f8cd314@gmail.com/
> > > 
> > > Signed-off-by: Anirudh Srinivasan <anirudhsriniv@gmail.com>
> > > ---
> > > This patch is based off aspeed/arm/dt from bmc tree
> > > ---
> > > Changes in v2:
> > > - Commit message now mentions that the u-boot tested against is the
> > >   openbmc u-boot fork
> > > - Link to v1: https://lore.kernel.org/r/20260328-asus-kommando-networking-v1-1-66d308b88536@gmail.com
> > > ---
> > >  .../dts/aspeed/aspeed-bmc-asus-kommando-ipmi-card.dts  | 18 ++++++++++++++++++
> > >  1 file changed, 18 insertions(+)
> > > 
> > > diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-asus-kommando-ipmi-card.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-asus-kommando-ipmi-card.dts
> > > index ab7ad320067c1ddc0fea9ac386fd488c8ef28184..e0f7d92efa18ccbad2c336236c3b9d01b7de1bba 100644
> > > --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-asus-kommando-ipmi-card.dts
> > > +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-asus-kommando-ipmi-card.dts
> > > @@ -107,6 +107,24 @@ &gpio1 {
> > >         /*18E0 32*/ "","","","","","","","";
> > >  };
> > > 
> > > +&mac2 {
> > > +       status = "okay";
> > > +
> > > +       phy-mode = "rgmii-id";
> > > +       phy-handle = <&ethphy2>;
> > > +       pinctrl-names = "default";
> > > +       pinctrl-0 = <&pinctrl_rgmii3_default>;
> > > +};
> > > +
> > > +&mdio2 {
> > > +       status = "okay";
> > > +
> > > +       ethphy2: ethernet-phy@0 {
> > > +               compatible = "ethernet-phy-ieee802.3-c22";
> > > +               reg = <0>;
> > > +       };
> > > +};
> > > +
> > >  &vhub {
> > >         status = "okay";
> > >  };
> > > 
> > > ---
> > > base-commit: 76b4ec8efdc3887cdbf730da2e55881fc1a18770
> > > change-id: 20260328-asus-kommando-networking-5c0612aa6b8c
> > > 
> > > Best regards,
> > > --
> > > Anirudh Srinivasan <anirudhsriniv@gmail.com>
> > > 
> > 
> > While we're figuring out what to do with u-boot, what are your
> > thoughts on getting this patch in so that the kernel DTS changes
> > needed for networking land in this cycle?
> > 
> > The current commit message might become somewhat outdated if the
> > u-boot patch changes though, so not sure if that's okay.
> 
> The commit message explains "Why?", which is what is important. So it
> should not matter if it becomes outdated. And the DT is correct, no
> matter how the issue is solved.

Yeah, this was my thought too, so I intend to apply it.

> 
> So i'm O.K. with this.

Thanks

Andrew