From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 703E526FDB0 for ; Fri, 18 Apr 2025 09:51:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744969887; cv=none; b=FhPKbCwIuGTPdlY/T31DjkTUqN+7k5feDZ5Rhu5z3ExAC+GlNid70zmOkTQTZ+bwISB+qizQJFkcRiToHIpAgFCuCmhAgVO1XDr0FbdLmF6SiN8Ca39Xx3/EwhxChRW17Gd1hmZC17ZS+0082bGRAyFreZN2YG7/COXiXor8toM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744969887; c=relaxed/simple; bh=LSv2LPESZn+oRo8x96FVTGHst4ynm5FV4i+s/CjsLEo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cmSptbM3jjrPZBHVhHhaf7Bw6brVBeKkwpNYzWzZZ7ON/BeKT3eBNu/w1NU0BW+jxyCzLLeUQWfz7shCo5AHfrc017UFNGJpI7uHFYNG4fWFFCOTXsHIKYJv/NpN535rN0jnDGd466cVD67cGoB1BAV2/COi94YGRFPuWVQhW8g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=HwwhoVLE; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="HwwhoVLE" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 53I27gDl023428 for ; Fri, 18 Apr 2025 09:51:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= rA3sdyVQ16H8kPttRg91Jt1G7uDSj/gcw6eTTAKQB5c=; b=HwwhoVLEu9m/84c/ izpixz+E1FYpZpSYEhwGskeFb8/7o9N2GWSo62T5C4Diwsr/dxEMUQzCUklx4rg3 jnksSTFHQQo+UPXubMSkt914vvoRX317E3k/+WTh1V469h5y3QBBQnAkdMi6GALQ avc036Vf/bnYej3fUw8Wjkc2piUyI75EhILfq4XKjRJ1kvnJX4b2X3TSDsxj35Rh Du8dvHU4r+6wdK37romVDqsSMpbgUDAXLo9jGTg8owSAaAR4vjF/uLGi5N/EcC6d 1wL6M8Vqyp6wKUJCN67m88CLdrSCHb+PDt7d163csMLgtI0ccEQy1OaV/d6cN6Bc vIiapw== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 45yhbq1ccp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 18 Apr 2025 09:51:23 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-7c5af539464so43633385a.0 for ; Fri, 18 Apr 2025 02:51:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744969882; x=1745574682; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rA3sdyVQ16H8kPttRg91Jt1G7uDSj/gcw6eTTAKQB5c=; b=xPsV99LGI8I/VY44I93kyLF6LA1X2tSuP1/to644Y2CZhrDwncKaUym9Zf71G5+NkC 2lBY0i8s7gLmGZAm+DHWCIiEm3c9dBuqy/b9N1iYJ979uhV6dg1qDAglZwlYSLx/8B6b jXiZRkiCehWpxVyXjpfLnwKIXfjPUdTdNFngusjstJo5euA/HjEnUDfpwPT/lWAXovvt x7wO7V8KRXslzKO8boJ9FWPd+kjUjsxk+HhQJTHOc+rtb6Kr+rECZUoieik/CHw9t9Uy bYC8wc7QzonbOSvCFLchkWmHwRfwzd8h95zdDy6lpiBBC7KIrnpIk2lOcIt3G3AK5a1p 3Y5Q== X-Forwarded-Encrypted: i=1; AJvYcCWdPk3M6IOdJnstv8QrKMWf4fW8vkW+/LXeHllQGLKssPQrhbWJl2/GY/OmQ1U2kkWHTXx2FqcJ/8GF@vger.kernel.org X-Gm-Message-State: AOJu0Yzg3T33qqho9ddvOrlb1hDNRawW9lAyl/LL7Zhg9aseVy91Smur hX7j49Ztg5msnCstNjlyd4CbymHTd05lgTc7GLKLb71INCQwetJULMfFgCsBUjw4mj4/PSzEeBx zkl04Xd5Z2cs1zwsbhWZFDv6nftOBLzUbMcGscTl1dAYXANA//zqgVPRiPrKT X-Gm-Gg: ASbGncvr4r8mxdxTwl8b4wZaKJPk2uQCZWz4bHX7IBLMRPIJGx/sX+LZim1fgEQr/kA 0KUI4XF2d+2ixYyittt4JCeDEpYdElLLwLhMAaYeVpD3ebqk260+3drriRUWCxtZbxQLIS58AYg pKr9Yy+dxEYx8LGalnguUICwxaNvZ93yqLdltezdoVMpmnEy7TeW/wFGQu1CinuE/TdnC9DZanx rBGhMK+jU2Hxc2vZLuY5qgyG89lrN09KW5hvVejafX0EcdWHClKKMViZodByQcNTUl7UT8LiKWz 21kqDoMecOyLGJRSpzlCFPkKEp8GQQznFLyC6bpQSjUZzLQecJThbniVSmt0g7u+wA== X-Received: by 2002:a05:620a:2592:b0:7c5:8ece:8b56 with SMTP id af79cd13be357-7c927f9a9f9mr101648585a.4.1744969882146; Fri, 18 Apr 2025 02:51:22 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGqDwroTCof2h7lnX1zVhtLN5ZBbsfi9HNceZCvlYWCbV0282LNM0+SsV1JAE41A/dMk5vamA== X-Received: by 2002:a05:620a:2592:b0:7c5:8ece:8b56 with SMTP id af79cd13be357-7c927f9a9f9mr101647585a.4.1744969881711; Fri, 18 Apr 2025 02:51:21 -0700 (PDT) Received: from [192.168.65.58] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-acb6ec0c64csm102377266b.13.2025.04.18.02.51.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Apr 2025 02:51:21 -0700 (PDT) Message-ID: <5e6a3c7e-4e58-4e42-ac31-3666f49d07f6@oss.qualcomm.com> Date: Fri, 18 Apr 2025 11:51:17 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 2/2] arm64: dts: qcom: sa8775p: Add support for camss To: Vikram Sharma , Konrad Dybcio , rfoss@kernel.org, todor.too@gmail.com, bryan.odonoghue@linaro.org, mchehab@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, andersson@kernel.org, konradybcio@kernel.org, hverkuil-cisco@xs4all.nl, cros-qcom-dts-watchers@chromium.org, catalin.marinas@arm.com, will@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Suresh Vankadara References: <20250210155605.575367-1-quic_vikramsa@quicinc.com> <20250210155605.575367-3-quic_vikramsa@quicinc.com> <65663927-cc11-4810-8714-7600786f299b@oss.qualcomm.com> <7fd92093-3efc-4f24-967d-7e267162b26d@quicinc.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <7fd92093-3efc-4f24-967d-7e267162b26d@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: aUnx-j3E8dMnkR4cqFGpT-DXzkndcdch X-Proofpoint-GUID: aUnx-j3E8dMnkR4cqFGpT-DXzkndcdch X-Authority-Analysis: v=2.4 cv=I+plRMgg c=1 sm=1 tr=0 ts=6802209b cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=XR8D0OoHHMoA:10 a=COk6AnOGAAAA:8 a=-5tugLDAGQjhnTpWTo4A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-18_02,2025-04-17_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 phishscore=0 adultscore=0 priorityscore=1501 mlxscore=0 lowpriorityscore=0 bulkscore=0 mlxlogscore=993 clxscore=1015 impostorscore=0 malwarescore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2504180072 On 4/18/25 9:28 AM, Vikram Sharma wrote: > > On 4/14/2025 7:18 PM, Konrad Dybcio wrote: >> On 2/10/25 4:56 PM, Vikram Sharma wrote: >>> Add changes to support the camera subsystem on the SA8775P. >>> >>> Co-developed-by: Suresh Vankadara >>> Signed-off-by: Suresh Vankadara >>> Signed-off-by: Vikram Sharma >>> --- >> [...] >> >>> +            interrupts = , >>> +                     , >>> +                     , >>> +                     , >>> +                     , >> 760> +                     , > > Hi Konrad, > > We cross checked internal documents to confirm IRQ number for csid_lite2/3 and vfe_lite2/3 > Calculation for IRQ number is done with respect to vector number as > irq_num = (vector - 32). > csid_lite2 vector -> 791 > csid_lite3 vector -> 790 > vfe_lite2  vector -> 793 > vfe_lite3  vector -> 792 > > thus irqs are as > csid_lite2 -> 759 > csid_lite3 -> 758 > vfe_lite2  -> 761 > vfe_lite3  -> 760 > > Please let me know if this looks fine to you? We had a similar issue with qcs8300 - the reported vector id skipped a number at some point. In that case the SPI ports indices alongside them were advised to be used. Please check with the HW team, but I suppose this would be the case for this one too. Konrad