From: Denis Benato <benato.denis96@gmail.com>
To: Jagath Jog J <jagathjog1996@gmail.com>,
Jonathan Cameron <jic23@kernel.org>
Cc: andriy.shevchenko@linux.intel.com, lars@metafoo.de,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC 2/2] iio: imu: Add driver for BMI323 IMU
Date: Wed, 27 Sep 2023 23:25:04 +0200 [thread overview]
Message-ID: <5eb148b4-25eb-460d-9ec8-0a40bec1dc6f@gmail.com> (raw)
In-Reply-To: <CAM+2EuJBxj7P-ymu84u308g8LCemSEsYi_TSHYtaK9PyrhqrfA@mail.gmail.com>
Hello,
Some devices (as my asus rog ally) have an ACPI node describing a BOSC0200 sensor. The IC being used in those devices is a bmi323 but as a result of how the ACPI table reports that device, it is detected by the existing kernel module and we have no way of differentiating until after the chip ID probe.
The module loaded is bmc150-accel-i2c.c which currently doesn't support the bmi323 and the loading of the module just fails at chip check.
I have solved the problem by expanding the current bmc150-accel-i2c.c and bmc150-accel-core.c files to handle that IC in almost every part: gyroscope, accelerometer and temperature sensor.
What is the best way of organizing code to have this module mainlined? Is it correct leaving files called bmc150-accel-* even if it is managing another IC and and not just the accelerometer part anymore?
TIA for your time.
Best regards,
Denis Benato
next prev parent reply other threads:[~2023-09-27 21:25 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-18 8:03 [RFC 0/2] iio: imu: Add driver and dt-bindings for BMI323 Jagath Jog J
2023-09-18 8:03 ` [RFC 1/2] dt-bindings: iio: imu: Add DT binding doc " Jagath Jog J
2023-09-18 12:25 ` Krzysztof Kozlowski
2023-09-19 16:44 ` Jagath Jog J
2023-09-24 13:31 ` Jonathan Cameron
2023-09-27 21:37 ` Jagath Jog J
2023-09-24 13:37 ` Jonathan Cameron
2023-09-27 21:37 ` Jagath Jog J
2023-09-30 16:05 ` Jonathan Cameron
2023-10-08 6:24 ` Jagath Jog J
2023-10-10 9:00 ` Jonathan Cameron
2023-10-10 9:06 ` Linus Walleij
2023-10-10 14:42 ` Jonathan Cameron
2023-10-10 19:51 ` Linus Walleij
2023-10-13 8:16 ` Jonathan Cameron
2023-10-13 16:23 ` Jagath Jog J
2023-09-18 8:03 ` [RFC 2/2] iio: imu: Add driver for BMI323 IMU Jagath Jog J
2023-09-18 10:03 ` Andy Shevchenko
2023-09-19 22:43 ` Jagath Jog J
2023-09-20 13:24 ` Andy Shevchenko
2023-10-08 6:25 ` Jagath Jog J
2023-10-10 9:02 ` Jonathan Cameron
2023-09-24 14:30 ` Jonathan Cameron
2023-09-27 19:59 ` Jagath Jog J
2023-09-27 21:25 ` Denis Benato [this message]
2023-09-29 7:59 ` Jagath Jog J
2023-09-30 16:17 ` Jonathan Cameron
2023-10-01 13:53 ` Denis Benato
2023-10-03 20:35 ` Jagath Jog J
2023-09-30 16:13 ` Jonathan Cameron
2023-09-27 9:57 ` Uwe Kleine-König
2023-09-27 12:35 ` Andy Shevchenko
2023-09-27 14:34 ` Uwe Kleine-König
2023-10-01 8:20 ` Andy Shevchenko
2023-09-28 18:19 ` Jagath Jog J
2023-09-28 20:48 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5eb148b4-25eb-460d-9ec8-0a40bec1dc6f@gmail.com \
--to=benato.denis96@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=jagathjog1996@gmail.com \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).