Re: [PATCH 1/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynos850

[Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>]

On 07/12/2022 09:58, Sriranjani P wrote:
> Exynos850 has two different SYSREGs, hence add dedicated compatibles for
> them and deprecate usage of generic Exynos850 compatible alone.
> 
> Signed-off-by: Sriranjani P <sriranjani.p@samsung.com>
> ---
>  .../soc/samsung/samsung,exynos-sysreg.yaml        | 15 +++++++++++++--
>  1 file changed, 13 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
> index 4954790eda6c..f57bc7c194a1 100644
> --- a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
> +++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
> @@ -17,7 +17,6 @@ properties:
>                - samsung,exynos3-sysreg
>                - samsung,exynos4-sysreg
>                - samsung,exynos5-sysreg
> -              - samsung,exynos850-sysreg
>                - samsung,exynosautov9-sysreg
>                - tesla,fsd-cam-sysreg
>                - tesla,fsd-fsys0-sysreg
> @@ -36,6 +35,16 @@ properties:
>            - const: samsung,exynos5433-sysreg
>            - const: syscon
>          deprecated: true
> +      - items:
> +          - enum:
> +              - samsung,exynos850-cmgp-sysreg
> +              - samsung,exynos850-peri-sysreg
> +          - const: samsung,exynos850-sysreg
> +          - const: syscon
> +      - items:
> +          - const: samsung,exynos850-sysreg

and this can go to existing 5433 deprecated entry (making it enum of
deprecated compatibles).

> +          - const: syscon
> +        deprecated: true
>  
>    reg:
>      maxItems: 1
> @@ -53,7 +62,9 @@ allOf:
>          compatible:
>            contains:
>              enum:
> -              - samsung,exynos850-sysreg
> +              - samsung,exynos850-cmgp-sysreg
> +              - samsung,exynos850-peri-sysreg
> +            const: samsung,exynos850-sysreg

This should stay in the enum.

Best regards,
Krzysztof