From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BEDDC636CC for ; Tue, 31 Jan 2023 17:59:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230138AbjAaR7m (ORCPT ); Tue, 31 Jan 2023 12:59:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58240 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229647AbjAaR7l (ORCPT ); Tue, 31 Jan 2023 12:59:41 -0500 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EBB86234ED for ; Tue, 31 Jan 2023 09:59:25 -0800 (PST) Received: by mail-wm1-x331.google.com with SMTP id f47-20020a05600c492f00b003dc584a7b7eso5059443wmp.3 for ; Tue, 31 Jan 2023 09:59:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/szpvn7y9gec1tyWJQBadgKS8WeEN4pwAXM4ABHxKUU=; b=SsXUyMMSeCP/y7sVGkHIr+wpXtG+lNexPqRpKCZMGeB2LOgMxzjBwleq77KDiUrHwp SNs3p6Z2ZLyYZyDrWO99h05TxvEa3nX9dSE2k+4IWs1ABGkpDK0yH3ARbya2Y2DQLBLQ PvOrQ+aPNQM49D/a08vbA2DJI9XwdMVecs7CvJnVw6kN7/HNI1cny2fSHFE8B17TNitz Hrk8XloenIKFWf8a2/EWU+eLCsv9MyWD/I1S/EQ3F4d0Jk3E9cK1fhDH/4Ol0DOOkqwO MwVpmttmVDVLqScMFYgRYN0BrQ6Qgvr2Y2fyTQw/ths+an/9+uhimFl0fZk2bfFQXVLQ U9RA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/szpvn7y9gec1tyWJQBadgKS8WeEN4pwAXM4ABHxKUU=; b=JLJWAvZXsNVddjHgEZ6i6I+QTM40cMi3QC8Nl4Q5PGvXYdHJ7uKXNxcMN+lmhUvwZW mNgBhAXy7r/XBXBC9b0VMt4+ykgBe9rxr/JbQie5L5TUos5YVmBBUWoEmrt6/kyB7hj4 LQhyaoeahDgPKirV3f85ZeBsWF1JQWRjHAeplbm17OVWo/18Bcl6BHcP6G1BHXQatU4Q JDn/Y3TdIYtZQ/8Abhu2uODYs/3jHevqWVK6miWidZTsEsTG3PzssYGoezn5ahZt7vkm EyGuTgo4l4Bc+GmlW4hNdVXeN7B0jdvRJCqM98poMdW1CU3egSPQGRbZJ/I1N1HQyQAb MJRA== X-Gm-Message-State: AO0yUKUVElS9V9iGFMULf1sonBmhTbcEMTCQ7q/Ins7K18+iDp70MtMo 8EY2RP97VJ5l+I0vne+6Pc7Jqw== X-Google-Smtp-Source: AK7set/mH8G8arPE9aWgo+oZwj285W4mdjXlicy8LcplDLyXvEcpmpH/9UUR/d6w07g+gluxQr8aGQ== X-Received: by 2002:a7b:c853:0:b0:3dc:5342:4132 with SMTP id c19-20020a7bc853000000b003dc53424132mr10709426wml.4.1675187964539; Tue, 31 Jan 2023 09:59:24 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id p7-20020a1c5447000000b003dc433355aasm13191576wmi.18.2023.01.31.09.59.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Jan 2023 09:59:24 -0800 (PST) Message-ID: <5ecabe9e-84f2-cc3a-c213-3b623f90842e@linaro.org> Date: Tue, 31 Jan 2023 18:59:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v5] ASoC: dt-bindings: Add tas2781 amplifier. Content-Language: en-US To: Shenghao Ding <13916275206@139.com>, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, broonie@kernel.org, lgirdwood@gmail.com Cc: kevin-lu@ti.com, shenghao-ding@ti.com, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230131131735.7118-1-13916275206@139.com> From: Krzysztof Kozlowski In-Reply-To: <20230131131735.7118-1-13916275206@139.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 31/01/2023 14:17, Shenghao Ding wrote: > Create tas2781.yaml for tas2781 driver. You treat my feedback selectively... some things improved, but not everything. I am literally repeating the same and expect different results from you... isn't that the definition of insanity? Let me paste ignored parts: 1. Your patches are still not correctly threaded. There is no threading at all. I said it multiple times. What else should I say here? 2. Subject: ASoC: dt-bindings: Add tas2781 amplifier (drop the full stop - why did you add it there?) 3. Missing changelog under ---. I mentioned it already few times, didn't I? > > Signed-off-by: Shenghao Ding <13916275206@139.com> > > --- > Changes to be committed: > new file: Documentation/devicetree/bindings/sound/ti,tas2781.yaml > --- > .../devicetree/bindings/sound/ti,tas2781.yaml | 87 +++++++++++++++++++ > 1 file changed, 87 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/ti,tas2781.yaml > > diff --git a/Documentation/devicetree/bindings/sound/ti,tas2781.yaml b/Documentation/devicetree/bindings/sound/ti,tas2781.yaml > new file mode 100644 > index 000000000..9a440d29f > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/ti,tas2781.yaml > @@ -0,0 +1,87 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright (C) 2022 - 2023 Texas Instruments Incorporated > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/ti,tas2781.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Texas Instruments TAS2781 SmartAMP > + > +maintainers: > + - Shenghao Ding > + - Kevin Lu > + > +description: | > + The TAS2781 is a mono, digital input Class-D audio amplifier > + optimized for efficiently driving high peak power into small > + loudspeakers. Integrated an on-chip DSP supports Texas Instruments > + Smart Amp speaker protection algorithm. The integrated speaker > + voltage and current sense provides for real time > + monitoring of loudspeaker behavior. > + > +properties: > + compatible: > + enum: > + - ti,tas2781 > + > + reg: > + maxItems: 1 > + description: | > + I2C address of the device can be in range from 0x38 to 0x40. > + > + reset-gpios: > + maxItems: 1 > + description: | > + A GPIO line handling reset of the chip. As the line is active high, > + it should be marked GPIO_ACTIVE_HIGH (see ../gpio/gpio.txt) Drop the reference to gpio.txt. I give up. I spent too much time on it while being also ignored a bit too much. Best regards, Krzysztof