From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0607C4167B for ; Tue, 20 Dec 2022 10:32:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231648AbiLTKc2 (ORCPT ); Tue, 20 Dec 2022 05:32:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49090 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231752AbiLTKcZ (ORCPT ); Tue, 20 Dec 2022 05:32:25 -0500 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7779E17053 for ; Tue, 20 Dec 2022 02:32:23 -0800 (PST) Received: by mail-lf1-x132.google.com with SMTP id cf42so17957038lfb.1 for ; Tue, 20 Dec 2022 02:32:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=1t/IWVw7r10QCWW4I+HlY30TmCiUf2ypn13OY8W7dy8=; b=jAjWA4xT7kPjRYfD4kJQbAgN02+MOjaWyb39y8dip8mOoziJIeoCslS44Q2pN3sCxB UiDoLfm3/f2cpZZseNmB07FF1sFgqqPeP9HHSBnnehypsu6sgsvxXGd1xNiudOe3m6i2 5cpMaintn5pAW8yAWO1vM+g7LOHDxE0PXvMvmD3zfgzYZL5tQSpH4xsDwICDr9qfAFPi JKLLHYtwxDS+uEtfGN9JCVgg0AcG0H8ideq0FDBHD+kUXgfhgVbeJbv3+7NcKbWCIR7i gP1RghIwQ9zc5yBtly1mfahaYvEj9EW6uqNRrrBX2v/92upl6/MU3v9XdkuaNgbBAoh7 ekwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1t/IWVw7r10QCWW4I+HlY30TmCiUf2ypn13OY8W7dy8=; b=ISP7L8Vktir+Ml/mIcRwWhrtWn/XV1hlhW9f+XuyyM4x2QZcaxvZBtCOs+3O9ZO6yh zAqF7eToVezUaH3Va3Nlc9M92zz7nk6UDWR/ek8vemB/4/jZIIUeCQUetKws/MCV/B/4 O+FmNuH1gvh8t/4SXGAZfC1d/TFNy0scCzY+T8k9KwDJO5Nmv4w95a+tpd683fvTorRn lMBJ7fACqqq9TLhGTlKl1IHPLHIS8r/9THyg39+Yn2nLhDR9qFBx+V2+yhHV8McukMVi xAnFMmqfgfTurSxPIdhNKPjz5Su35er8EQuZC8o3piFTjTzzDgG4lVzEyNdjN2Sam7Do KXsg== X-Gm-Message-State: ANoB5pk+n6VBOeg0iEdJNzggULra0ugN/my/lwceS++L08O44pzUIEqd jNxlgwb+wKy+Qy2Iq4PUBwN6Nw== X-Google-Smtp-Source: AA0mqf4b3ocOYQJkS+PY99VtTIfthteZE0+FPQAbNjx0pVkZzgXiew6heHs9apE47RtuS9zoiFdylA== X-Received: by 2002:a05:6512:3ba7:b0:4b5:7c02:39 with SMTP id g39-20020a0565123ba700b004b57c020039mr18547421lfv.47.1671532341836; Tue, 20 Dec 2022 02:32:21 -0800 (PST) Received: from [192.168.1.101] (abxh212.neoplus.adsl.tpnet.pl. [83.9.1.212]) by smtp.gmail.com with ESMTPSA id 14-20020ac25f4e000000b004b591c33b99sm1413157lfz.13.2022.12.20.02.32.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Dec 2022 02:32:21 -0800 (PST) Message-ID: <5f4046df-906b-5673-81b9-ab37294ba443@linaro.org> Date: Tue, 20 Dec 2022 11:32:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v3 08/15] thermal/drivers/tsens: Drop single-cell code for msm8939 Content-Language: en-US To: Bryan O'Donoghue , Bryan O'Donoghue , Dmitry Baryshkov , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Amit Kucheria , Thara Gopinath , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui Cc: linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, Shawn Guo References: <20221220024721.947147-1-dmitry.baryshkov@linaro.org> <20221220024721.947147-9-dmitry.baryshkov@linaro.org> <78fd7174-9aa4-f067-72ca-514c8fb09ee5@linaro.org> <5bd2c0cd-741c-8865-5f35-25baf6787480@nexus-software.ie> From: Konrad Dybcio In-Reply-To: <5bd2c0cd-741c-8865-5f35-25baf6787480@nexus-software.ie> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 20.12.2022 11:26, Bryan O'Donoghue wrote: > On 20/12/2022 10:21, Konrad Dybcio wrote: >> The point of this patchset is to remove logic like this, as it's >> very repetetive and all it does is read fuses with a ton of magic >> offsets. Dmitry pushes that to DT with the generic nvmem API, so >> that instead of these magic &s and <> define QFPROM fuses at the correct offset and with a matching bits=<> >> property. This does not remove any functionality, it just changes >> how the fuses are accessed and makes the code more generic. >> >> Konrad > > Hmm but then there's extra work to get this working again on 8939 right? > > Seems very dogmatic to drop working code for want of sending a dtsi out. > > Certainly my preference is to keep exiting working code and just complete landing the relevant dtsi, rather than eject working code and have to do the same work all over again. Well, I don't really know how to say it in a way that wouldn't make it sound mean, but trust me I don't want it to be mean.. Mainline does not and will not (for the most part) care about out of tree code, so cleanups of parts like this with no users are wholly expected if your DT hasn't landed upstream (or has been stuck in review for a long long time like it is the case with various parts of 8939).. Keeping this old iteration is blocking progress, as the other similar ones (that *do* have mainline users) are left in place just to be backwards compatible with old DTs that may have been pulled from torvalds/linux by third party projects, like U-Boot, *BSDs or something. Trimming away this now-duplicated code will shrink the driver, reducing bloat for everyone that compiles it in and doesn't use the 8939-specific path. Konrad > > --- > bod