From: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
To: Prasad Kumpatla <prasad.kumpatla@oss.qualcomm.com>,
Srinivas Kandagatla <srini@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Cc: linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 4/7] ASoC: qcom: qdsp6: q6prm: add Audio IF clock IDs
Date: Tue, 14 Jul 2026 09:36:44 +0100 [thread overview]
Message-ID: <5f5287d9-1991-407f-a3d8-7649f41a99bc@oss.qualcomm.com> (raw)
In-Reply-To: <20260712134110.3306763-5-prasad.kumpatla@oss.qualcomm.com>
On 7/12/26 2:41 PM, Prasad Kumpatla wrote:
> Add the q6prm clock table entries and internal DSP clock IDs for LPASS
> Audio IF backend clocks.
>
> The public binding IDs map to q6prm DSP clock IDs starting at 0x500 for
> Audio IF0 IBIT/EBIT. Add the internal definitions and register all Audio
> IF IBIT and EBIT clocks so machine drivers can request them through the
> APM clock controller.
>
> Signed-off-by: Prasad Kumpatla <prasad.kumpatla@oss.qualcomm.com>
lgtm,
Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
--srini
> ---
> sound/soc/qcom/qdsp6/q6prm-clocks.c | 28 ++++++++++++++++++++++++++++
> sound/soc/qcom/qdsp6/q6prm.h | 29 +++++++++++++++++++++++++++++
> 2 files changed, 57 insertions(+)
>
> diff --git a/sound/soc/qcom/qdsp6/q6prm-clocks.c b/sound/soc/qcom/qdsp6/q6prm-clocks.c
> index 4c574b48a..38354ca8b 100644
> --- a/sound/soc/qcom/qdsp6/q6prm-clocks.c
> +++ b/sound/soc/qcom/qdsp6/q6prm-clocks.c
> @@ -59,6 +59,34 @@ static const struct q6dsp_clk_init q6prm_clks[] = {
> Q6PRM_CLK(LPASS_CLK_ID_WSA2_CORE_TX_MCLK),
> Q6PRM_CLK(LPASS_CLK_ID_WSA2_CORE_TX_2X_MCLK),
> Q6PRM_CLK(LPASS_CLK_ID_RX_CORE_MCLK2_2X_MCLK),
> + Q6PRM_CLK(LPASS_CLK_ID_INTF0_IBIT),
> + Q6PRM_CLK(LPASS_CLK_ID_INTF0_EBIT),
> + Q6PRM_CLK(LPASS_CLK_ID_INTF1_IBIT),
> + Q6PRM_CLK(LPASS_CLK_ID_INTF1_EBIT),
> + Q6PRM_CLK(LPASS_CLK_ID_INTF2_IBIT),
> + Q6PRM_CLK(LPASS_CLK_ID_INTF2_EBIT),
> + Q6PRM_CLK(LPASS_CLK_ID_INTF3_IBIT),
> + Q6PRM_CLK(LPASS_CLK_ID_INTF3_EBIT),
> + Q6PRM_CLK(LPASS_CLK_ID_INTF4_IBIT),
> + Q6PRM_CLK(LPASS_CLK_ID_INTF4_EBIT),
> + Q6PRM_CLK(LPASS_CLK_ID_INTF5_IBIT),
> + Q6PRM_CLK(LPASS_CLK_ID_INTF5_EBIT),
> + Q6PRM_CLK(LPASS_CLK_ID_INTF6_IBIT),
> + Q6PRM_CLK(LPASS_CLK_ID_INTF6_EBIT),
> + Q6PRM_CLK(LPASS_CLK_ID_INTF7_IBIT),
> + Q6PRM_CLK(LPASS_CLK_ID_INTF7_EBIT),
> + Q6PRM_CLK(LPASS_CLK_ID_INTF8_IBIT),
> + Q6PRM_CLK(LPASS_CLK_ID_INTF8_EBIT),
> + Q6PRM_CLK(LPASS_CLK_ID_INTF9_IBIT),
> + Q6PRM_CLK(LPASS_CLK_ID_INTF9_EBIT),
> + Q6PRM_CLK(LPASS_CLK_ID_INTF10_IBIT),
> + Q6PRM_CLK(LPASS_CLK_ID_INTF10_EBIT),
> + Q6PRM_CLK(LPASS_CLK_ID_INTF11_IBIT),
> + Q6PRM_CLK(LPASS_CLK_ID_INTF11_EBIT),
> + Q6PRM_CLK(LPASS_CLK_ID_INTF12_IBIT),
> + Q6PRM_CLK(LPASS_CLK_ID_INTF12_EBIT),
> + Q6PRM_CLK(LPASS_CLK_ID_VA_INTF0_IBIT),
> + Q6PRM_CLK(LPASS_CLK_ID_VA_INTF0_EBIT),
> Q6DSP_VOTE_CLK(LPASS_HW_MACRO_VOTE, Q6PRM_HW_CORE_ID_LPASS,
> "LPASS_HW_MACRO"),
> Q6DSP_VOTE_CLK(LPASS_HW_DCODEC_VOTE, Q6PRM_HW_CORE_ID_DCODEC,
> diff --git a/sound/soc/qcom/qdsp6/q6prm.h b/sound/soc/qcom/qdsp6/q6prm.h
> index bbbe6d368..1593f6bd4 100644
> --- a/sound/soc/qcom/qdsp6/q6prm.h
> +++ b/sound/soc/qcom/qdsp6/q6prm.h
> @@ -87,6 +87,35 @@
> /* Clock ID for RX CORE MCLK2 2X MCLK */
> #define Q6PRM_LPASS_CLK_ID_RX_CORE_MCLK2_2X_MCLK 0x318
>
> +#define Q6PRM_LPASS_CLK_ID_INTF0_IBIT 0x500
> +#define Q6PRM_LPASS_CLK_ID_INTF0_EBIT 0x501
> +#define Q6PRM_LPASS_CLK_ID_INTF1_IBIT 0x502
> +#define Q6PRM_LPASS_CLK_ID_INTF1_EBIT 0x503
> +#define Q6PRM_LPASS_CLK_ID_INTF2_IBIT 0x504
> +#define Q6PRM_LPASS_CLK_ID_INTF2_EBIT 0x505
> +#define Q6PRM_LPASS_CLK_ID_INTF3_IBIT 0x506
> +#define Q6PRM_LPASS_CLK_ID_INTF3_EBIT 0x507
> +#define Q6PRM_LPASS_CLK_ID_INTF4_IBIT 0x508
> +#define Q6PRM_LPASS_CLK_ID_INTF4_EBIT 0x509
> +#define Q6PRM_LPASS_CLK_ID_INTF5_IBIT 0x50A
> +#define Q6PRM_LPASS_CLK_ID_INTF5_EBIT 0x50B
> +#define Q6PRM_LPASS_CLK_ID_INTF6_IBIT 0x50C
> +#define Q6PRM_LPASS_CLK_ID_INTF6_EBIT 0x50D
> +#define Q6PRM_LPASS_CLK_ID_INTF7_IBIT 0x50E
> +#define Q6PRM_LPASS_CLK_ID_INTF7_EBIT 0x50F
> +#define Q6PRM_LPASS_CLK_ID_INTF8_IBIT 0x510
> +#define Q6PRM_LPASS_CLK_ID_INTF8_EBIT 0x511
> +#define Q6PRM_LPASS_CLK_ID_INTF9_IBIT 0x512
> +#define Q6PRM_LPASS_CLK_ID_INTF9_EBIT 0x513
> +#define Q6PRM_LPASS_CLK_ID_INTF10_IBIT 0x514
> +#define Q6PRM_LPASS_CLK_ID_INTF10_EBIT 0x515
> +#define Q6PRM_LPASS_CLK_ID_INTF11_IBIT 0x516
> +#define Q6PRM_LPASS_CLK_ID_INTF11_EBIT 0x517
> +#define Q6PRM_LPASS_CLK_ID_INTF12_IBIT 0x518
> +#define Q6PRM_LPASS_CLK_ID_INTF12_EBIT 0x519
> +#define Q6PRM_LPASS_CLK_ID_VA_INTF0_IBIT 0x550
> +#define Q6PRM_LPASS_CLK_ID_VA_INTF0_EBIT 0x551
> +
> #define Q6PRM_LPASS_CLK_SRC_INTERNAL 1
> #define Q6PRM_LPASS_CLK_ROOT_DEFAULT 0
> #define Q6PRM_HW_CORE_ID_LPASS 1
next prev parent reply other threads:[~2026-07-14 8:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-12 13:41 [PATCH v4 0/7] ASoC: qcom: add AudioReach TDM backend support Prasad Kumpatla
2026-07-12 13:41 ` [PATCH v4 1/7] ASoC: qcom: qdsp6: add topology-driven Audio IF support Prasad Kumpatla
2026-07-14 8:24 ` Srinivas Kandagatla
2026-07-15 9:36 ` Prasad Kumpatla
2026-07-12 13:41 ` [PATCH v4 2/7] ASoC: qcom: q6apm-lpass-dais: add TDM DAI operations Prasad Kumpatla
2026-07-14 8:32 ` Srinivas Kandagatla
2026-07-15 9:46 ` Prasad Kumpatla
2026-07-12 13:41 ` [PATCH v4 3/7] ASoC: dt-bindings: qcom,q6dsp-lpass-ports: add Audio IF clocks Prasad Kumpatla
2026-07-14 8:33 ` Srinivas Kandagatla
2026-07-12 13:41 ` [PATCH v4 4/7] ASoC: qcom: qdsp6: q6prm: add Audio IF clock IDs Prasad Kumpatla
2026-07-14 8:36 ` Srinivas Kandagatla [this message]
2026-07-12 13:41 ` [PATCH v4 5/7] Asoc: dt-bindings: qcom,sm8250: Add TDM slot properties Prasad Kumpatla
2026-07-13 6:50 ` Krzysztof Kozlowski
2026-07-12 13:41 ` [PATCH v4 6/7] ASoC: qcom: common: add DAI-node TDM slot helpers Prasad Kumpatla
2026-07-12 13:41 ` [PATCH v4 7/7] ASoC: qcom: sc8280xp: add TDM hw_params support Prasad Kumpatla
2026-08-01 0:05 ` [PATCH v4 0/7] ASoC: qcom: add AudioReach TDM backend support Mark Brown
2026-08-03 9:39 ` Prasad Kumpatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f5287d9-1991-407f-a3d8-7649f41a99bc@oss.qualcomm.com \
--to=srinivas.kandagatla@oss.qualcomm.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=prasad.kumpatla@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=srini@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox