Re: [PATCH v4 1/6] dt-bindings: mfd: add pf1550

[Krzysztof Kozlowski <krzk@kernel.org>]

On 03/06/2025 20:27, Samuel Kayode via B4 Relay wrote:
> From: Samuel Kayode <samuel.kayode@savoirfairelinux.com>
> 
> Add a DT binding document for pf1550 PMIC. This describes the core mfd
> device along with its children: regulators, charger and onkey.
> 
> Signed-off-by: Samuel Kayode <samuel.kayode@savoirfairelinux.com>
> ---
> v4:
>  - Address Krzystof's feedback:
>    - Filename changed to nxp,pf1550.yaml
>    - Replace Freescale with NXP
>    - Define include before battery-cell
>    - Drop operating-range-celsius in example since
>      nxp,thermal-regulation-celsisus already exists
>  - Not sure if there is similar binding to thermal-regulation...
>    for regulating temperature on thermal-zones? @Sebastian and @Krzysztof
> v3:
>  - Address Krzysztof's feedback:
>    - Fold charger and onkey objects
>    - Drop compatible for sub-devices: onkey, charger and regulator.
>    - Drop constant voltage property already included in
>      monitored-battery
>    - Fix whitespace warnings
>    - Fix license
> v2:
>  - Add yamls for the PMIC and the sub-devices
> ---
>  .../devicetree/bindings/mfd/nxp,pf1550.yaml        | 139 +++++++++++++++++++++
>  1 file changed, 139 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/nxp,pf1550.yaml b/Documentation/devicetree/bindings/mfd/nxp,pf1550.yaml
> new file mode 100644
> index 0000000000000000000000000000000000000000..add895311b892a6731f54e47fcaaba8dfdac14b3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/nxp,pf1550.yaml
> @@ -0,0 +1,139 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mfd/nxp,pf1550.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NXP PF1550 Power Management IC
> +
> +maintainers:
> +  - Samuel Kayode <samuel.kayode@savoirfairelinux.com>
> +
> +description: |

Drop |, Do not need '|' unless you need to preserve formatting.

> +  PF1550 PMIC provides battery charging and power supply for low power IoT and
> +  wearable applications. This device consists of an i2c controlled MFD that
> +  includes regulators, battery charging and an onkey/power button.
> +
> +$ref: /schemas/power/supply/power-supply.yaml
> +
> +properties:
> +  compatible:
> +    const: nxp,pf1550
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  wakeup-source: true
> +
> +  regulators:
> +    type: object
> +
> +    patternProperties:
> +      "^(ldo[1-3]|sw[1-3]|vrefddr)$":
> +        type: object
> +        $ref: /schemas/regulator/regulator.yaml
> +        description:
> +          regulator configuration for ldo1-3, buck converters(sw1-3)
> +          and DDR termination reference voltage (vrefddr)
> +        unevaluatedProperties: false
> +
> +    additionalProperties: false

Please put it after type:object

> +
> +  monitored-battery:
> +    $ref: /schemas/types.yaml#/definitions/phandle

Drop, comes from power supply schema

> +    description: |
> +      A phandle to a monitored battery node that contains a valid value
> +      for:
> +      constant-charge-voltage-max-microvolt.
> +
> +  nxp,thermal-regulation-celsius:
> +    description:
> +      Temperature threshold for thermal regulation of charger in celsius.
> +    enum: [ 60, 75, 90, 105 ]
> +
> +  nxp,min-system-microvolt:
> +    description:
> +      System specific lower limit voltage.
> +    enum: [ 3500000, 3700000, 4300000 ]
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +
> +additionalProperties: false

And this becomes unevaluatedProperties: false.

With these changes (and after testing with dt_bindings_check):


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


Best regards,
Krzysztof