From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB966EADA; Fri, 9 Aug 2024 10:05:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723197945; cv=none; b=BtE6MQrIp+akGq+99wCN6GcWt7r8Rqdg1BEJutFiGcbgBu357LQm1Gv+iJIaZ3cAjuAraq8V6sTykephnO84q7g58FSYPfviEk7Pw3RmbWp1IlbRhuCDpcfBgN021ky2hkQdyoVsAAJtrRogAIyH7V/vnfEJjm6hLndF4eVZSpg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723197945; c=relaxed/simple; bh=BF/gLX+YLdTrLNBjsmlMUFG4iTz6zad/entPbCJIMRk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lWR2YXESf5Zoa7Mzp+OJQtcR4vhw4yPvkBMHahGIA0aQ7kUB+25Wy3QOMfgK1YfcG1rj3/WMlNTAD7HZbH0vAJRE7KrqNlkEe/S6MKLgC3Jvhz/VbYY6GiyG/7qShnH+pkx0q1S674tu0ByEJ422N5F1F2pFNAFELZHWC7Dm0UU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ISe1vpCy; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ISe1vpCy" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0F6D9C32782; Fri, 9 Aug 2024 10:05:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1723197945; bh=BF/gLX+YLdTrLNBjsmlMUFG4iTz6zad/entPbCJIMRk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ISe1vpCykFza8Pjtj5r7w7Sce1y5HSKziXewGmiB948PGBWfp+w/18aix0qz+uOqS AyWgysBw41Q4IxCgaR9a28eofWNK0nH4skJIolqGmv644PLvh9DNecxwfu/snK4E66 wOmYTAhvsv1EFmnNaqA9sDW5feC3ucuiRFlhM7FEb8ylnF3ZNO1nQkLOAilEB6YdjE AsYQjEY67sdFpC8oaieFEiDEXgXcOVQvh8BhRk5C5FIHidkdJQfXefnQOzNnzlOZ/g 4EX5CW812bm0BzE76RWCtopL1a7ED0tZHKDFia/XUlVG+O71NYy007zvIJKNkaU9df CU+uFpf3ZS2Kg== Message-ID: <5fdf6810-f729-42bf-a5fd-a2de02d0a894@kernel.org> Date: Fri, 9 Aug 2024 12:05:38 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] dt-bindings: serial: Add Loongson UART controller To: =?UTF-8?B?6YOR6LGq5aiB?= , gregkh@linuxfoundation.org, jirislaby@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, chenhuacai@kernel.org, kernel@xen0n.name, p.zabel@pengutronix.de Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, loongarch@lists.linux.dev References: <20240804063834.70022-1-zhenghaowei@loongson.cn> <4d1f2426-b43c-4727-8387-f18edf937163@kernel.org> <601adbfd-fbb6-48c6-b755-da1b5d321d6b@kernel.org> <89e71573-9365-2e61-bb38-759363df1b8b@loongson.cn> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <89e71573-9365-2e61-bb38-759363df1b8b@loongson.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 09/08/2024 11:55, 郑豪威 wrote: >> >>>>> + description: Enables fractional-N division. Currently, >>>>> + only LS2K1500 and LS2K2000 support this feature. >>>>> + >>>>> + rts-invert: >>>>> + description: Inverts the RTS value in the MCR register. >>>>> + This should be used on Loongson-3 series CPUs, Loongson-2K >>>>> + series CPUs, and Loongson LS7A bridge chips. >>>>> + >>>>> + dtr-invert: >>>>> + description: Inverts the DTR value in the MCR register. >>>>> + This should be used on Loongson-3 series CPUs, Loongson-2K >>>>> + series CPUs, and Loongson LS7A bridge chips. >>>>> + >>>>> + cts-invert: >>>>> + description: Inverts the CTS value in the MSR register. >>>>> + This should be used on Loongson-2K0500, Loongson-2K1000, >>>>> + and Loongson LS7A bridge chips. >>>>> + >>>>> + dsr-invert: >>>>> + description: Inverts the DSR value in the MSR register. >>>>> + This should be used on Loongson-2K0500, Loongson-2K1000, >>>>> + and Loongson LS7A bridge chips. >> Same questions for all these. Why choosing invert is a board level >> decision? If it "should be used" then why it is not used always? >> > Because these features are not applicable to all chips, such as > 'fractional-division', Hm? > > which is currently supported only by 2K1500 and 2K2000, and for > Loongson-3 series These are SoCs. Compatible defines that. Please align with your colleagues, because *we talked about this* already. Best regards, Krzysztof