* [PATCH v2 2/2] drm/panel: simple: Add AUO G156HAN04.0 LVDS display support
2023-12-09 6:36 [PATCH v2 1/2] dt-bindings: display: simple: Add AUO G156HAN04.0 LVDS display Marek Vasut
@ 2023-12-09 6:37 ` Marek Vasut
2023-12-11 9:01 ` Maxime Ripard
2023-12-11 9:02 ` [PATCH v2 1/2] dt-bindings: display: simple: Add AUO G156HAN04.0 LVDS display Maxime Ripard
2023-12-11 9:16 ` Neil Armstrong
2 siblings, 1 reply; 5+ messages in thread
From: Marek Vasut @ 2023-12-09 6:37 UTC (permalink / raw)
To: dri-devel
Cc: Elmar Albert, Marek Vasut, Conor Dooley, Daniel Vetter,
David Airlie, Jessica Zhang, Krzysztof Kozlowski, Liu Ying,
Maarten Lankhorst, Maxime Ripard, Neil Armstrong, Rob Herring,
Sam Ravnborg, Thierry Reding, Thomas Zimmermann, devicetree
From: Elmar Albert <ealbert@data-modul.com>
G156HAN04.0 is a Color Active Matrix Liquid Crystal Display composed of
a TFT LCD panel, a driver circuit, and LED backlight system. The screen
format is intended to support the 16:9 FHD, 1920(H) x 1080(V) screen
and 16.7M colors (RGB 8-bits) with LED backlight driving circuit.
All input signals are LVDS interface compatible.
G156HAN04.0 is designed for a display unit of notebook style
personal computer and industrial machine.
Signed-off-by: Elmar Albert <ealbert@data-modul.com>
Signed-off-by: Marek Vasut <marex@denx.de>
---
Cc: Conor Dooley <conor+dt@kernel.org>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: David Airlie <airlied@gmail.com>
Cc: Jessica Zhang <quic_jesszhan@quicinc.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Liu Ying <victor.liu@nxp.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Neil Armstrong <neil.armstrong@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: devicetree@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
---
V2: - Rebase the patch
- Fix up commit message
- Tx parameter comments are retained, they refer to datasheet
timings and are generally useful when checking if the timing
requirements are properly fulfilled
---
drivers/gpu/drm/panel/panel-simple.c | 34 ++++++++++++++++++++++++++++
1 file changed, 34 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 6bdd97ee71fec..83039c6b50e05 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -1135,6 +1135,37 @@ static const struct panel_desc auo_g133han01 = {
.connector_type = DRM_MODE_CONNECTOR_LVDS,
};
+static const struct display_timing auo_g156han04_timings = {
+ .pixelclock = { 137000000, 141000000, 146000000 },
+ .hactive = { 1920, 1920, 1920 },
+ .hfront_porch = { 60, 60, 60 },
+ .hback_porch = { 90, 92, 111 },
+ .hsync_len = { 32, 32, 32 },
+ .vactive = { 1080, 1080, 1080 },
+ .vfront_porch = { 12, 12, 12 },
+ .vback_porch = { 24, 36, 56 },
+ .vsync_len = { 8, 8, 8 },
+};
+
+static const struct panel_desc auo_g156han04 = {
+ .timings = &auo_g156han04_timings,
+ .num_timings = 1,
+ .bpc = 8,
+ .size = {
+ .width = 344,
+ .height = 194,
+ },
+ .delay = {
+ .prepare = 50, /* T2 */
+ .enable = 200, /* T3 */
+ .disable = 110, /* T10 */
+ .unprepare = 1000, /* T13 */
+ },
+ .bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
+ .bus_flags = DRM_BUS_FLAG_DE_HIGH,
+ .connector_type = DRM_MODE_CONNECTOR_LVDS,
+};
+
static const struct drm_display_mode auo_g156xtn01_mode = {
.clock = 76000,
.hdisplay = 1366,
@@ -4289,6 +4320,9 @@ static const struct of_device_id platform_of_match[] = {
}, {
.compatible = "auo,g133han01",
.data = &auo_g133han01,
+ }, {
+ .compatible = "auo,g156han04",
+ .data = &auo_g156han04,
}, {
.compatible = "auo,g156xtn01",
.data = &auo_g156xtn01,
--
2.42.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v2 1/2] dt-bindings: display: simple: Add AUO G156HAN04.0 LVDS display
2023-12-09 6:36 [PATCH v2 1/2] dt-bindings: display: simple: Add AUO G156HAN04.0 LVDS display Marek Vasut
2023-12-09 6:37 ` [PATCH v2 2/2] drm/panel: simple: Add AUO G156HAN04.0 LVDS display support Marek Vasut
@ 2023-12-11 9:02 ` Maxime Ripard
2023-12-11 9:16 ` Neil Armstrong
2 siblings, 0 replies; 5+ messages in thread
From: Maxime Ripard @ 2023-12-11 9:02 UTC (permalink / raw)
To: Marek Vasut
Cc: devicetree, dri-devel, Conor Dooley, Daniel Vetter, David Airlie,
Elmar Albert, Jessica Zhang, Krzysztof Kozlowski,
Krzysztof Kozlowski, Liu Ying, Maarten Lankhorst, Maxime Ripard,
Neil Armstrong, Rob Herring, Sam Ravnborg, Thierry Reding,
Thomas Zimmermann
On Sat, 9 Dec 2023 07:36:59 +0100, Marek Vasut wrote:
> From: Elmar Albert <ealbert@data-modul.com>
>
> Document support for the AUO G156HAN04.0 LVDS display.
>
> G156HAN04.0 is a Color Active Matrix Liquid Crystal Display composed of
>
> [ ... ]
Acked-by: Maxime Ripard <mripard@kernel.org>
Thanks!
Maxime
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: display: simple: Add AUO G156HAN04.0 LVDS display
2023-12-09 6:36 [PATCH v2 1/2] dt-bindings: display: simple: Add AUO G156HAN04.0 LVDS display Marek Vasut
2023-12-09 6:37 ` [PATCH v2 2/2] drm/panel: simple: Add AUO G156HAN04.0 LVDS display support Marek Vasut
2023-12-11 9:02 ` [PATCH v2 1/2] dt-bindings: display: simple: Add AUO G156HAN04.0 LVDS display Maxime Ripard
@ 2023-12-11 9:16 ` Neil Armstrong
2 siblings, 0 replies; 5+ messages in thread
From: Neil Armstrong @ 2023-12-11 9:16 UTC (permalink / raw)
To: dri-devel, Marek Vasut
Cc: Elmar Albert, Krzysztof Kozlowski, Conor Dooley, Daniel Vetter,
David Airlie, Jessica Zhang, Krzysztof Kozlowski, Liu Ying,
Maarten Lankhorst, Maxime Ripard, Rob Herring, Sam Ravnborg,
Thierry Reding, Thomas Zimmermann, devicetree
Hi,
On Sat, 09 Dec 2023 07:36:59 +0100, Marek Vasut wrote:
> Document support for the AUO G156HAN04.0 LVDS display.
>
> G156HAN04.0 is a Color Active Matrix Liquid Crystal Display composed of
> a TFT LCD panel, a driver circuit, and LED backlight system. The screen
> format is intended to support the 16:9 FHD, 1920(H) x 1080(V) screen
> and 16.7M colors (RGB 8-bits) with LED backlight driving circuit.
> All input signals are LVDS interface compatible.
>
> [...]
Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next)
[1/2] dt-bindings: display: simple: Add AUO G156HAN04.0 LVDS display
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=bf7f730dea3125b2272ad7268f59e8992c5b7822
[2/2] drm/panel: simple: Add AUO G156HAN04.0 LVDS display support
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=9e52d5c808215b0033cdbeca72700b1e401ea987
--
Neil
^ permalink raw reply [flat|nested] 5+ messages in thread