From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFAD4C4332F for ; Fri, 2 Dec 2022 08:59:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232313AbiLBI7w (ORCPT ); Fri, 2 Dec 2022 03:59:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231386AbiLBI7c (ORCPT ); Fri, 2 Dec 2022 03:59:32 -0500 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A66431345 for ; Fri, 2 Dec 2022 00:57:56 -0800 (PST) Received: by mail-wm1-x32e.google.com with SMTP id 125-20020a1c0283000000b003d076ee89d6so3314106wmc.0 for ; Fri, 02 Dec 2022 00:57:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=hrXh1n7+q7fL8fZ+N+AYxQ6Gttv4U1Iv+7uPHyHolo8=; b=U3zLU6MZH0G4eEg0jylYeVarVdA0Vp1QAGYYAUzAbngRNP9p9NEf0CJ6ph59Z5vpek coZOw6/yF0T05gempG5PoG1gQTl3iISvll/LJ3Ff1ERdgJquIMMlV3txt3CBzVls2vkf LvEQapbfpfLWydAb4VuFINZ/Whn/5gCtfiyVuI8jbNzqNLSVUqcU+k4e2ELeYKhj0yrd kuBFNzqnLqueFlzR19IK9bwGjAbbq7nI3eSZ7WQt4y+5QQA3mizcjYE8P/xsPzIfJII1 j+bZlPv0LpmdRjM29qA6oOJEhiNKQ1Bw321ykzly8Lb+wdaqxsFKbeApYdgz8WYC1LqC iT9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hrXh1n7+q7fL8fZ+N+AYxQ6Gttv4U1Iv+7uPHyHolo8=; b=nfh1400DOH/QEZYZqyajOp3SlyPtw2qNerl+6F/4Q4VWTIRoVbPTub/3h971h0KJBH YjP7RTI7hWQbv0kMUn0H99nuKDKBTes7mXZc2IPRSbuMSlMoqHE/+CI/Ij4vaH+g3yBt Gh9ZqgyIVgs3OC5A7eWU63zRn2JID2M6YI0ps/Ar1ygoDz4i67w3FSsYT5mt8H3YFDfn 42VAB6tmIOaAGtbUuCDRQ7lMxZusCS+CwmThRVrJjWeJ/lyoWkN9AyKd5/pmpv/vR8Vw dNFfFNHyFvtUEHn3vVI749ZhX9ISopSO6zji+34ce/2PvzODwBLqgsJ1N5l5pVpa+52W 8TGw== X-Gm-Message-State: ANoB5pn25fTaRcoyRaVxJDYkWnH45kcS5bdWodMhACKr61V/rgZU5s1D qKkcH3xYio5Hnjgc7d+TmDqmXg== X-Google-Smtp-Source: AA0mqf67e2AGKPOEYoS8HO7Jo5+4Ow9tYZY+3J1lJSldilOVMktuVrZk3AiNzzSwU9R64H0rupfNLw== X-Received: by 2002:a7b:cb91:0:b0:3c6:cb54:ef66 with SMTP id m17-20020a7bcb91000000b003c6cb54ef66mr41088554wmi.90.1669971474508; Fri, 02 Dec 2022 00:57:54 -0800 (PST) Received: from ?IPV6:2a01:e0a:982:cbb0:c6e:eb0:b551:55ee? ([2a01:e0a:982:cbb0:c6e:eb0:b551:55ee]) by smtp.gmail.com with ESMTPSA id o37-20020a05600c512500b003cf5ec79bf9sm9035533wms.40.2022.12.02.00.57.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Dec 2022 00:57:54 -0800 (PST) Message-ID: <600437c7-3ccd-dfce-8fb8-826a608cc06e@linaro.org> Date: Fri, 2 Dec 2022 09:57:53 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH v5 4/7] arm64: dts: Add DT node for the VIPNano-QI on the A311D Content-Language: en-US To: Martin Blumenstingl , Tomeu Vizoso Cc: italonicola@collabora.com, Rob Herring , Krzysztof Kozlowski , Kevin Hilman , Jerome Brunet , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/Amlogic Meson SoC support" , "open list:ARM/Amlogic Meson SoC support" , open list References: <20221201103026.53234-1-tomeu.vizoso@collabora.com> <20221201103026.53234-5-tomeu.vizoso@collabora.com> Organization: Linaro Developer Services In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 01/12/2022 23:33, Martin Blumenstingl wrote: > On Thu, Dec 1, 2022 at 11:31 AM Tomeu Vizoso wrote: > [...] >> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi >> index 45947c1031c4..61c8461df614 100644 >> --- a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi >> +++ b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi >> @@ -11,6 +11,7 @@ >> #include >> #include >> #include >> +#include > We could now remove the meson-g12a-power include from > arch/arm64/boot/dts/amlogic/meson-g12.dtsi > I'm not sure if we have any "rule" about this though, so I'm curious > to hear what others think. Actually you're right, Tomeu please remove this include and remove the: power-domains = <&pwrc PWRC_G12A_NNA_ID>; and move it as: &npu { power-domains = <&pwrc PWRC_G12A_NNA_ID>; }; into arch/arm64/boot/dts/amlogic/meson-g12b.dtsi and while you're at it, please add: &npu { power-domains = <&pwrc PWRC_SM1_NNA_ID>; }; into arch/arm64/boot/dts/amlogic/meson-sm1.dtsi It's ok to do all this in a single patch. > > > Best regards, > Martin (PS: Don't forget Philipp's Acked-by on patch 1 for next version) Thanks, Neil