From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B60DA21773F for ; Mon, 9 Dec 2024 09:55:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733738121; cv=none; b=iI35JnD4wxyX0NUY1bSUx2leBaZEJTiJuv6/0mLO3I7ybMe8JK+EaEenyVE0TB8n557+cLzzztcznhCyXU8I22LOv2s2DCrX0NllCj+J6gjHOWeXocldPK6nfS7oSVQccCeZY2c7DyqV8G8g0iStwDbaeNJD7EenGw8AeOAl/5Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733738121; c=relaxed/simple; bh=OF8IHFpfgACEKTILhJU5a7s5El9km9y4LUVYegXHvF8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=owyaMie+4z9zowtkOmaL2K4kKDo7Ve8YwRzaLmsuJtWJVHJW4BUgjhsGVpjLlLKcfOASRBkvWazXs2nC1QRB8QjwjuYFD4d1aygBQGN4d6EWw8qILxVl0MOSDeWcq0uEsW72e3RahJyvarVdrGFxg1+qwMGw9wRgh51rRYYATYE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=UnTBb8tX; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="UnTBb8tX" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-4349f160d62so27303635e9.2 for ; Mon, 09 Dec 2024 01:55:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1733738118; x=1734342918; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=PoYbdSz7UumczsvgvFq1gtMn7sm/DrqPSyNoisj4lhc=; b=UnTBb8tXHaARaDPXq1ryqjBBZXGt/litInd+4ctv3b6nvs0ej3AztAN5P5wkG3IRGu QhrdyH1qPFx1tgGYjuYjsNxgcjUl3GxDrnIbymP9DgVuLLr5ko20LfudYR2Xcr5mzs5v 1Y31NTUb0eZ1E9hb0AGuhNT48GD1eHQ6R+/6ETAodMwzKN/uOrXJs3uj/ZBWQwiayLfk 2qUkDeQhTQ9Kbii03hMbrWLcJ4kTyjzXcpJ2wUzF9SUdssejQ8aYYAvphjqZ7NIwRJ9s eHEoJE9O1G8twbbwfOs3X+ZRqAJ9DLU1Xtwt2p1gY/Yg48ytTYxE0joU1qubWXL/wWA5 Ox3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733738118; x=1734342918; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PoYbdSz7UumczsvgvFq1gtMn7sm/DrqPSyNoisj4lhc=; b=h8rBnIMXt2F19pxu5qeH/g3W8t6EAoec22i+/KxcSt19yOT2/f1FFGyyY9SC9JxsmD c22NwDadDoSQhIanllj3by6r/RmRldoGfw4RWBQs4e1mCjsW5VFVIRVGQuxjEo4Mz11f QqpJbEjO5mXxkgPXXyaEaRWSnm9WS/hjg6IW/s393K+8FUWmK0S6zGwsh/9BdEZMICkL h9hjn6qFrz9/NExHpQVoWH1mHhhMJZyOIQjj2vPPhlvPnzrVUj21Wa+CijM1c4wjuoi/ fh+yhkfeDsU3oOhASO3bUDNBRpGBxu5SlROCaZ9CoFvsdJSCYHikIQneneq8sbnG/sul UZSQ== X-Forwarded-Encrypted: i=1; AJvYcCXEnG+SOfqKCFfHTRglovJ6f9nxW+5yYtR7TqKgfZZKqO4M5z746w7bFCypMwF3ys3BpuKpzH64U0M2@vger.kernel.org X-Gm-Message-State: AOJu0YwPR05+rX13Kb5OC6gzA5u7Ko+jVQE9eMGTaONfPnlCTYi/tdJz f8dkpMDb6kAhHj+mM/IO+P+KZ7uJhJusBP+c+N7igHomk7PtIy3BrHIOs1mJfjU= X-Gm-Gg: ASbGncv0KeaERj4Js9U7CZOsViV2JtQPuxwwSA1BKcYT44hSH/1fHyTh5VOeZPB+cib 9IutLjmpLZt7hT8vEqCf51HlSfO/LjC8Mp6Olzuiqda/M5Ee/Pt1Dkxkm5i+4+Ki+j78aSW+YzO xsXZyAl86oZ9+WlqhaDJzbdXH0U/wxeFnXVllv1hE1z87FBDkh2RIbocQyEl7YQbhgNOoQE8G8q d/sRYHj6oox87cr5U1CMuhfmoJjRYcmhshkRGjkJ88YNVd4bZfyvsqAWqlybJCl87fj X-Google-Smtp-Source: AGHT+IG58sGqm9G4KF/wa5VnL28uIHDOt5c6w/WNR71o0EjNxa2YOdsi9O6TM91fztvfDHXZagiiTA== X-Received: by 2002:a05:6000:1885:b0:386:32ca:aa0e with SMTP id ffacd0b85a97d-38632caaad0mr5793733f8f.5.1733738117915; Mon, 09 Dec 2024 01:55:17 -0800 (PST) Received: from [192.168.68.114] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-3862d9cf980sm9537280f8f.44.2024.12.09.01.55.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Dec 2024 01:55:17 -0800 (PST) Message-ID: <60068361-ddb7-4906-84ca-195e5eb13a0f@linaro.org> Date: Mon, 9 Dec 2024 09:55:14 +0000 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] nvmem: qfprom: Ensure access to qfprom is word aligned To: Dmitry Baryshkov , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Naman Jain References: <20241027-sar2130p-nvmem-v2-0-743c1271bf2d@linaro.org> <20241027-sar2130p-nvmem-v2-1-743c1271bf2d@linaro.org> Content-Language: en-US From: Srinivas Kandagatla In-Reply-To: <20241027-sar2130p-nvmem-v2-1-743c1271bf2d@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 26/10/2024 23:42, Dmitry Baryshkov wrote: > From: Naman Jain > > Add logic for alignment of address for reading in qfprom driver to avoid > NOC error issues due to unaligned access. The problem manifests on the > SAR2130P platform, but in msm-5.x kernels the fix is applied Is this only issue with SAR2130P? > uncoditionally. Follow this approach and uncoditionally perform aligned > reads. If there is a need of having proper register alignment this should go as part of the nvmem_config->stride and word_size configuration and not in reg_read callbacks. --srini > > Fixes: 4ab11996b489 ("nvmem: qfprom: Add Qualcomm QFPROM support.") > Signed-off-by: Naman Jain > Signed-off-by: Dmitry Baryshkov > --- > drivers/nvmem/qfprom.c | 19 ++++++++++++++++--- > 1 file changed, 16 insertions(+), 3 deletions(-) > > diff --git a/drivers/nvmem/qfprom.c b/drivers/nvmem/qfprom.c > index 116a39e804c70b4a0374f8ea3ac6ba1dd612109d..cad319e7bfcf34c9b9ab15eb331efda822699cce 100644 > --- a/drivers/nvmem/qfprom.c > +++ b/drivers/nvmem/qfprom.c > @@ -322,15 +322,28 @@ static int qfprom_reg_read(void *context, > { > struct qfprom_priv *priv = context; > u8 *val = _val; > - int i = 0, words = bytes; > + int buf_start, buf_end, index, i = 0; > void __iomem *base = priv->qfpcorrected; > + char *buffer = NULL; > + u32 read_val; > > if (read_raw_data && priv->qfpraw) > base = priv->qfpraw; > + buf_start = ALIGN_DOWN(reg, 4); > + buf_end = ALIGN(reg + bytes, 4); > + buffer = kzalloc(buf_end - buf_start, GFP_KERNEL); > + if (!buffer) { > + pr_err("memory allocation failed in %s\n", __func__); > + return -ENOMEM; > + } > > - while (words--) > - *val++ = readb(base + reg + i++); > + for (index = buf_start; index < buf_end; index += 4, i += 4) { > + read_val = readl_relaxed(base + index); > + memcpy(buffer + i, &read_val, 4); > + } > > + memcpy(val, buffer + reg % 4, bytes); > + kfree(buffer); > return 0; > } > >