From: Adam Skladowski <a39.skl@gmail.com>
To: Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: phone-devel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
Bjorn Andersson <andersson@kernel.org>,
Andy Gross <agross@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
AngeloGioacchino Del Regno <kholk11@gmail.com>,
Marijn Suijten <marijn.suijten@somainline.org>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 6/7] arm64: dts: qcom: msm8976: Split lpass region
Date: Tue, 25 Jul 2023 11:46:26 +0200 [thread overview]
Message-ID: <6008bc09-7746-546f-2c00-9b9812854ff7@gmail.com> (raw)
In-Reply-To: <fda13f70-1062-c3dc-b3ed-c7f1ad9a07db@linaro.org>
On 25.07.2023 10:44, Konrad Dybcio wrote:
> On 23.07.2023 18:08, Adam Skladowski wrote:
>> Some devices like Sony Loire uses Broadcom module over sdc3 however others
>> utilize qcom WCNSS, split shared region based on downstream pil-tz loader.
>>
>> Signed-off-by: Adam Skladowski <a39.skl@gmail.com>
>> ---
> Looks like 0x1800000 is the generic configuration:
>
> https://git.codelinaro.org/clo/la/kernel/msm-3.10/-/blob/LA.BR.1.3.7.c26-05300-8976.0/arch/arm/boot/dts/qcom/msm8976.dtsi#L93-98
>
> Konrad
Yes, indeed however as you probably noticed this region isn't called lpass rather reloc.
Downstream sometimes tends to define pools of memory where loader will do its own job.
If you read later wcnss/lpass both point to same shared memory which im not sure without reworks will work with mainline.
On top it's not really that it will even hurt Loire at the end, if you browse around internet you can easily find gists
from Pavel which have logs of pil-tz loading of lpass:
https://gist.github.com/bartcubbins/c2ff215f39fe2b3ed5d3f8444bcec83b#file-gistfile1-txt-L1289
As you can see even on loire where region is bigger it only loads first 0x1000000.
Do we really need to complicate things just for everyone else for sake of not ending with one platform having to adjust
or even not(it probably wouldn't even make a difference for loader as it will fit anyway)
On the ending note i apologize if this msg gets broken formatting first time using thunderbird
and after redesign im unable to find most options mentioned in guide.
.
next prev parent reply other threads:[~2023-07-25 9:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-23 16:08 [PATCH v2 0/7] MSM8976 PLL,RPMPD and DTS changes Adam Skladowski
2023-07-23 16:08 ` [PATCH v2 1/7] drivers: soc: qcom: rpmpd: Fix MSM8976 power domains setup Adam Skladowski
2023-07-24 20:36 ` Dmitry Baryshkov
2023-07-23 16:08 ` [PATCH v2 2/7] clk: qcom: clk-hfpll: Configure l_val in init when required Adam Skladowski
2023-07-24 14:08 ` Konrad Dybcio
2023-07-23 16:08 ` [PATCH v2 3/7] clk: qcom: hfpll: Allow matching pdata Adam Skladowski
2023-07-24 14:08 ` Konrad Dybcio
2023-07-23 16:08 ` [PATCH v2 4/7] dt-bindings: clock: qcom,hfpll: Document MSM8976 compatibles Adam Skladowski
2023-07-24 7:30 ` Krzysztof Kozlowski
2023-07-23 16:08 ` [PATCH v2 5/7] clk: qcom: hfpll: Add MSM8976 PLL data Adam Skladowski
2023-07-25 8:02 ` Konrad Dybcio
2023-07-25 10:03 ` Adam Skladowski
2023-07-23 16:08 ` [PATCH v2 6/7] arm64: dts: qcom: msm8976: Split lpass region Adam Skladowski
2023-07-25 8:44 ` Konrad Dybcio
2023-07-25 9:46 ` Adam Skladowski [this message]
2023-07-23 16:08 ` [PATCH v2 7/7] arm64: dts: qcom: msm8976: Fix smsm ipc bit shifts Adam Skladowski
2023-07-24 20:38 ` [PATCH v2 0/7] MSM8976 PLL,RPMPD and DTS changes Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6008bc09-7746-546f-2c00-9b9812854ff7@gmail.com \
--to=a39.skl@gmail.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kholk11@gmail.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=mturquette@baylibre.com \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).