From: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
To: Rob Herring <robh@kernel.org>
Cc: "David S . Miller" <davem@davemloft.net>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] dt-bindings: net: Convert UniPhier AVE4 controller to json-schema
Date: Tue, 12 May 2020 11:18:36 +0900 [thread overview]
Message-ID: <600b83e2-8063-b8ca-5406-7bf854c45ab3@socionext.com> (raw)
In-Reply-To: <20200512020126.GA22178@bogus>
Hi Rob,
On 2020/05/12 11:01, Rob Herring wrote:
> On Tue, Apr 28, 2020 at 03:31:22PM +0900, Kunihiko Hayashi wrote:
>> Convert the UniPhier AVE4 controller binding to DT schema format.
>> This changes phy-handle property to required.
>>
>> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
>> ---
(snip)
>> + phy-mode:
>> + $ref: ethernet-controller.yaml#/properties/phy-mode
>> +
>> + phy-handle:
>> + $ref: ethernet-controller.yaml#/properties/phy-handle
>
> No need for these $ref, the 1st reference did this. Just:
>
> phy-mode: true
Okay, "phy-handle" also replaces with "true".
I'll fix it in v2.
Thank you,
---
Best Regards
Kunihiko Hayashi
prev parent reply other threads:[~2020-05-12 2:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-28 6:31 [PATCH net] dt-bindings: net: Convert UniPhier AVE4 controller to json-schema Kunihiko Hayashi
2020-05-01 22:21 ` David Miller
2020-05-08 8:44 ` Kunihiko Hayashi
2020-05-12 2:01 ` Rob Herring
2020-05-12 2:18 ` Kunihiko Hayashi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=600b83e2-8063-b8ca-5406-7bf854c45ab3@socionext.com \
--to=hayashi.kunihiko@socionext.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=robh@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox