public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Lokesh Vutla <lokeshvutla@ti.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>, <t-kristo@ti.com>, <nm@ti.com>
Cc: <mark.rutland@arm.com>, <devicetree@vger.kernel.org>,
	<robh+dt@kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 1/9] arm64: dts: ti: k3-am65-main: Correct main NAVSS representation
Date: Wed, 22 Jan 2020 16:33:30 +0530	[thread overview]
Message-ID: <600df214-620b-fa41-82ef-01132d9bdfae@ti.com> (raw)
In-Reply-To: <20200122082621.4974-2-peter.ujfalusi@ti.com>



On 22/01/20 1:56 PM, Peter Ujfalusi wrote:
> NAVSS is a subsystem containing different IPs, it is not really a bus.
> Change the compatible from "simple-bus" to "simple-mfd" to reflect that.
> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
>  arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> index efb24579922c..e40f7acbec42 100644
> --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> @@ -385,8 +385,8 @@ intr_main_gpio: interrupt-controller0 {
>  		ti,sci-rm-range-girq = <0x1>;
>  	};
>  
> -	cbass_main_navss: interconnect0 {
> -		compatible = "simple-bus";
> +	cbass_main_navss: navss@30800000 {

This introduces below dtc warning when built with W=1

arch/arm64/boot/dts/ti/k3-am65-main.dtsi:388.35-530.4: Warning
(unit_address_vs_reg): /interconnect@100000/navss@30800000: node has a unit
name, but no reg property

this is representing cbass inside main_navss, just like cbass_main. You can drop
this patch and the similar mcu version.

Thanks and regards,
Lokesh

> +		compatible = "simple-mfd";
>  		#address-cells = <2>;
>  		#size-cells = <2>;
>  		ranges;
> 

  reply	other threads:[~2020-01-22 11:04 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-22  8:26 [PATCH v2 0/9] arm64: dts: ti: UDMAP and McASP support Peter Ujfalusi
2020-01-22  8:26 ` [PATCH v2 1/9] arm64: dts: ti: k3-am65-main: Correct main NAVSS representation Peter Ujfalusi
2020-01-22 11:03   ` Lokesh Vutla [this message]
2020-01-22 11:39     ` Peter Ujfalusi
2020-01-23  8:32       ` Lokesh Vutla
2020-01-23  9:46         ` Peter Ujfalusi
2020-01-22  8:26 ` [PATCH v2 2/9] arm64: dts: ti: k3-am65-main: Move secure proxy under cbass_main_navss Peter Ujfalusi
2020-01-22  8:26 ` [PATCH v2 3/9] arm64: dts: ti: k3-am65: DMA support Peter Ujfalusi
2020-01-22  8:26 ` [PATCH v2 4/9] arm64: dts: ti: k3-j721e: Correct the address for MAIN NAVSS Peter Ujfalusi
2020-01-22  8:26 ` [PATCH v2 5/9] arm64: dts: ti: k3-j721e-main: Correct main NAVSS representation Peter Ujfalusi
2020-01-22  8:26 ` [PATCH v2 6/9] arm64: dts: ti: k3-j721e-main: Move secure proxy and smmu under main_navss Peter Ujfalusi
2020-01-22  8:26 ` [PATCH v2 7/9] arm64: dts: ti: k3-j721e: DMA support Peter Ujfalusi
2020-01-22  8:26 ` [PATCH v2 8/9] arm64: dts: ti: k3-am654-main: Add McASP nodes Peter Ujfalusi
2020-01-22  8:26 ` [PATCH v2 9/9] arm64: dts: ti: k3-j721e-main: " Peter Ujfalusi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=600df214-620b-fa41-82ef-01132d9bdfae@ti.com \
    --to=lokeshvutla@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=nm@ti.com \
    --cc=peter.ujfalusi@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=t-kristo@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox